[SERVER-84299] Move absl::HashOf() off the hot path where it is only used for error messages Created: 19/Dec/23  Updated: 26/Dec/23  Resolved: 20/Dec/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Charlie Swanson Assignee: Charlie Swanson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-85065 Tracking: M3 Tech Debt Tickets Closed
Problem/Incident
Related
is related to SERVER-79736 Hash C++ data structures directly rat... Closed
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 35

 Description   

Noticed while investigating some performance changes caused by SERVER-79736 with erin.zhu@mongodb.com, we noticed that this local variable is only used in the catch block, so should be moved there.

It didn't seem to make much of a performance difference, but would be good to do anyway for clarity.



 Comments   
Comment by Githook User [ 20/Dec/23 ]

Author:

{'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com', 'username': 'cswanson310'}

Message: SERVER-84299 Move hash call off hot path into catch block

GitOrigin-RevId: c98df23ff05619712b3b414b9d3005a839285ccd
Branch: master
https://github.com/mongodb/mongo/commit/e243548e63051dad54368cd2a2ec9572115aa741

Generated at Thu Feb 08 06:54:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.