[SERVER-84360] Refactor SetClusterParameterInvocation::normalizeParameter() Created: 21/Dec/23  Updated: 30/Jan/24

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Romans Kasperovics Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: neweng, quick-tech-debt, quick-win
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Participants:

 Description   

Currently, 
SetClusterParameterInvocation::normalizeParameter() is a public method, which is only used in _configsvrSetClusterParameterCommand implementation.
I believe it is done most probably only to validate the new cluster parameter value.
 
I believe we can simplify the SetClusterParameterInvocation and ConfigsvrSetClusterParameterCommand classes by:

  • refactoring the validation out of it,
  • minimizing normalizeParameter() signature (currently it has an extra 'skipValidation' parameter to control the validation) and making it private, and
  • removing the dependency on SetClusterParameterInvocation from ConfigsvrSetClusterParameterCommand.
     

Generated at Thu Feb 08 06:54:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.