[SERVER-85483] ShardingTestFixtureCommon dtor invariant swallows exceptions Created: 19/Jan/24  Updated: 25/Jan/24

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Matt Broadstone Assignee: Backlog - Catalog and Routing
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Catalog and Routing
Participants:
Story Points: 1

 Description   

While iterating on a unit test in db_s_config_server_test I started getting a new, unexpected error

ShardingTestFixtureCommon::tearDown() must have been called before destruction

This was surprising because I hadn't touched anything about the setup/teardown of the test. After some investigation, ultimately disabling the invariant in question, I saw a new exception that my disk had run out of space (seems to be due to something like SERVER-38689 but for sharding tests). I think what's happening here is that the destructor of ShardingTestFixtureCommon is swallowing top-level exceptions since its throwing its own when the invariant fails. It would be great to just report the top-level exception, since it's the real problem.


Generated at Thu Feb 08 06:57:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.