[SERVER-85574] Allow running clang-tidy.py against the local diff Created: 23/Jan/24  Updated: 25/Jan/24

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Jason Chan Assignee: Backlog - Service Architecture
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Service Arch
Participants:

 Comments   
Comment by Alex Neben [ 25/Jan/24 ]

This doesn't work.

Consider this change. This will only get caught by clang-tidy when the template is instantiated in a.cpp. The delta as shown above won't get caught.

# a.h
float doAThing() { return 50;} #before
int doAThing() { return 50;} # after

# a.cpp
 
void foo() {
    double d = doAThing() / 20 # After change this will hit bugprone-integer-division
}

 

 

Generated at Thu Feb 08 06:58:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.