[SERVER-85798] build_patch_id is no longer working Created: 17/Jan/24  Updated: 29/Jan/24  Resolved: 29/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 8.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Simon Eismann Assignee: Trevor Guidry
Resolution: Fixed Votes: 3
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
is caused by SERVER-82640 Upload mongod --version output to S3 ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Build and Correctness OnDeck
Participants:

 Description   

compile_dist_test currently fails when build_patch_id is set, likely because this commit added a script that is run even if the compile is reused and expects ./build/install/dist-test/bin/mongod to exist.



 Comments   
Comment by Githook User [ 27/Jan/24 ]

Author:

{'name': 'Trevor', 'email': 'trevorguidry6@gmail.com', 'username': 'Trevor159'}

Message: SERVER-85798 fix build_patch_id (#18439)

GitOrigin-RevId: cbec817baa0eea96d060f78836ddd6fbb9a07c41
Branch: master
https://github.com/mongodb/mongo/commit/950acfb70444323bae116012014769177e7b1746

Comment by Ahmad Shah [ 26/Jan/24 ]

brad.devlugt@mongodb.com I believe simon.eismann@mongodb.com should have more details on this

Comment by Brad de Vlugt [ 26/Jan/24 ]

Hey john.daniels@mongodb.com and ahmad.shah@mongodb.com it sounds like we're unable to use reuse compile on the new variants due to this, leading to additional time for perf testing now that the old variants are disabled. Is this assigned to the right team? daniel.moody@mongodb.com do you know when we're planning to schedule this? 

Comment by Alice Doherty [ 23/Jan/24 ]

I've run into this issue recently. Additionally, as we've now merged SERVER-85396 which turns off the older variants, being able to use `reuse_compile_from` for the new variants will increasingly be nice to have.

Comment by Minh Luu [ 19/Jan/24 ]

An implication of this issue is that `reuse_compile_from` doesn't work, which would lead to users having to wait for 1h+ to compile MongoDB from scratch instead of using an already compiled MongoDB from a previous patch.

Comment by Max Hirschhorn [ 17/Jan/24 ]

So would it be acceptable to only do the --version check if the user set patch build parameter is not set?

Yes daniel.moody@mongodb.com, omitting the --version output when the downloaded binaries are from another Evergreen build sounds good to me. The intention of the changes from SERVER-82640 is specifically for when a custom build is being made and thus recompiling is needed.

Comment by Daniel Moody [ 17/Jan/24 ]

max.hirschhorn@mongodb.com Is the --version check always required? In this case we have a user submitted patch build which wants to skip the compile steps, by pointing to a previous patch build mongo binary tarball. It skips compilation and downloads the tarball later when its needed. So would it be acceptable to only do the --version check if the user set patch build parameter is not set?

Generated at Thu Feb 08 06:58:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.