[SERVER-85798] build_patch_id is no longer working Created: 17/Jan/24 Updated: 29/Jan/24 Resolved: 29/Jan/24 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 8.0.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Simon Eismann | Assignee: | Trevor Guidry |
| Resolution: | Fixed | Votes: | 3 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Build and Correctness OnDeck | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
compile_dist_test currently fails when build_patch_id is set, likely because this commit added a script that is run even if the compile is reused and expects ./build/install/dist-test/bin/mongod to exist. |
| Comments |
| Comment by Githook User [ 27/Jan/24 ] |
|
Author: {'name': 'Trevor', 'email': 'trevorguidry6@gmail.com', 'username': 'Trevor159'}Message: GitOrigin-RevId: cbec817baa0eea96d060f78836ddd6fbb9a07c41 |
| Comment by Ahmad Shah [ 26/Jan/24 ] |
|
brad.devlugt@mongodb.com I believe simon.eismann@mongodb.com should have more details on this |
| Comment by Brad de Vlugt [ 26/Jan/24 ] |
|
Hey john.daniels@mongodb.com and ahmad.shah@mongodb.com it sounds like we're unable to use reuse compile on the new variants due to this, leading to additional time for perf testing now that the old variants are disabled. Is this assigned to the right team? daniel.moody@mongodb.com do you know when we're planning to schedule this? |
| Comment by Alice Doherty [ 23/Jan/24 ] |
|
I've run into this issue recently. Additionally, as we've now merged |
| Comment by Minh Luu [ 19/Jan/24 ] |
|
An implication of this issue is that `reuse_compile_from` doesn't work, which would lead to users having to wait for 1h+ to compile MongoDB from scratch instead of using an already compiled MongoDB from a previous patch. |
| Comment by Max Hirschhorn [ 17/Jan/24 ] |
Yes daniel.moody@mongodb.com, omitting the --version output when the downloaded binaries are from another Evergreen build sounds good to me. The intention of the changes from |
| Comment by Daniel Moody [ 17/Jan/24 ] |
|
max.hirschhorn@mongodb.com Is the --version check always required? In this case we have a user submitted patch build which wants to skip the compile steps, by pointing to a previous patch build mongo binary tarball. It skips compilation and downloads the tarball later when its needed. So would it be acceptable to only do the --version check if the user set patch build parameter is not set? |