[SERVER-85811] Reduce need for StringBuilder allocations in WiredTiger configuration strings Created: 26/Jan/24 Updated: 02/Feb/24 Resolved: 02/Feb/24 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 8.0.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Blake Oler | Assignee: | Louis Williams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Storage Execution
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Execution Team 2024-02-05 | ||||||||
| Participants: | |||||||||
| Description |
|
We have two places we build up strings for WiredTiger config based on checks in MongoDB: These have an outsized impact on workloads, accounting for example 8% of all allocations in mixed_genny_workloads_rate_limited. It seems possible here to either have a pre-allocated buffer, or even something really dumb like a separate static string for each configuration enumeration if the underlying WiredTiger code doesn't need to modify the string. This seems like a low amount of effort to potentially positively affect the performance of high-value workloads. Reach out for details on how to see the heap analysis information. |
| Comments |
| Comment by Louis Williams [ 02/Feb/24 ] |
|
We're going to address the begin_tranasction allocations in SERVER-85527. |
| Comment by Githook User [ 02/Feb/24 ] |
|
Author: {'name': 'Louis Williams', 'email': 'louiswilliams@users.noreply.github.com', 'username': 'louiswilliams'}Message: GitOrigin-RevId: f7ed91afe60a2c6b7ac40802c6e5b21abb058912 |
| Comment by Steven Vannelli [ 30/Jan/24 ] |
|
jk reopening since we also want to evaluate all of the places where we are not using the new WT API |
| Comment by Steven Vannelli [ 30/Jan/24 ] |
|
Closing as dupe of SERVER-85527 |
| Comment by Gregory Noma [ 26/Jan/24 ] |
|
Related to |