[SERVER-85864] Consider making num_hosts_targeted_metrics use unsigned ints Created: 29/Jan/24  Updated: 30/Jan/24

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Erin McNulty Assignee: Backlog - Service Architecture
Resolution: Unresolved Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Assigned Teams:
Service Arch
Participants:

 Description   

In HELP-54999, a customer saw the value of shardingStatistics.numHostsTargeted become negative after their system had been up and running for a while. We suspect that this is because the value of shardingStatistics.numHostsTargeted exceeded the maximum value of int, and wrapped back around to become negative. 

We should consider making these metrics that cannot reasonably be negative numbers into unsigned ints, and audit the codebase for other metrics that use signed types which would be more aptly represented as unsigned types.


Generated at Thu Feb 08 06:58:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.