[SERVER-86084] Ensure find command parsing occurs in FindCmd::parse Created: 01/Feb/24 Updated: 02/Feb/24 |
|
| Status: | Needs Scheduling |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Patrick Freed | Assignee: | Backlog - Service Architecture |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Service Arch
|
||||||||
| Participants: | |||||||||
| Description |
|
FindCmd::parse currently just creates a FindCmd::Invocation and passes the request's BSON document into it, without actually parsing the request (see here). Instead, parsing is deferred until FindCmd::Invocation::run, where it's one of the first things it does. We should move the parsing logic into FindCmd::parse, since this will allow us to determine if the particular request should be subject to Admission Control or not without an extra request scan. |