|
I don't find the claim that it is used "often incorrectly" to be supported in the remaining uses. I see some were cleaned up.
SERVER-8814 seems to have been about mishandling NamespaceString strings by doing a strstr search on them instead of using the NamespaceString class and there were some cargo-cult instances of strstr used for that purpose but they were all fixed.
All remaining uses of strstr in the codebase are correct as far as I can tell.
I don't think it's known as being particularly error-prone. But you have to know when a substring search is the correct match to use. If you spell it as strstr or as something else.
|