[SERVER-9186] Lazy BSON interceptors should not explicitly store values in JS objects Created: 29/Mar/13  Updated: 10/Dec/14  Resolved: 01/Apr/13

Status: Closed
Project: Core Server
Component/s: JavaScript
Affects Version/s: 2.4.1
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Ben Becker Assignee: Ben Becker
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

namedGet and indexedGet currently set the value they get on the JS object (idea is to cache values). This can quickly exhaust v8's available heap space and lead to an OOM condition.



 Comments   
Comment by auto [ 30/Mar/13 ]

Author:

{u'date': u'2013-03-30T14:41:53Z', u'name': u'Ben Becker', u'email': u'ben.becker@10gen.com'}

Message: Reverting SERVER-9186 due to test failures
Revert "SERVER-9186: avoid storing properties on js objects in the getter interceptor"

This reverts commit 337b300277bbd104bb0012eecc09cc22bf091d8b.
Branch: v2.4
https://github.com/mongodb/mongo/commit/9e05b382ca858f496f0da65ebbbd42216fb95927

Comment by auto [ 30/Mar/13 ]

Author:

{u'date': u'2013-03-30T14:41:53Z', u'name': u'Ben Becker', u'email': u'ben.becker@10gen.com'}

Message: Reverting SERVER-9186 due to test failures
Revert "SERVER-9186: avoid storing properties on js objects in the getter interceptor"

This reverts commit 337b300277bbd104bb0012eecc09cc22bf091d8b.
Branch: v2.4
https://github.com/mongodb/mongo/commit/9e05b382ca858f496f0da65ebbbd42216fb95927

Comment by auto [ 30/Mar/13 ]

Author:

{u'date': u'2013-03-30T14:40:27Z', u'name': u'Ben Becker', u'email': u'ben.becker@10gen.com'}

Message: Reverting due to test failures

Revert "SERVER-9186: avoid storing properties on js objects in the getter interceptor"

This reverts commit e6b57b52cef4e56e93210438d89f7361af83b880.
Branch: master
https://github.com/mongodb/mongo/commit/7d24b812ead07623a838306b9beebd8cd0d5df63

Comment by auto [ 29/Mar/13 ]

Author:

{u'date': u'2013-03-29T22:39:06Z', u'name': u'Ben Becker', u'email': u'ben.becker@10gen.com'}

Message: SERVER-9186: avoid storing properties on js objects in the getter interceptor
Branch: v2.4
https://github.com/mongodb/mongo/commit/337b300277bbd104bb0012eecc09cc22bf091d8b

Comment by auto [ 29/Mar/13 ]

Author:

{u'date': u'2013-03-29T22:39:06Z', u'name': u'Ben Becker', u'email': u'ben.becker@10gen.com'}

Message: SERVER-9186: avoid storing properties on js objects in the getter interceptor
Branch: master
https://github.com/mongodb/mongo/commit/e6b57b52cef4e56e93210438d89f7361af83b880

Generated at Thu Feb 08 03:19:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.