[SERVER-9491] Upper chunk key not written properly to the log in some places Created: 28/Apr/13 Updated: 11/Jul/16 Resolved: 28/Apr/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code, Sharding |
| Affects Version/s: | 2.2.4, 2.4.3 |
| Fix Version/s: | 2.4.4, 2.5.0 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Johan Hedin | Assignee: | Scott Hernandez (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | logging, sharding | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Participants: |
| Description |
|
Upper chunk key is not written correctly to the log. In src/monog/s/balancer_policy.cpp the min key is written as the max key and in src/mongo/s/d_split.cpp the max key is missing, only the label "max" is written. https://github.com/mongodb/mongo/blob/master/src/mongo/s/balancer_policy.cpp#L450 These errors makes it difficult to diagnose shard problems. |
| Comments |
| Comment by auto [ 13/May/13 ] |
|
Author: {u'date': u'2013-04-28T16:47:26Z', u'name': u'Johan Hedin', u'email': u'johan.o.hedin@gmail.com'}Message: Fixes Upper chunk key was not written properly to the log in some places. |
| Comment by Johan Hedin [ 29/Apr/13 ] |
|
Wow, that was a quick response. Thanks! I understand that backporting to 2.2.x is probably too much to ask for since it's not the latest release. But please consider backporting to 2.4.4 when it approaches. This is just one of a couple of patches regarding logging bugs that we had to apply just to debug a tricky sharding problem. Others could hopefully benefit from this fix as well. |
| Comment by Scott Hernandez (Inactive) [ 28/Apr/13 ] |
|
Thanks for the catch and fix; keep them coming Backporting will be reviewed for 2.2.x and 2.4.x when the next release for each approaches, but since it isn't more than minor logging it is unlikely to be backported. |
| Comment by auto [ 28/Apr/13 ] |
|
Author: {u'date': u'2013-04-28T22:59:24Z', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}Message: Merge pull request #418 from johanhedin/
|
| Comment by auto [ 28/Apr/13 ] |
|
Author: {u'date': u'2013-04-28T22:59:24Z', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}Message: Merge pull request #418 from johanhedin/
|
| Comment by auto [ 28/Apr/13 ] |
|
Author: {u'date': u'2013-04-28T16:47:26Z', u'name': u'Johan Hedin', u'email': u'johan.o.hedin@gmail.com'}Message: Fixes Upper chunk key was not written properly to the log in some places. |
| Comment by Johan Hedin [ 28/Apr/13 ] |
|
Pull request here: https://github.com/mongodb/mongo/pull/418 |
| Comment by Scott Hernandez (Inactive) [ 28/Apr/13 ] |
|
Thanks for the catch – putting together a quick code review before committing. |