[SERVER-9491] Upper chunk key not written properly to the log in some places Created: 28/Apr/13  Updated: 11/Jul/16  Resolved: 28/Apr/13

Status: Closed
Project: Core Server
Component/s: Internal Code, Sharding
Affects Version/s: 2.2.4, 2.4.3
Fix Version/s: 2.4.4, 2.5.0

Type: Bug Priority: Minor - P4
Reporter: Johan Hedin Assignee: Scott Hernandez (Inactive)
Resolution: Done Votes: 0
Labels: logging, sharding
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

Upper chunk key is not written correctly to the log. In src/monog/s/balancer_policy.cpp the min key is written as the max key and in src/mongo/s/d_split.cpp the max key is missing, only the label "max" is written.

https://github.com/mongodb/mongo/blob/master/src/mongo/s/balancer_policy.cpp#L450
https://github.com/mongodb/mongo/blob/master/src/mongo/s/d_split.cpp#L477

These errors makes it difficult to diagnose shard problems.



 Comments   
Comment by auto [ 13/May/13 ]

Author:

{u'date': u'2013-04-28T16:47:26Z', u'name': u'Johan Hedin', u'email': u'johan.o.hedin@gmail.com'}

Message: Fixes SERVER-9491

Upper chunk key was not written properly to the log in some places.
Branch: v2.4
https://github.com/mongodb/mongo/commit/d05cbf2871e65052298f2a2291b076322f62a951

Comment by Johan Hedin [ 29/Apr/13 ]

Wow, that was a quick response. Thanks!

I understand that backporting to 2.2.x is probably too much to ask for since it's not the latest release. But please consider backporting to 2.4.4 when it approaches.

This is just one of a couple of patches regarding logging bugs that we had to apply just to debug a tricky sharding problem. Others could hopefully benefit from this fix as well.

Comment by Scott Hernandez (Inactive) [ 28/Apr/13 ]

Thanks for the catch and fix; keep them coming

Backporting will be reviewed for 2.2.x and 2.4.x when the next release for each approaches, but since it isn't more than minor logging it is unlikely to be backported.

Comment by auto [ 28/Apr/13 ]

Author:

{u'date': u'2013-04-28T22:59:24Z', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}

Message: Merge pull request #418 from johanhedin/SERVER-9491

SERVER-9491: Fix chunk.max logging
Branch: master
https://github.com/mongodb/mongo/commit/e39e32a60166acb3a9d72b357e00ae292645d01b

Comment by auto [ 28/Apr/13 ]

Author:

{u'date': u'2013-04-28T22:59:24Z', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}

Message: Merge pull request #418 from johanhedin/SERVER-9491

SERVER-9491: Fix chunk.max logging
Branch: master
https://github.com/mongodb/mongo/commit/e39e32a60166acb3a9d72b357e00ae292645d01b

Comment by auto [ 28/Apr/13 ]

Author:

{u'date': u'2013-04-28T16:47:26Z', u'name': u'Johan Hedin', u'email': u'johan.o.hedin@gmail.com'}

Message: Fixes SERVER-9491

Upper chunk key was not written properly to the log in some places.
Branch: master
https://github.com/mongodb/mongo/commit/534611839a35a5fcc11fa7f946ff17d8a9cb12ee

Comment by Johan Hedin [ 28/Apr/13 ]

Pull request here: https://github.com/mongodb/mongo/pull/418

Comment by Scott Hernandez (Inactive) [ 28/Apr/13 ]

Thanks for the catch – putting together a quick code review before committing.

Generated at Thu Feb 08 03:20:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.