[SERVER-9751] Make S2 geometry library to use Mongo's LOG instead of writing to std::cerr. Created: 22/May/13  Updated: 11/Jul/16  Resolved: 22/Jan/14

Status: Closed
Project: Core Server
Component/s: Logging
Affects Version/s: None
Fix Version/s: 2.5.5

Type: Improvement Priority: Major - P3
Reporter: Alexander Artemenko Assignee: Andy Schwerin
Resolution: Done Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-14467 Capture S2 debug log messages Closed
is depended on by SERVER-14894 modify S2 debug log message about int... Closed
Participants:

 Description   

Right now S2 library just writes any debugging output and errors to std::cerr. I have a patch, which changes it to use Mongo's LOG macros.

That way is much easier to find errors in geometry primitives.



 Comments   
Comment by Githook User [ 22/Jan/14 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@10gen.com'}

Message: SERVER-9751 Write log messages from S2 to the mongo logs instead of cout and cerr.
Branch: master
https://github.com/mongodb/mongo/commit/8af9af8fabd27dcde862e9cc2ccc039142c1ec1a

Comment by Alexander Artemenko [ 27/Jun/13 ]

Thank you, Andy.

Comment by Andy Schwerin [ 26/Jun/13 ]

Haven't forgotten, but my patch to add streaming to fasserts has languished. I'll poke the reviewers.

Comment by Alexander Artemenko [ 22/May/13 ]

Created a pull-request: https://github.com/mongodb/mongo/pull/430

Generated at Thu Feb 08 03:21:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.