[SERVER-9927] WSAPoll not defined on windows server 2003 64 Created: 13/Jun/13 Updated: 11/Jul/16 Resolved: 10/Oct/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Networking |
| Affects Version/s: | 2.5.0 |
| Fix Version/s: | 2.5.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Greg Studer | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | Windows |
| Participants: |
| Description |
|
Since server2003 is now our default win64 platform, our checks for WSAPoll break in sock.cpp. Need to dynamically link in WSAPoll on Windows platforms if it exists. |
| Comments |
| Comment by Mathias Stearn [ 10/Oct/13 ] |
|
Two commits meant to be on this ticket: Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: It is only available in Vista+ This commit also reverts f3ebed0f3ab8e1cf0df752fb9e44875ed1e3849d to reenable Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: |
| Comment by auto [ 28/Jun/13 ] |
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: |
| Comment by Eric Milkie [ 13/Jun/13 ] |
|
It's pretty new :/ sorry! |
| Comment by Andrew Morrow (Inactive) [ 13/Jun/13 ] |
|
OK, I think that is starting to make sense. So this test never would have passed on XP to begin with. Thats a bit odd, as I'm fairly sure I ran the test suite when I was re-enabling XP support. Or is the test maybe newer than that? |
| Comment by Eric Milkie [ 13/Jun/13 ] |
|
I see your confusion now. |
| Comment by Andrew Morrow (Inactive) [ 13/Jun/13 ] |
|
I was asking about current behavior. I'm a bit puzzled how lowering the minimum to server 2003 could have broken things, since we already had code in place to deal with the lack of WSAPoll on pre-vista platforms, which we needed for XP support. |
| Comment by Eric Milkie [ 13/Jun/13 ] |
|
Are you asking what the current behavior of the code should be, or are you suggesting what we ought to change the code to do? Currently, because we are now targetting Windows Server 2003 instead of Vista, that modified the Winsock2 header such that it obscured the WSAPoll function, so none of our Windows builds will make use of our code in that block that uses WSAPoll. We'll need to dynamically detect that function like we already are for QueryWorkingSetEx(). |
| Comment by Andrew Morrow (Inactive) [ 13/Jun/13 ] |
|
Shouldn't this just fall through to the XP support if Vista support is not detected? |
| Comment by auto [ 13/Jun/13 ] |
|
Author: {u'username': u'gregstuder', u'name': u'Greg Studer', u'email': u'greg@10gen.com'}Message: |