<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:15:07 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-2402] Allow mongoc to be added as subproject</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-2402</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;With CMake we have the ability to add an existing project as subproject, and to be compiled during the superproject build.&lt;/p&gt;</description>
                <environment></environment>
        <key id="462766">CDRIVER-2402</key>
            <summary>Allow mongoc to be added as subproject</summary>
                <type id="2" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14711&amp;avatarType=issuetype">New Feature</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="jesse@mongodb.com">A. Jesse Jiryu Davis</assignee>
                                    <reporter username="tzulea">iulian</reporter>
                        <labels>
                            <label>master</label>
                    </labels>
                <created>Wed, 22 Nov 2017 11:24:27 +0000</created>
                <updated>Sat, 28 Oct 2023 11:30:17 +0000</updated>
                            <resolved>Fri, 7 Sep 2018 02:33:55 +0000</resolved>
                                                    <fixVersion>1.10.0</fixVersion>
                                    <component>cmake</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="1995958" author="jesse" created="Fri, 7 Sep 2018 02:33:55 +0000"  >&lt;p&gt;We&apos;ve merged the libbson and libmongoc repositories into one repository, and if libbson is not install on your system then building libmongoc now builds libbson by default.&lt;/p&gt;</comment>
                            <comment id="1786349" author="xgen-internal-githook" created="Fri, 26 Jan 2018 20:15:46 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Iulian Rotaru&apos;, &apos;username&apos;: &apos;tzulea&apos;, &apos;email&apos;: &apos;iulian.rotaru@gmail.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-2402&quot; title=&quot;Allow mongoc to be added as subproject&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-2402&quot;&gt;&lt;del&gt;CDRIVER-2402&lt;/del&gt;&lt;/a&gt; compile bundled libbson&lt;/p&gt;

&lt;p&gt;If the current source directory is not the source directory (i.e mongoc&lt;br/&gt;
is a subproject), build mongoc and libbson dependency.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/6a4ba9b403f215f3b06aa04fabf24ffe5b598079&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/6a4ba9b403f215f3b06aa04fabf24ffe5b598079&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1734210" author="jesse" created="Fri, 24 Nov 2017 17:46:16 +0000"  >&lt;p&gt;Great, thanks for the explanation. We&apos;ll do this in a future release, perhaps 1.10. This is nearly the same feature as &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-1948&quot; title=&quot;CMake build should allow using bundled BSON&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-1948&quot;&gt;&lt;del&gt;CDRIVER-1948&lt;/del&gt;&lt;/a&gt;. If we include this patch and also execute &quot;git submodule --init&quot; from the CMake script, then CMake will be able to build with bundled libbson as well as the Autotools can.&lt;/p&gt;

&lt;p&gt;When we merge this, I want to be very careful about the ENABLE_STATIC logic, it looks ok to me but requires thought.&lt;/p&gt;</comment>
                            <comment id="1733536" author="tzulea" created="Thu, 23 Nov 2017 08:43:02 +0000"  >&lt;p&gt;I have uploaded a test project.&lt;br/&gt;
just go to build folder.&lt;br/&gt;
issue the following commands:&lt;br/&gt;
cmake ..&lt;br/&gt;
make &lt;/p&gt;

&lt;p&gt;Cheers.&lt;/p&gt;</comment>
                            <comment id="1733012" author="tzulea" created="Wed, 22 Nov 2017 16:44:55 +0000"  >&lt;p&gt;from clonning github branch of mongoc i saw that libbson is a submodule. so doing git submodule update --init --recursive will get us the libbson source code.&lt;br/&gt;
There are 2 scenarious:&lt;br/&gt;
1. using the option flag : ENABLE_BUILD_DEPENDECIES&lt;br/&gt;
if we go to build dir of mongoc and issue the following command:&lt;br/&gt;
&quot;cmake -DENABLE_BUILD_DEPENDECIES ..&quot; this should compile libbson and mongoc and the output will be in ../mongoc-build/src/..&lt;br/&gt;
2. Having a project &quot;test&quot; with a CMakeLists.txt. the &quot;mongoc&quot; as a folder under &quot;test&quot;. &lt;br/&gt;
Inside the test CMakeLists.txt we can have the following line:&lt;br/&gt;
add_subdirectory(mongoc)&lt;br/&gt;
target_include(test  &quot;mongoc includes &quot;)&lt;br/&gt;
target_link_libraries(test  &quot;mongoc library&quot;)&lt;/p&gt;

&lt;p&gt;There is a similar request for cxx : &lt;a href=&quot;https://jira.mongodb.org/browse/CXX-1173&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://jira.mongodb.org/browse/CXX-1173&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Regarding Disabling message function:&lt;br/&gt;
There is one already defined in mongoc cmakelists. and when i tested building mongoc with libbson &lt;br/&gt;
it stopped at the message function and there was an infinite loop. So the libbson messages shoudn&apos;t be disabled in this case since there is the same function in mongoc CMakeLists.txt.&lt;/p&gt;

&lt;p&gt;question: why not use directly message function from cmake ? mesage(STATUS ..) mesage(FATAL_ERROR ..) : &lt;a href=&quot;https://cmake.org/cmake/help/v3.0/command/message.html&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://cmake.org/cmake/help/v3.0/command/message.html&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Hopefully i was clear regarding testing.&lt;/p&gt;


</comment>
                            <comment id="1732775" author="jesse" created="Wed, 22 Nov 2017 13:20:57 +0000"  >&lt;p&gt;Can you explain a little more how this works? How do I test this? Do I git clone libbson and mongo-c-driver as two sibling directories and compile them both from a new CMakeLists that refers to each of them?&lt;/p&gt;

&lt;p&gt;Also, why disable messages from libbson configuration if libbson is a submodule? I think that output is still informative.&lt;/p&gt;</comment>
                            <comment id="1732730" author="tzulea" created="Wed, 22 Nov 2017 11:47:42 +0000"  >&lt;p&gt;bson pull request:&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/libbson/pull/207&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/libbson/pull/207&lt;/a&gt;&lt;br/&gt;
mongoc pull request:&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/pull/465&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/pull/465&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="337758">CDRIVER-1948</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="171634" name="testing.zip" size="51421586" author="tzulea" created="Thu, 23 Nov 2017 08:42:07 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|htcbkv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>