<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:15:43 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-2593] CMake &apos;distcheck&apos; strips make options/switches</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-2593</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;I recently noticed that the implementation of the &apos;distcheck&apos; target in the CMake build strips any options that are passed to &lt;tt&gt;make&lt;/tt&gt;. For instance, &lt;tt&gt;make -j 8 distcheck&lt;/tt&gt; will result in a plain invocation of &lt;tt&gt;make&lt;/tt&gt; (without the &lt;tt&gt;-j 8&lt;/tt&gt;).&lt;/p&gt;

&lt;p&gt;@jesse , what I need to know in order to implement a fix is whether you prefer that the &apos;distcheck&apos; invocation pass all given parameters to the make that gets invoked for the build, or if it should require the options be specified in a variable, like &lt;tt&gt;make distcheck BUILD_OPTS=&quot;-j 8&quot;&lt;/tt&gt;. I prefer the variable approach, as it allows specifying different options/switches/variables for different stages of the build (e.g., build, check, install, etc.). Thoughts?&lt;/p&gt;</description>
                <environment></environment>
        <key id="522256">CDRIVER-2593</key>
            <summary>CMake &apos;distcheck&apos; strips make options/switches</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="roberto.sanchez@mongodb.com">Roberto Sanchez</assignee>
                                    <reporter username="roberto.sanchez@mongodb.com">Roberto Sanchez</reporter>
                        <labels>
                    </labels>
                <created>Thu, 5 Apr 2018 03:05:34 +0000</created>
                <updated>Sat, 28 Oct 2023 11:29:57 +0000</updated>
                            <resolved>Fri, 18 May 2018 01:15:24 +0000</resolved>
                                                    <fixVersion>1.10.0</fixVersion>
                                    <component>cmake</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="1895953" author="xgen-internal-githook" created="Fri, 18 May 2018 21:54:31 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;username&apos;: &apos;rcsanchez97&apos;, &apos;name&apos;: &apos;Roberto C. S&#225;nchez&apos;, &apos;email&apos;: &apos;roberto@connexer.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-2593&quot; title=&quot;CMake &amp;#39;distcheck&amp;#39; strips make options/switches&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-2593&quot;&gt;&lt;del&gt;CDRIVER-2593&lt;/del&gt;&lt;/a&gt; pass -j 8 to make subprocess&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/9a34944441908f6da4a9a47f772cd70cc2e4d0cc&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/9a34944441908f6da4a9a47f772cd70cc2e4d0cc&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1883667" author="xgen-internal-githook" created="Fri, 4 May 2018 22:52:54 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;email&apos;: &apos;roberto@connexer.com&apos;, &apos;name&apos;: &apos;Roberto C. S&#225;nchez&apos;, &apos;username&apos;: &apos;rcsanchez97&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-2593&quot; title=&quot;CMake &amp;#39;distcheck&amp;#39; strips make options/switches&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-2593&quot;&gt;&lt;del&gt;CDRIVER-2593&lt;/del&gt;&lt;/a&gt; allow specifying make options for distcheck&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/8743a53984054652cbd0228ffed6775f2f3b2291&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/8743a53984054652cbd0228ffed6775f2f3b2291&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1856380" author="jesse" created="Thu, 5 Apr 2018 15:34:50 +0000"  >&lt;p&gt;Yeah, I agree with your approach. I&apos;m curious to see how you do argument-passing like that, as well, because it would be nice to make this possible:&lt;/p&gt;
&lt;p/&gt;
&lt;div id=&quot;syntaxplugin&quot; class=&quot;syntaxplugin&quot; style=&quot;border: 1px dashed #bbb; border-radius: 5px !important; overflow: auto; max-height: 30em;&quot;&gt;
&lt;table cellspacing=&quot;0&quot; cellpadding=&quot;0&quot; border=&quot;0&quot; width=&quot;100%&quot; style=&quot;font-size: 1em; line-height: 1.4em !important; font-weight: normal; font-style: normal; color: black;&quot;&gt;
		&lt;tbody &gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;  margin-top: 10px;   margin-bottom: 10px;  width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;make check TEST_ARGS=&quot;--no-fork -D -l /My/test/name&quot;&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
			&lt;/tbody&gt;
&lt;/table&gt;
&lt;/div&gt;
&lt;p/&gt;
&lt;p&gt;Or even better:&lt;/p&gt;
&lt;p/&gt;
&lt;div id=&quot;syntaxplugin&quot; class=&quot;syntaxplugin&quot; style=&quot;border: 1px dashed #bbb; border-radius: 5px !important; overflow: auto; max-height: 30em;&quot;&gt;
&lt;table cellspacing=&quot;0&quot; cellpadding=&quot;0&quot; border=&quot;0&quot; width=&quot;100%&quot; style=&quot;font-size: 1em; line-height: 1.4em !important; font-weight: normal; font-style: normal; color: black;&quot;&gt;
		&lt;tbody &gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;  margin-top: 10px;   margin-bottom: 10px;  width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;make test TEST_ARGS=&quot;--no-fork -D -l /My/test/name&quot;&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
			&lt;/tbody&gt;
&lt;/table&gt;
&lt;/div&gt;
&lt;p/&gt;
&lt;p&gt;I&apos;ve opened &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-2599&quot; title=&quot;Pass test options to &amp;quot;make test&amp;quot; or &amp;quot;make check&amp;quot;&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-2599&quot;&gt;&lt;del&gt;CDRIVER-2599&lt;/del&gt;&lt;/a&gt; to track the &quot;make test&quot; improvement.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="523402">CDRIVER-2599</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>CDRIVER-2434</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|htln3z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>