<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:15:44 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-2600] Port MONGOC_HAVE_WEAK_SYMBOLS check to CMake</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-2600</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;The Autotools build system checks if the compiler supports the (weak) annotation. We use it to prevent Link-Time-Optimization (LTO) in our constant-time mongoc_memcmp(), &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-815&quot; title=&quot;Use constant-time hash comparison functions&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-815&quot;&gt;&lt;del&gt;CDRIVER-815&lt;/del&gt;&lt;/a&gt;. See WeakSymbols.m4 and mongoc-memcmp.c. I&apos;m not sure this is necessary - why would LTO violate the requirement that different SCRAM keys take the same time to compare?&lt;/p&gt;

&lt;p&gt;Either remove the MONGOC_HAVE_WEAK_SYMBOLS preprocessor symbol, or port the check to CMake.&lt;/p&gt;</description>
                <environment></environment>
        <key id="523576">CDRIVER-2600</key>
            <summary>Port MONGOC_HAVE_WEAK_SYMBOLS check to CMake</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="jesse@mongodb.com">A. Jesse Jiryu Davis</assignee>
                                    <reporter username="jesse@mongodb.com">A. Jesse Jiryu Davis</reporter>
                        <labels>
                    </labels>
                <created>Sat, 7 Apr 2018 13:22:45 +0000</created>
                <updated>Sat, 28 Oct 2023 11:29:57 +0000</updated>
                            <resolved>Wed, 18 Apr 2018 13:06:14 +0000</resolved>
                                                    <fixVersion>1.10.0</fixVersion>
                                    <component>cmake</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="1867500" author="xgen-internal-githook" created="Wed, 18 Apr 2018 13:06:37 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;email&apos;: &apos;jesse@mongodb.com&apos;, &apos;username&apos;: &apos;ajdavis&apos;, &apos;name&apos;: &apos;A. Jesse Jiryu Davis&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-2600&quot; title=&quot;Port MONGOC_HAVE_WEAK_SYMBOLS check to CMake&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-2600&quot;&gt;&lt;del&gt;CDRIVER-2600&lt;/del&gt;&lt;/a&gt; don&apos;t rely on _&lt;em&gt;attribute&lt;/em&gt;_((weak))&lt;/p&gt;

&lt;p&gt;We had cargo-culted a constant-time comparison function from libsodium. We use&lt;br/&gt;
the &quot;weak&quot; attribute if the compiler supports it, to prevent the constant-time&lt;br/&gt;
comparison function from being compiled out during link-time optimization if&lt;br/&gt;
the program doesn&apos;t use its result. But we don&apos;t need to prevent link-time&lt;br/&gt;
optimization: we always use our comparison function&apos;s result.&lt;/p&gt;

&lt;p&gt;The variables had been declared volatile to prevent an aggressive optimizer&lt;br/&gt;
from pre-computing the result if both input values are known at compile time.&lt;br/&gt;
This also does not apply to our usage.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/edc686ead99eb3c762aa606e048d16480bce627e&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/edc686ead99eb3c762aa606e048d16480bce627e&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>CDRIVER-2434</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|htlusv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>