<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:15:47 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-2611] Add server reply to mongoc_apm_command_failed_t</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-2611</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;The PHP driver would like to expose the server reply for failed commands via CommandFailedEvent. In order to do this, we need &lt;tt&gt;mongoc_apm_command_failed_t&lt;/tt&gt; to contain the server reply like &lt;tt&gt;mongoc_apm_command_succeeded_t&lt;/tt&gt; does.&lt;/p&gt;</description>
                <environment></environment>
        <key id="526228">CDRIVER-2611</key>
            <summary>Add server reply to mongoc_apm_command_failed_t</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="katherine.walker@mongodb.com">Katherine Walker</assignee>
                                    <reporter username="katherine.walker@mongodb.com">Katherine Walker</reporter>
                        <labels>
                    </labels>
                <created>Thu, 12 Apr 2018 20:52:23 +0000</created>
                <updated>Sat, 28 Oct 2023 11:29:55 +0000</updated>
                            <resolved>Wed, 25 Apr 2018 15:28:30 +0000</resolved>
                                                    <fixVersion>1.10.0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="1873834" author="xgen-internal-githook" created="Wed, 25 Apr 2018 15:27:44 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;email&apos;: &apos;kvwalker@users.noreply.github.com&apos;, &apos;username&apos;: &apos;kvwalker&apos;, &apos;name&apos;: &apos;Katherine Walker&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-2611&quot; title=&quot;Add server reply to mongoc_apm_command_failed_t&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-2611&quot;&gt;&lt;del&gt;CDRIVER-2611&lt;/del&gt;&lt;/a&gt; add reply to command_failed apm&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/0a85d21c282d07d9d3a8cab9389d213606bbc0f3&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/0a85d21c282d07d9d3a8cab9389d213606bbc0f3&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1870587" author="katherine.walker" created="Fri, 20 Apr 2018 20:59:45 +0000"  >&lt;p&gt;PR: &lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/pull/492&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/pull/492&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1866250" author="katherine.walker" created="Tue, 17 Apr 2018 13:33:29 +0000"  >&lt;p&gt;Here&apos;s the PR for the SPEC ticket: &lt;a href=&quot;https://github.com/mongodb/specifications/pull/305&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/specifications/pull/305&lt;/a&gt;.&lt;/p&gt;</comment>
                            <comment id="1863564" author="jmikola@gmail.com" created="Fri, 13 Apr 2018 14:36:01 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=jesse&quot; class=&quot;user-hover&quot; rel=&quot;jesse&quot;&gt;jesse&lt;/a&gt;: IIRC, the &lt;tt&gt;command_with_opts&lt;/tt&gt; methods always ensure that the reply is at least an empty &lt;tt&gt;bson_t&lt;/tt&gt; (it allocates it up front and requires the caller to free it). Are you thinking of detecting that with &lt;tt&gt;bson_empty()&lt;/tt&gt; and instead leave it &lt;tt&gt;NULL&lt;/tt&gt; for APM, in order to make it more consistent with write and query command failures where there is no pre-allocated reply document?&lt;/p&gt;</comment>
                            <comment id="1863039" author="jesse" created="Thu, 12 Apr 2018 21:20:59 +0000"  >&lt;p&gt;This would be useful, yes. Can you start with a SPEC ticket and a pull request that adds the field to CommandFailedEvent and explains when it is non-empty?:&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/specifications/blob/master/source/command-monitoring/command-monitoring.rst#api&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/specifications/blob/master/source/command-monitoring/command-monitoring.rst#api&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;I propose that it&apos;s empty / null / whatever your language wants when there was no server reply at all, e.g. a network error. It&apos;s non-empty if the server replied with ok: 0.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="474523">PHPC-1076</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|htm9v3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>