<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:17:13 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-3134] Append wrapping driver platform data before CFLAGS and LDFLAGS</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-3134</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/PHPC-1378&quot; title=&quot;CFLAGS and LDFLAGS can cause truncated platform info in client metadata handshake&quot; class=&quot;issue-link&quot; data-issue-key=&quot;PHPC-1378&quot;&gt;&lt;del&gt;PHPC-1378&lt;/del&gt;&lt;/a&gt; presents a case where PHP platform information is getting cut off due to user-specified CFLAGS and LDFLAGS taking precedence in the handshake document (limited to &lt;a href=&quot;https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#limitations&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;512 bytes&lt;/a&gt;). While PHP could avoid setting these constants in its own build configuration, that wouldn&apos;t apply to deployments where libmongoc is used as a system library. I would like to propose deferring CFLAG/LDFLAG appending until after the wrapping driver&apos;s own platform info.&lt;/p&gt;

&lt;p&gt;This would require some reordering of the handshake construction, given that the platform string is first initialized during &lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/blob/1.14.0/src/libmongoc/src/mongoc/mongoc-handshake.c#L409&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;_mongoc_handshake_init&lt;/tt&gt;&lt;/a&gt;, which is likely before a wrapping driver would have a chance to call &lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/blob/1.14.0/src/libmongoc/src/mongoc/mongoc-handshake.c#L565&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;mongoc_handshake_data_append&lt;/tt&gt;&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;Note: &quot;posix&quot;, &quot;stdc&quot;, and compiler info are also appended to the platform string before a wrapping driver&apos;s data; however, I&apos;m not too concerned with those fields as their values should be short (unlike CFLAGS and LDFLAGS, which can easily exceed a handshake&apos;s size limit).&lt;/p&gt;</description>
                <environment></environment>
        <key id="770798">CDRIVER-3134</key>
            <summary>Append wrapping driver platform data before CFLAGS and LDFLAGS</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="haris.sheikh@mongodb.com">Haris Sheikh</assignee>
                                    <reporter username="jmikola@mongodb.com">Jeremy Mikola</reporter>
                        <labels>
                            <label>neweng</label>
                    </labels>
                <created>Fri, 17 May 2019 15:56:58 +0000</created>
                <updated>Sat, 28 Oct 2023 11:29:17 +0000</updated>
                            <resolved>Fri, 21 Jun 2019 20:49:58 +0000</resolved>
                                                    <fixVersion>1.15.0</fixVersion>
                                    <component>libmongoc</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="2299076" author="xgen-internal-githook" created="Wed, 26 Jun 2019 21:37:43 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Haris Sheikh&apos;, &apos;email&apos;: &apos;harissheikh@Hariss-MacBook-Pro.local&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-3134&quot; title=&quot;Append wrapping driver platform data before CFLAGS and LDFLAGS&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-3134&quot;&gt;&lt;del&gt;CDRIVER-3134&lt;/del&gt;&lt;/a&gt; fixed error in oversized_flags test&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/a4c9cb29b5bde87134dd6d9fcb4489fae08e11c4&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/a4c9cb29b5bde87134dd6d9fcb4489fae08e11c4&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2293625" author="xgen-internal-githook" created="Fri, 21 Jun 2019 20:49:16 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Haris Sheikh&apos;, &apos;email&apos;: &apos;harissheikh@Hariss-MacBook-Pro.local&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-3134&quot; title=&quot;Append wrapping driver platform data before CFLAGS and LDFLAGS&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-3134&quot;&gt;&lt;del&gt;CDRIVER-3134&lt;/del&gt;&lt;/a&gt; append wrapping driver platform data before cflags and ldflags&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/facdfe99a069fbfd33ed8a829e2d07f7e3074fc7&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/facdfe99a069fbfd33ed8a829e2d07f7e3074fc7&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2250543" author="jmikola@gmail.com" created="Fri, 17 May 2019 16:02:13 +0000"  >&lt;p&gt;Alternatively, we might consider dropping CFLAGS and LDFLAGS from client metadata altogether, since it&apos;s very likely these values may exceed the handshake limit if set and be truncated (with or without extra driver platform data appended). I suppose this is a question of whether incomplete CFLAGS/LDFLAGS are better than no data at all. Is it possible that truncated CFLAGS could lead to incorrect assumptions?&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="770777">PHPC-1378</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hupamf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>