<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:20:13 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-4195] aggregate-write-readPreference tests should not expect readConcern to be passed to pre-4.2 servers</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-4195</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;This ticket was split from &lt;a href=&quot;https://jira.mongodb.org/browse/DRIVERS-1958&quot; title=&quot;aggregate-write-readPreference tests should not expect readConcern to be passed to pre-4.2 servers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;DRIVERS-1958&quot;&gt;DRIVERS-1958&lt;/a&gt;, please see that ticket for a detailed description. &lt;/p&gt;</description>
                <environment></environment>
        <key id="1903379">CDRIVER-4195</key>
            <summary>aggregate-write-readPreference tests should not expect readConcern to be passed to pre-4.2 servers</summary>
                <type id="14901" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14700&amp;avatarType=issuetype">Spec Change</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="colby.pike@mongodb.com">Colby Pike</assignee>
                                    <reporter username="dbeng-pm-bot">PM Bot</reporter>
                        <labels>
                    </labels>
                <created>Wed, 20 Oct 2021 14:34:15 +0000</created>
                <updated>Fri, 18 Feb 2022 23:30:09 +0000</updated>
                            <resolved>Tue, 25 Jan 2022 22:28:48 +0000</resolved>
                                                    <fixVersion>1.21.0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="4365290" author="xgen-internal-githook" created="Fri, 18 Feb 2022 23:30:09 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Jesse Williamson&apos;, &apos;email&apos;: &apos;jesse.williamson@mongodb.com&apos;, &apos;username&apos;: &apos;chardan&apos;}
&lt;p&gt;Message: CDRIVER-3992 - Use OP_MSG if a server API version is requested (#930)&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;DNM: appears to be switching between OPCODE_QUERY and OPCODE_MSG but breaking&lt;br/&gt;
regression tests need scrutiny. Some cluster tests in particular may be getting&lt;br/&gt;
the wrong data.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix copyright notice with missing URL.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix missing OPCODE_QUERY command; respond to some review comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Add functions for detect user-selected server API; more bug fixes; clang-format.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix calls to mongoc_cluster_run_command_private() for some build targets&lt;br/&gt;
(cyrus, sspi).&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixes bug on copying OPCODE_MSG.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Tidy up, fix CI build errors.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Compiler warning placation when ASAN is enabled.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;gcc 11.2.1 complains about a function returning without value.&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix Cyrus build error.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix leaked memory from double-allocation; populate &quot;ns&quot;&lt;br/&gt;
field in RPC struct.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Patch for &quot;ns not found&quot; being reported in tests; verify ipv6 client test locally;&lt;br/&gt;
tidy up comments (most to be removed)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;CDRIVER-3893: Conditionally support $merge and $out execution on secondaries (#904)&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;Allow readPreference:secondary with $merge and $out. &lt;span class=&quot;error&quot;&gt;&amp;#91;Finish CDRIVER-3893, CDRIVER-4224, and CDRIVER-4195&amp;#93;&lt;/span&gt;&lt;/li&gt;
	&lt;li&gt;Pass around the effectively chosen read mode used in server selection back to the command builder&lt;/li&gt;
	&lt;li&gt;Update doc func name&lt;/li&gt;
	&lt;li&gt;Fix duplicate doc comments&lt;/li&gt;
	&lt;li&gt;Consolidate duplicate state in suitable_servers()&lt;/li&gt;
	&lt;li&gt;Less magic numbers&lt;/li&gt;
	&lt;li&gt;Clarify wire version checks&lt;/li&gt;
	&lt;li&gt;Force primary read preference if talking to a single server older than 5.0&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;Add functions for detect user-selected server API; more bug fixes; clang-format.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Merge; Fixes bug on copying OPCODE_MSG.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixes missing command bug; reveals another.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixes &quot;unknown error&quot; on cluster hello.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;DNM: take out some chatter&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixes &quot;failed to receive length header&quot;.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Great appreciation to Kevin for spotting the right switch to flip!&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Rebased on 4098. Testing pass/fail versus MONGODB_API_VERSION=1&lt;br/&gt;
or not selected.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Clean-up comments, notice changes, etc. in response to review comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Avoid mock server test failure related to applying server API when&lt;br/&gt;
incompatible.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;mongoc_client test patches: Client, background monitor/scanning,&lt;br/&gt;
streamable hello, topology, etc..&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Start adding individual client support to some test routines.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Remove rogue code block.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Revert changes to mongoc-server-description.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Remove unused function.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixups in response to review comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix more unit tests (discovery and monitoring).&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix unit tests (speculative auth).&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Shuffle functions around to reduce diff delta.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Comment added as per review suggestion.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Temporarily disable cmd_on_unknown_serverid tests.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Split declaration and definition of *_uses_server_api() functions&lt;br/&gt;
into the modules defining the type they act upon.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;DNM: trying patches to reconcile local vs. remote errors&lt;br/&gt;
(Thanks to Kevin for these!)&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Enable adding $db to topology scanner.&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;Avoid adding duplicate $db field.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_change_stream_live_single_server() failure.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;FAIL:/home/jesse/work/mongo-c-driver/src/libmongoc/tests/test-mongoc-change-stream.c:251  test_change_stream_live_single_server()&lt;br/&gt;
  mongoc_collection_insert_one (coll, tmp_bson (((void *)0)), ((void *)0), ((void *)0), &amp;amp;error)&lt;br/&gt;
  BSON field &apos;insert.apiVersion&apos; is an unknown field.&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix assertion failure in legacy stream test.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_framework_client_new_no_server_api&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix failure in test_split_insert()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_bypass_not_sent()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_bypass_validation()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Finish write tests; revert client change w/ no effect.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix memory leak (calling wrong release function).&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Include apiVersion in toplogy OP_MSG assembly.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixup more non-version aware tests.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixup C99 style comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Clean up hello.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Hello is assembled across several functions, let&apos;s use the right one.&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixes /change_streams/legacy/change-streams-errors&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;Fix &quot;please configure your MongoClient&apos;s API version&quot;.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_bypass_not_sent()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_insert()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Raise assertion on invalid API version.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Generate ns only for OPCODE_QUERY.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Respond to review comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Remove superfluous comment.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Continue to address review comments, formatting.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Start reverting some tests to be both versioned and legacy hello aware.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Modify tests to work with legacy and versioned hello.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Modify mock_server to work with legacy/versioned hello.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Remove extraneous comments, reformat.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Wrangle special test _test_hello_ok()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;This test is a little non-orthogonal compared to the others, and&lt;br/&gt;
requires special JSON inspection to be versioned vs. legacy&lt;br/&gt;
hello aware.&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix test_mongoc_client_resends_handshake_on_network_error()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fixup test_client_appname()&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;As with the previous commits, this allows these tests to&lt;br/&gt;
be aware of the difference between versioned and legacy&lt;br/&gt;
hello.&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Respond to review comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;p&gt;sq ifx&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Formatting with clang-format&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Fix regression in versioned tests that shouldn&apos;t try to connect to a&lt;br/&gt;
server.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Respond to review comments; some reformatting.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Respond to review comments.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Revert test-mongoc-sample-commands.c&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Revert this to earlier commit (its history is a bit complicated&lt;br/&gt;
in my branch because of an earlier merge; this should reconcile&lt;br/&gt;
it).&lt;/p&gt;

&lt;p&gt;Signed-off-by: Jesse Williamson &amp;lt;jesse.williamson@mongodb.com&amp;gt;&lt;/p&gt;

&lt;p&gt;Co-authored-by: vector-of-bool &amp;lt;vectorofbool@gmail.com&amp;gt;&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/030461c1715b0e81696bc633dcc62ddd921a5855&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/030461c1715b0e81696bc633dcc62ddd921a5855&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4314301" author="JIRAUSER1260880" created="Tue, 25 Jan 2022 22:28:48 +0000"  >&lt;p&gt;Done as part of CDRIVER-3893&lt;/p&gt;</comment>
                            <comment id="4314291" author="xgen-internal-githook" created="Tue, 25 Jan 2022 22:26:55 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;vector-of-bool&apos;, &apos;email&apos;: &apos;vectorofbool@gmail.com&apos;, &apos;username&apos;: &apos;vector-of-bool&apos;}
&lt;p&gt;Message: CDRIVER-3893: Conditionally support $merge and $out execution on secondaries (#904)&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Allow readPreference:secondary with $merge and $out. &lt;span class=&quot;error&quot;&gt;&amp;#91;Finish CDRIVER-3893, CDRIVER-4224, and CDRIVER-4195&amp;#93;&lt;/span&gt;&lt;/li&gt;
	&lt;li&gt;Pass around the effectively chosen read mode used in server selection back to the command builder&lt;/li&gt;
	&lt;li&gt;Update doc func name&lt;/li&gt;
	&lt;li&gt;Fix duplicate doc comments&lt;/li&gt;
	&lt;li&gt;Consolidate duplicate state in suitable_servers()&lt;/li&gt;
	&lt;li&gt;Less magic numbers&lt;/li&gt;
	&lt;li&gt;Clarify wire version checks&lt;/li&gt;
	&lt;li&gt;Force primary read preference if talking to a single server older than 5.0&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/9eba451d603cfa92ae5e27cc3bbd2b40821a6560&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/9eba451d603cfa92ae5e27cc3bbd2b40821a6560&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;
</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10620">
                    <name>Issue split</name>
                                                                <inwardlinks description="split from">
                                        <issuelink>
            <issuekey id="1903378">DRIVERS-1958</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                                        </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hzq7of:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_21457" key="com.atlassian.jira.plugin.system.customfieldtypes:textarea">
                        <customfieldname>Upstream Changes Summary</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/DRIVERS-1958&quot; title=&quot;aggregate-write-readPreference tests should not expect readConcern to be passed to pre-4.2 servers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;DRIVERS-1958&quot;&gt;DRIVERS-1958&lt;/a&gt;:&lt;br/&gt;
Drivers should sync unified CRUD spec tests with &lt;a href=&quot;https://github.com/mongodb/specifications/commit/dce2c48e697e9a7d08faad871e86b415bb481df7&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;mongodb/specifications@dce2c48&lt;/a&gt;.&lt;/p&gt;</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>