<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:09:47 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-530] SASL version check does not do what you think it does</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-530</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;mongo-c-driver 1.1.0 (and the latest code in the repository also) contains the file src/mongoc/mongoc-sasl.c with this code intended to only call the function sasl_client_done on SASL version 2.1.24 or greater:&lt;/p&gt;

&lt;p/&gt;
&lt;div id=&quot;syntaxplugin&quot; class=&quot;syntaxplugin&quot; style=&quot;border: 1px dashed #bbb; border-radius: 5px !important; overflow: auto; max-height: 30em;&quot;&gt;
&lt;table cellspacing=&quot;0&quot; cellpadding=&quot;0&quot; border=&quot;0&quot; width=&quot;100%&quot; style=&quot;font-size: 1em; line-height: 1.4em !important; font-weight: normal; font-style: normal; color: black;&quot;&gt;
		&lt;tbody &gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;  margin-top: 10px;   width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;#if (SASL_VERSION_MAJOR &amp;gt;= 2) &amp;amp;&amp;amp; \&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;   width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;    (SASL_VERSION_MINOR &amp;gt;= 1) &amp;amp;&amp;amp; \&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;   width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;    (SASL_VERSION_STEP &amp;gt;= 24) &amp;amp;&amp;amp; \&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;   width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;    (!defined(__APPLE__))&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;   width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;   sasl_client_done ();&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;   margin-bottom: 10px;  width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;#endif&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
			&lt;/tbody&gt;
&lt;/table&gt;
&lt;/div&gt;
&lt;p/&gt;

&lt;p&gt;This code is clearly completely wrong. What will happen if the SASL version is 2.2.0? or 3.0.0? (sasl_client_done will not be called, though you would want it to be.)&lt;/p&gt;

&lt;p&gt;Another problem: you&apos;re checking the SASL version at compile time. What if the version of SASL at compile time is different from the SASL version at runtime?&lt;/p&gt;</description>
                <environment></environment>
        <key id="184536">CDRIVER-530</key>
            <summary>SASL version check does not do what you think it does</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="ryandesign">Ryan Schmidt</reporter>
                        <labels>
                    </labels>
                <created>Tue, 17 Feb 2015 07:52:34 +0000</created>
                <updated>Mon, 8 Jan 2024 15:30:41 +0000</updated>
                            <resolved>Mon, 8 Jun 2015 17:43:16 +0000</resolved>
                                    <version>1.1.0</version>
                                    <fixVersion>1.2-beta0</fixVersion>
                                    <component>auth</component>
                    <component>Build</component>
                    <component>libmongoc</component>
                                        <votes>0</votes>
                                    <watches>5</watches>
                                                                                                                <comments>
                            <comment id="997325" author="xgen-internal-githook" created="Wed, 5 Aug 2015 17:22:13 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; fix check for sasl_client_done&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/a7b013e1bf698f1cea594dc34b8906e1bb4be5fe&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/a7b013e1bf698f1cea594dc34b8906e1bb4be5fe&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="997324" author="xgen-internal-githook" created="Wed, 5 Aug 2015 17:22:12 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; check for sasl_client_done&lt;br/&gt;
(cherry picked from commit 672670c)&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/f725505dd38f4ba3660ab3857c2be079fdbea039&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/f725505dd38f4ba3660ab3857c2be079fdbea039&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="938556" author="xgen-internal-githook" created="Fri, 12 Jun 2015 02:34:18 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@emptysquare.net&apos;}
&lt;p&gt;Message: Merge pull request #238 from ajdavis/&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt;-sasl-version-check&lt;/p&gt;

&lt;p&gt;C Driver SASL fixes&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/06a0fab5ae4ecaa5aff6dcab01bdc2beca891818&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/06a0fab5ae4ecaa5aff6dcab01bdc2beca891818&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="938555" author="xgen-internal-githook" created="Fri, 12 Jun 2015 02:34:18 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; fix check for sasl_client_done&lt;br/&gt;
(cherry picked from commit a7b013e)&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/8055633d19eef92a735dbaf805a440b1f1f7a388&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/8055633d19eef92a735dbaf805a440b1f1f7a388&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="938554" author="xgen-internal-githook" created="Fri, 12 Jun 2015 02:34:17 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; cleaner check for sasl_client_done&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/8762b735ae180d99f9337377259b6f5bc40905a0&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/8762b735ae180d99f9337377259b6f5bc40905a0&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="938553" author="xgen-internal-githook" created="Fri, 12 Jun 2015 02:34:16 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; check for sasl_client_done&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/672670cd4938c346849c29b0c980f084e1f476b1&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/672670cd4938c346849c29b0c980f084e1f476b1&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="933094" author="xgen-internal-githook" created="Fri, 5 Jun 2015 20:03:31 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; fix check for sasl_client_done&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/a7b013e1bf698f1cea594dc34b8906e1bb4be5fe&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/a7b013e1bf698f1cea594dc34b8906e1bb4be5fe&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="932929" author="xgen-internal-githook" created="Fri, 5 Jun 2015 18:07:13 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-530&quot; title=&quot;SASL version check does not do what you think it does&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-530&quot;&gt;&lt;del&gt;CDRIVER-530&lt;/del&gt;&lt;/a&gt; check for sasl_client_done&lt;br/&gt;
(cherry picked from commit 672670c)&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/f725505dd38f4ba3660ab3857c2be079fdbea039&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/f725505dd38f4ba3660ab3857c2be079fdbea039&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="838455" author="jason.carey" created="Thu, 26 Feb 2015 21:45:34 +0000"  >&lt;p&gt;Hi,&lt;/p&gt;

&lt;p&gt;The version check is certainly sloppy, thanks for pointing that out.  We&apos;ll definitely want to disambiguate it for a future release.  &lt;/p&gt;

&lt;p&gt;I don&apos;t think this can be a bug today (we require a min version of 2.1.6, and 2.1.26 is the latest cyrus sasl release from 3 years ago), and looking closely, I think we may just be doing this entirely wrong (sasl_client_done unloads global plugins... we probably shouldn&apos;t be doing that on a per connection basis).  So I&apos;m going to open a new ticket to check on that functionality that I&apos;ll have this ticket depend on.&lt;/p&gt;

&lt;p&gt;Regards,&lt;br/&gt;
Jason&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                            <outwardlinks description="depends on">
                                        <issuelink>
            <issuekey id="186496">CDRIVER-547</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="208486">PHPC-306</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="281143">CDRIVER-1207</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="287026">CDRIVER-1233</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hs956v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1136</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="557">C Driver 2015Q2 sprint 2</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>