<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Wed Feb 07 21:09:53 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[CDRIVER-560] Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c</title>
                <link>https://jira.mongodb.org/browse/CDRIVER-560</link>
                <project id="10030" key="CDRIVER">C Driver</project>
                    <description>&lt;p&gt;the function mongoc_client_pool_get_size() is declared in mongoc-client-pool-private.h and its implementation in mongoc-client-pool-private.c.&lt;/p&gt;

&lt;p&gt;The issue is mongoc-client-pool-private.c doesn&apos;t include mongoc-client-pool-private.h, therefore, the compiler doesn&apos;t see the declaration of this function while compiling the implementation of this function. There is a warning on OS X.&lt;/p&gt;</description>
                <environment></environment>
        <key id="187851">CDRIVER-560</key>
            <summary>Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="5" iconUrl="https://jira.mongodb.org/images/icons/priorities/trivial.svg">Trivial - P5</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="jesse@mongodb.com">A. Jesse Jiryu Davis</assignee>
                                    <reporter username="jeromelebel">Jerome Lebel</reporter>
                        <labels>
                    </labels>
                <created>Fri, 6 Mar 2015 13:21:51 +0000</created>
                <updated>Wed, 7 Oct 2015 21:13:53 +0000</updated>
                            <resolved>Sun, 5 Apr 2015 14:29:46 +0000</resolved>
                                    <version>1.1.2</version>
                                    <fixVersion>1.1.5</fixVersion>
                                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="1054526" author="xgen-internal-githook" created="Wed, 7 Oct 2015 21:13:53 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: Merge remote-tracking branch &apos;upstream/master&apos; into 1.2.0-dev&lt;/p&gt;

&lt;ol&gt;
	&lt;li&gt;By A. Jesse Jiryu Davis (7) and others&lt;/li&gt;
&lt;/ol&gt;
&lt;ul&gt;
	&lt;li&gt;upstream/master:&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-606&quot; title=&quot;Static library build failure on Mac OS&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-606&quot;&gt;&lt;del&gt;CDRIVER-606&lt;/del&gt;&lt;/a&gt; Call mongoc_init () in test-secondary&lt;br/&gt;
  Begin next release&apos;s changelog&lt;br/&gt;
  Spelling.&lt;br/&gt;
  Include header for suppress_one_message() in test-mongoc-uri.c.&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-605&quot; title=&quot;Documentation bug&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-605&quot;&gt;&lt;del&gt;CDRIVER-605&lt;/del&gt;&lt;/a&gt; fix function name in collection_find_indexes page.&lt;br/&gt;
  Fix version no. in guide to building from release tarball.&lt;br/&gt;
  post release bump&lt;br/&gt;
  Release 1.1.4&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-580&quot; title=&quot;Write concern with w=0 and j=true is a GLE op&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-580&quot;&gt;&lt;del&gt;CDRIVER-580&lt;/del&gt;&lt;/a&gt;: fsync or j in write concern imply GLE&lt;br/&gt;
  Use write concern macros instead of magic numbers&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Conflicts:&lt;br/&gt;
	src/libbson&lt;br/&gt;
	src/mongoc/mongoc-client-pool.c&lt;br/&gt;
	src/mongoc/mongoc-uri.c&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/673d4a7aab3d8b46a676ea97b4cd46c5956f976c&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/673d4a7aab3d8b46a676ea97b4cd46c5956f976c&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="875293" author="xgen-internal-githook" created="Tue, 7 Apr 2015 23:10:30 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: Merge remote-tracking branch &apos;upstream/master&apos; into 1.2.0-dev&lt;/p&gt;

&lt;ol&gt;
	&lt;li&gt;By A. Jesse Jiryu Davis (7) and others&lt;/li&gt;
&lt;/ol&gt;
&lt;ul&gt;
	&lt;li&gt;upstream/master:&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-606&quot; title=&quot;Static library build failure on Mac OS&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-606&quot;&gt;&lt;del&gt;CDRIVER-606&lt;/del&gt;&lt;/a&gt; Call mongoc_init () in test-secondary&lt;br/&gt;
  Begin next release&apos;s changelog&lt;br/&gt;
  Spelling.&lt;br/&gt;
  Include header for suppress_one_message() in test-mongoc-uri.c.&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-605&quot; title=&quot;Documentation bug&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-605&quot;&gt;&lt;del&gt;CDRIVER-605&lt;/del&gt;&lt;/a&gt; fix function name in collection_find_indexes page.&lt;br/&gt;
  Fix version no. in guide to building from release tarball.&lt;br/&gt;
  post release bump&lt;br/&gt;
  Release 1.1.4&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-580&quot; title=&quot;Write concern with w=0 and j=true is a GLE op&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-580&quot;&gt;&lt;del&gt;CDRIVER-580&lt;/del&gt;&lt;/a&gt;: fsync or j in write concern imply GLE&lt;br/&gt;
  Use write concern macros instead of magic numbers&lt;br/&gt;
  &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Conflicts:&lt;br/&gt;
	src/libbson&lt;br/&gt;
	src/mongoc/mongoc-client-pool.c&lt;br/&gt;
	src/mongoc/mongoc-uri.c&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/673d4a7aab3d8b46a676ea97b4cd46c5956f976c&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/673d4a7aab3d8b46a676ea97b4cd46c5956f976c&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="875287" author="xgen-internal-githook" created="Tue, 7 Apr 2015 23:10:25 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@emptysquare.net&apos;}
&lt;p&gt;Message: Merge pull request #189 from ajdavis/&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;-client-pool-private-h&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="875286" author="xgen-internal-githook" created="Tue, 7 Apr 2015 23:10:24 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@emptysquare.net&apos;}
&lt;p&gt;Message: Merge pull request #189 from ajdavis/&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;-client-pool-private-h&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="875282" author="xgen-internal-githook" created="Tue, 7 Apr 2015 23:10:20 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;br/&gt;
Branch: 1.2.0-dev&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/0b7d19020cadb6bf293b3ff4d031ba74901a361f&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/0b7d19020cadb6bf293b3ff4d031ba74901a361f&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="873040" author="xgen-internal-githook" created="Sun, 5 Apr 2015 14:29:20 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@emptysquare.net&apos;}
&lt;p&gt;Message: Merge pull request #189 from ajdavis/&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;-client-pool-private-h&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="873039" author="xgen-internal-githook" created="Sun, 5 Apr 2015 14:29:20 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@emptysquare.net&apos;}
&lt;p&gt;Message: Merge pull request #189 from ajdavis/&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;-client-pool-private-h&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/e3f7c92ee623d72ccae8024b5694126fc1047042&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="873038" author="xgen-internal-githook" created="Sun, 5 Apr 2015 14:29:19 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;ajdavis&apos;, u&apos;name&apos;: u&apos;A. Jesse Jiryu Davis&apos;, u&apos;email&apos;: u&apos;jesse@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/CDRIVER-560&quot; title=&quot;Need to add mongoc-client-pool-private.h in mongoc-client-pool-private.c&quot; class=&quot;issue-link&quot; data-issue-key=&quot;CDRIVER-560&quot;&gt;&lt;del&gt;CDRIVER-560&lt;/del&gt;&lt;/a&gt;: Include private header in mongoc-client-pool.c.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/commit/0b7d19020cadb6bf293b3ff4d031ba74901a361f&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/commit/0b7d19020cadb6bf293b3ff4d031ba74901a361f&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="851044" author="jeromelebel" created="Fri, 13 Mar 2015 00:55:31 +0000"  >&lt;p&gt;And the error is:&lt;/p&gt;

&lt;p&gt;/Users/jerome/Sources/MongoHub-Mac/Libraries/MongoObjCDriver/Libraries/mongo-c-driver/src/mongoc/mongoc-client-pool.c:228:1: error: no previous prototype for function &apos;mongoc_client_pool_get_size&apos; &lt;span class=&quot;error&quot;&gt;&amp;#91;-Werror,-Wmissing-prototypes&amp;#93;&lt;/span&gt;&lt;br/&gt;
mongoc_client_pool_get_size (mongoc_client_pool_t *pool)&lt;/p&gt;</comment>
                            <comment id="849449" author="jeromelebel" created="Wed, 11 Mar 2015 21:33:10 +0000"  >&lt;p&gt;The pull request fixes exactly the issue.&lt;/p&gt;

&lt;p&gt;The problem is if the declaration is changed in mongoc-client-pool-private.h or the implementation in mongoc-client-pool.c, there is no way for the compiler to let you know the interface don&apos;t match. That&apos;s why there is a warning saying : since the function is not static, you need to have a declaration of this function somewhere in the mongoc-client-pool.c&lt;/p&gt;

&lt;p&gt;I&apos;m compiling the source myself with Xcode on OS X.&lt;/p&gt;</comment>
                            <comment id="849422" author="jesse" created="Wed, 11 Mar 2015 21:17:29 +0000"  >&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/pull/189&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-c-driver/pull/189&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="849365" author="jesse" created="Wed, 11 Mar 2015 20:39:34 +0000"  >&lt;p&gt;Can you tell us how you&apos;re building the driver and what warning you see please?&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hs6viv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>165552</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>