<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 08:36:31 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[GODRIVER-1498] Refactor URI parsing to use pointers</title>
                <link>https://jira.mongodb.org/browse/GODRIVER-1498</link>
                <project id="14289" key="GODRIVER">Go Driver</project>
                    <description>&lt;p&gt;&lt;b&gt;New Description&lt;/b&gt;: The URI parser uses two variables per option: one for the value and one for determining if the option is set. This code that uses the parser is inconsistent. Sometimes, it checks the &lt;tt&gt;*Set&lt;/tt&gt; variant but for some boolean options that are only useful if set to true (e.g. SSL), it will directly check &lt;tt&gt;cs.SSL&lt;/tt&gt; rather than &lt;tt&gt;cs.SSLSet &amp;amp;&amp;amp; cs.SSL&lt;/tt&gt;. Let&apos;s refactor this to use pointers like the rest of our options code for consistency.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;&lt;b&gt;Previous Description&lt;/b&gt;: Pretty minor, but ConnString.SSLSet is never read by anything. I believe &lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/blob/a96725e2d7cb39d0c31f7f6605305ad3f92787c1/x/mongo/driver/topology/topology_options.go#L112&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/blob/a96725e2d7cb39d0c31f7f6605305ad3f92787c1/x/mongo/driver/topology/topology_options.go#L112&lt;/a&gt; should actually be &quot;if cs.SSLSet &amp;amp;&amp;amp; cs.SSL {&quot;.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1194021">GODRIVER-1498</key>
            <summary>Refactor URI parsing to use pointers</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="10038" iconUrl="https://jira.mongodb.org/images/icons/subtask.gif" description="">Backlog</status>
                    <statusCategory id="2" key="new" colorName="default"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="bartle">David Bartley</reporter>
                        <labels>
                    </labels>
                <created>Thu, 27 Feb 2020 07:31:11 +0000</created>
                <updated>Mon, 8 Jan 2024 21:33:05 +0000</updated>
                                                                            <component>Options &amp;amp; Configuration</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="2914995" author="divjot.arora" created="Thu, 27 Feb 2020 20:03:01 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=bartle&quot; class=&quot;user-hover&quot; rel=&quot;bartle&quot;&gt;bartle&lt;/a&gt; Thanks for the quick reply. I&apos;ve edited the ticket title and description to reflect the work that should be done.&lt;/p&gt;</comment>
                            <comment id="2914903" author="bartle" created="Thu, 27 Feb 2020 19:21:35 +0000"  >&lt;p&gt;Yes, that seems like a great approach.&lt;/p&gt;</comment>
                            <comment id="2914374" author="divjot.arora" created="Thu, 27 Feb 2020 15:47:56 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=bartle&quot; class=&quot;user-hover&quot; rel=&quot;bartle&quot;&gt;bartle&lt;/a&gt; I&apos;d like to do a larger piece of work and re-write the connstring parser to use pointers rather than having &lt;tt&gt;Option&lt;/tt&gt; and &lt;tt&gt;OptionSet&lt;/tt&gt; for each URI option. With the way it is now, it&apos;s easy to be inconsistent in code that uses the connection string. For options that default to false but are only useful when set to true (like SSL/SSLInsecure), we often don&apos;t check &lt;tt&gt;*Set&lt;/tt&gt;, which isn&apos;t incorrect, but it is inconsistent.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;Do you mind if I re-purpose this ticket into an improvement for the work I described?&lt;/p&gt;</comment>
                            <comment id="2913657" author="bartle" created="Thu, 27 Feb 2020 07:37:02 +0000"  >&lt;p&gt;SSLInsecureSet is similarly never read.&lt;/p&gt;</comment>
                            <comment id="2913656" author="bartle" created="Thu, 27 Feb 2020 07:34:37 +0000"  >&lt;p&gt;Here too: &lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/blob/a96725e2d7cb39d0c31f7f6605305ad3f92787c1/mongo/options/clientoptions.go#L268&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/blob/a96725e2d7cb39d0c31f7f6605305ad3f92787c1/mongo/options/clientoptions.go#L268&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="1348113">TOOLS-2585</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_14266" key="com.atlassian.jira.plugin.system.customfieldtypes:textarea">
                        <customfieldname>Documentation Changes Summary</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>&lt;p&gt;1.  What would you like to communicate to the user about this feature?&lt;br/&gt;
2.  Would you like the user to see examples of the syntax and/or executable code and its output?&lt;br/&gt;
3.  Which versions of the driver/connector does this apply to?&lt;/p&gt;</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>GODRIVER-1588</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_21553" key="com.atlassian.jira.plugin.system.customfieldtypes:labels">
                        <customfieldname>Quarter</customfieldname>
                        <customfieldvalues>
                                        <label>FY25Q1</label>
    
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr6jqv:s0000yzw4</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>