<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 08:37:59 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[GODRIVER-2179] Replace testutil/assert with testify/assert</title>
                <link>https://jira.mongodb.org/browse/GODRIVER-2179</link>
                <project id="14289" key="GODRIVER">Go Driver</project>
                    <description>&lt;p&gt;The mongo-go-driver tests currently use a mixture of &lt;tt&gt;&quot;go.mongodb.org/mongo-driver/internal/testutil/assert&quot;&lt;/tt&gt;, &lt;tt&gt;&quot;github.com/stretchr/testify/assert&quot;&lt;/tt&gt; to assert things in the tests. Those packages have a similar but slightly different API that is confusing to read/use together. The &lt;tt&gt;&quot;github.com/stretchr/testify/assert&quot;&lt;/tt&gt; package is a more complete API and is a standard assertion API in Go projects, so prefer that package over the internal package.&lt;/p&gt;

&lt;p&gt;Questions:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;Is &lt;tt&gt;&quot;github.com/stretchr/testify/assert&quot;&lt;/tt&gt; the best package or is there another package that has superseded it?&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Definition of done:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;Vendor a useful subset of the &lt;tt&gt;&quot;github.com/stretchr/testify/assert&quot;&lt;/tt&gt; and &lt;tt&gt;&quot;github.com/stretchr/testify/require&quot;&lt;/tt&gt; packages somewhere in an &lt;tt&gt;internal&lt;/tt&gt; package.&lt;/li&gt;
	&lt;li&gt;Replace all uses of the &lt;tt&gt;&quot;go.mongodb.org/mongo-driver/internal/testutil/assert&quot;&lt;/tt&gt; package with the vendored &lt;tt&gt;&quot;github.com/stretchr/testify/assert&quot;&lt;/tt&gt;/&lt;tt&gt;&quot;github.com/stretchr/testify/require&quot;&lt;/tt&gt; APIs.&lt;/li&gt;
	&lt;li&gt;Remove the &lt;tt&gt;testutil/assert&lt;/tt&gt; package.&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="1894761">GODRIVER-2179</key>
            <summary>Replace testutil/assert with testify/assert</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="benji.rewis@mongodb.com">Benji Rewis</assignee>
                                    <reporter username="matt.dale@mongodb.com">Matt Dale</reporter>
                        <labels>
                    </labels>
                <created>Mon, 11 Oct 2021 01:07:58 +0000</created>
                <updated>Tue, 24 Jan 2023 17:10:35 +0000</updated>
                            <resolved>Wed, 30 Nov 2022 22:23:17 +0000</resolved>
                                                    <fixVersion>1.12.0</fixVersion>
                    <fixVersion>1.12.0-alpha1</fixVersion>
                                                        <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="5020451" author="xgen-internal-githook" created="Wed, 30 Nov 2022 22:22:55 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Benjamin Rewis&apos;, &apos;email&apos;: &apos;32186188+benjirewis@users.noreply.github.com&apos;, &apos;username&apos;: &apos;benjirewis&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/GODRIVER-2179&quot; title=&quot;Replace testutil/assert with testify/assert&quot; class=&quot;issue-link&quot; data-issue-key=&quot;GODRIVER-2179&quot;&gt;&lt;del&gt;GODRIVER-2179&lt;/del&gt;&lt;/a&gt; Unify testing API. (#1137)&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Removes the testify dependency.&lt;/li&gt;
	&lt;li&gt;Removes the tidwall/pretty dependency.&lt;/li&gt;
	&lt;li&gt;Modifies the existing internal/assert package to be a copy of a subset of testify/assert and pmezard/go-difflib.&lt;/li&gt;
	&lt;li&gt;Adds a new internal/require package that is a copy of a subset of testify/require.&lt;/li&gt;
	&lt;li&gt;Changes all assert and require imports to refer to internal.&lt;/li&gt;
	&lt;li&gt;Runs go mod tidy and go mod vendor.&lt;/li&gt;
	&lt;li&gt;Fixes tests that relied on old test API behavior.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/commit/977993fa81b76cdd599b59ac763ec85d15dbaa0e&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/commit/977993fa81b76cdd599b59ac763ec85d15dbaa0e&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="4998313" author="benji.rewis" created="Mon, 21 Nov 2022 19:50:02 +0000"  >&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/pull/1137&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/pull/1137&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10020">
                    <name>Gantt Dependency</name>
                                            <outwardlinks description="has to be done before">
                                        <issuelink>
            <issuekey id="2197717">GODRIVER-2667</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>GODRIVER-2100</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_21553" key="com.atlassian.jira.plugin.system.customfieldtypes:labels">
                        <customfieldname>Quarter</customfieldname>
                        <customfieldvalues>
                                        <label>FY23Q4</label>
    
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr6jqv:s00a</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>