<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 08:34:22 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[GODRIVER-508] topology.Server.update leaks time.Tickers</title>
                <link>https://jira.mongodb.org/browse/GODRIVER-508</link>
                <project id="14289" key="GODRIVER">Go Driver</project>
                    <description>&lt;p&gt;The update method sets up two tickers, but does not stop them. This causes a memory leak.&lt;/p&gt;

&lt;p&gt;Found while implementing a prometheus blackbox-style probe. I&apos;ve got a small patch I&apos;ll send as a github PR. Below is my probe running without it for a few hours, then with it.&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://jira.mongodb.org/secure/attachment/192638/192638_image-2018-07-25-18-16-03-809.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</description>
                <environment></environment>
        <key id="576174">GODRIVER-508</key>
            <summary>topology.Server.update leaks time.Tickers</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="kris.brandow@mongodb.com">Kristofer Brandow</assignee>
                                    <reporter username="ranglerud">Rikard Anglerud</reporter>
                        <labels>
                    </labels>
                <created>Wed, 25 Jul 2018 17:34:54 +0000</created>
                <updated>Sat, 28 Oct 2023 11:39:30 +0000</updated>
                            <resolved>Thu, 26 Jul 2018 17:34:36 +0000</resolved>
                                    <version>0.0.9</version>
                                    <fixVersion>0.0.10</fixVersion>
                                    <component>Server Discovery and Monitoring</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="1957682" author="kris.brandow" created="Thu, 26 Jul 2018 17:34:36 +0000"  >&lt;p&gt;Thanks again for the bug report and the pull request!&lt;/p&gt;</comment>
                            <comment id="1957679" author="xgen-internal-githook" created="Thu, 26 Jul 2018 17:34:10 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Rikard Anglerud&apos;, &apos;email&apos;: &apos;Rikard.Anglerud@man.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/GODRIVER-508&quot; title=&quot;topology.Server.update leaks time.Tickers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;GODRIVER-508&quot;&gt;&lt;del&gt;GODRIVER-508&lt;/del&gt;&lt;/a&gt; - call Stop() on heartbeatTicker and rateLimitr&lt;/p&gt;

&lt;p&gt;This should fix a memory leak in topology.Server&apos;s update()&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/commit/06a71c7445d6ee35d0cb66dcc6dba94edf043667&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/commit/06a71c7445d6ee35d0cb66dcc6dba94edf043667&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1956490" author="ranglerud" created="Wed, 25 Jul 2018 17:52:20 +0000"  >&lt;p&gt;Thank you - I&apos;ve submitted &lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/pull/78&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/pull/78&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1956485" author="kris.brandow" created="Wed, 25 Jul 2018 17:44:54 +0000"  >&lt;p&gt;Okay, great. I&apos;ll keep an eye out for the pull request.&lt;/p&gt;</comment>
                            <comment id="1956482" author="ranglerud" created="Wed, 25 Jul 2018 17:42:59 +0000"  >&lt;p&gt;Those are the ones, yep.&lt;/p&gt;</comment>
                            <comment id="1956477" author="kris.brandow" created="Wed, 25 Jul 2018 17:41:32 +0000"  >&lt;p&gt;Hi &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=ranglerud&quot; class=&quot;user-hover&quot; rel=&quot;ranglerud&quot;&gt;ranglerud&lt;/a&gt;,&lt;/p&gt;

&lt;p&gt;Thanks for the bug report. Are these the timers you are referring to?&#160;&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/mongo-go-driver/blob/eecffe0eec1ec89b01fcb17f288d59dfde0ab9e8/core/topology/server.go#L252-L253&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-go-driver/blob/eecffe0eec1ec89b01fcb17f288d59dfde0ab9e8/core/topology/server.go#L252-L253&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;--Kris&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="192638" name="image-2018-07-25-18-16-03-809.png" size="128485" author="ranglerud" created="Wed, 25 Jul 2018 17:16:05 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|htu3ov:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>