<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 08:54:10 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[JAVA-1254] Some helper methods wrapping commands do not call throwOnError on the result</title>
                <link>https://jira.mongodb.org/browse/JAVA-1254</link>
                <project id="10006" key="JAVA">Java Driver</project>
                    <description>&lt;p&gt;From what I gather, the general contract of the &lt;tt&gt;Collection&lt;/tt&gt; and &lt;tt&gt;DB&lt;/tt&gt; API methods is:&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;&lt;tt&gt;DB.command()&lt;/tt&gt; will return a &lt;tt&gt;CommandResult&lt;/tt&gt; to the user who then take responsibility to check &lt;tt&gt;ok()&lt;/tt&gt; or &lt;tt&gt;throwOnError()&lt;/tt&gt; as they wish.&lt;/li&gt;
	&lt;li&gt;The &quot;helper&quot; methods that wrap commands, e.g., &lt;tt&gt;distinct()&lt;/tt&gt; call throwOnError for the user automatically.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;However from what I see there are several &quot;helpers&quot; that do not, making the pattern sort of inconsistent for users. The examples that I was able to find where &lt;tt&gt;throwOnError()&lt;/tt&gt; is not called:&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;&lt;tt&gt;DB.getStats()&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;Mongo.fsync()&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;Mongo.fsyncAndLock()&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;&lt;tt&gt;DBCollection.aggregate()&lt;/tt&gt; returning an AggregationOutput&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="137579">JAVA-1254</key>
            <summary>Some helper methods wrapping commands do not call throwOnError on the result</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="ross@mongodb.com">Ross Lawley</assignee>
                                    <reporter username="john.morales@mongodb.com">John Morales</reporter>
                        <labels>
                    </labels>
                <created>Wed, 21 May 2014 21:13:34 +0000</created>
                <updated>Fri, 1 Apr 2016 21:13:22 +0000</updated>
                            <resolved>Thu, 26 Jun 2014 13:24:17 +0000</resolved>
                                    <version>2.12.0</version>
                                    <fixVersion>2.12.3</fixVersion>
                                    <component>Command Operations</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="678707" author="xgen-internal-githook" created="Fri, 1 Aug 2014 14:37:12 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;rozza&apos;, u&apos;name&apos;: u&apos;Ross Lawley&apos;, u&apos;email&apos;: u&apos;ross.lawley@gmail.com&apos;}
&lt;p&gt;Message: Ensure helpers call throwOnError();&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/JAVA-1254&quot; title=&quot;Some helper methods wrapping commands do not call throwOnError on the result&quot; class=&quot;issue-link&quot; data-issue-key=&quot;JAVA-1254&quot;&gt;&lt;del&gt;JAVA-1254&lt;/del&gt;&lt;/a&gt;&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-java-driver/commit/06e1d91f7bdec4b00c905d63d7083c6470d1e6c1&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-java-driver/commit/06e1d91f7bdec4b00c905d63d7083c6470d1e6c1&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="634715" author="xgen-internal-githook" created="Thu, 26 Jun 2014 11:28:26 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;rozza&apos;, u&apos;name&apos;: u&apos;Ross Lawley&apos;, u&apos;email&apos;: u&apos;ross.lawley@gmail.com&apos;}
&lt;p&gt;Message: Ensure helpers call throwOnError();&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/JAVA-1254&quot; title=&quot;Some helper methods wrapping commands do not call throwOnError on the result&quot; class=&quot;issue-link&quot; data-issue-key=&quot;JAVA-1254&quot;&gt;&lt;del&gt;JAVA-1254&lt;/del&gt;&lt;/a&gt;&lt;br/&gt;
Branch: 2.12.x&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-java-driver/commit/06e1d91f7bdec4b00c905d63d7083c6470d1e6c1&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-java-driver/commit/06e1d91f7bdec4b00c905d63d7083c6470d1e6c1&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="633614" author="ross@10gen.com" created="Wed, 25 Jun 2014 12:09:41 +0000"  >&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/mongo-java-driver/pull/221&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-java-driver/pull/221&lt;/a&gt;&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo-java-driver/pull/222&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo-java-driver/pull/222&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hrg9gf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8437</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="202">Sprint 4 - June 16 - July 3</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            </customfields>
    </item>
</channel>
</rss>