<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 09:08:14 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[MONGOCRYPT-218] Wrap tls specific files if ifdefs</title>
                <link>https://jira.mongodb.org/browse/MONGOCRYPT-218</link>
                <project id="17481" key="MONGOCRYPT">Libmongocrypt</project>
                    <description>&lt;p&gt;As a convenience for bundling (and the libmongocrypt build itself), wrap the TLS C files with ifdefs so they&apos;re safe to compile regardless of the TLS library used.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1047724">MONGOCRYPT-218</key>
            <summary>Wrap tls specific files if ifdefs</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="5" iconUrl="https://jira.mongodb.org/images/icons/priorities/trivial.svg">Trivial - P5</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="kevin.albertson@mongodb.com">Kevin Albertson</assignee>
                                    <reporter username="kevin.albertson@mongodb.com">Kevin Albertson</reporter>
                        <labels>
                    </labels>
                <created>Wed, 11 Dec 2019 04:31:09 +0000</created>
                <updated>Sat, 28 Oct 2023 10:25:24 +0000</updated>
                            <resolved>Fri, 13 Dec 2019 03:24:31 +0000</resolved>
                                                    <fixVersion>1.0.1</fixVersion>
                                    <component>C library</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="2657594" author="jmikola@gmail.com" created="Fri, 20 Dec 2019 15:37:35 +0000"  >&lt;p&gt;Thanks for confirming. We removed them in the latest PHP PR.&lt;/p&gt;</comment>
                            <comment id="2657225" author="kevin.albertson" created="Fri, 20 Dec 2019 14:13:21 +0000"  >&lt;p&gt;Yes, _WIN32 should be defined by MSVC. libbson also relies on it being defined in order to use Windows specific headers an APIs: (&lt;a href=&quot;https://github.com/mongodb/mongo-c-driver/blob/1.15.0/src/libbson/examples/bson-streaming-reader.c/#L21&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;example&lt;/a&gt;).&lt;/p&gt;

&lt;p&gt;I found no references to MONGOCRYPT_IS_POSIX or MONGOCRYPT_IS_WIN in libmongocrypt or the history (using &quot;git log -p -S MONGOCRYPT_IS_POSIX&quot;).&lt;/p&gt;</comment>
                            <comment id="2653755" author="jmikola@gmail.com" created="Fri, 20 Dec 2019 00:07:06 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=kevin.albertson&quot; class=&quot;user-hover&quot; rel=&quot;kevin.albertson&quot;&gt;kevin.albertson&lt;/a&gt;: I noticed that &lt;a href=&quot;https://github.com/mongodb/libmongocrypt/commit/26268640810361f5205730c42c5ca41287a50912&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;2626864&lt;/a&gt; also removed conditional compilation of the POSIX and WIN32 source files. They now depend on &lt;tt&gt;_WIN32&lt;/tt&gt; being defined. Am I correct to assume we can just rely on the Windows compiler to set this for us? I don&apos;t see anything in CMakeLists.txt that suggests we need to define it ourselves.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=andreas.braun&quot; class=&quot;user-hover&quot; rel=&quot;andreas.braun&quot;&gt;andreas.braun&lt;/a&gt;&apos;s PR for &lt;a href=&quot;https://jira.mongodb.org/browse/PHPC-1496&quot; title=&quot;Support compiling with libmongocrypt&quot; class=&quot;issue-link&quot; data-issue-key=&quot;PHPC-1496&quot;&gt;&lt;del&gt;PHPC-1496&lt;/del&gt;&lt;/a&gt; makes substitutions for &lt;tt&gt;MONGOCRYPT_IS_POSIX&lt;/tt&gt; and &lt;tt&gt;MONGOCRYPT_IS_WIN&lt;/tt&gt;. Do those date back to an earlier version of libmongocrypt? If so, can you point out when they were removed?&lt;/p&gt;</comment>
                            <comment id="2603923" author="xgen-internal-githook" created="Fri, 13 Dec 2019 03:23:11 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Kevin Albertson&apos;, &apos;email&apos;: &apos;kevin.albertson@mongodb.com&apos;, &apos;username&apos;: &apos;kevinAlbs&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-218&quot; title=&quot;Wrap tls specific files if ifdefs&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-218&quot;&gt;&lt;del&gt;MONGOCRYPT-218&lt;/del&gt;&lt;/a&gt; wrap TLS code with ifdefs&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/libmongocrypt/commit/26268640810361f5205730c42c5ca41287a50912&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/libmongocrypt/commit/26268640810361f5205730c42c5ca41287a50912&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="1047846">PHPC-1509</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                            <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hvy8fj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>