<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 09:07:50 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[MONGOCRYPT-49] libmongocrypt: revisit error vs. abort on misuse</title>
                <link>https://jira.mongodb.org/browse/MONGOCRYPT-49</link>
                <project id="17481" key="MONGOCRYPT">Libmongocrypt</project>
                    <description>&lt;p&gt;Decide how to fail when drivers call into the wrong state machine methods:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;BSON_ASSERT and crash?&lt;/li&gt;
	&lt;li&gt;do nothing, and continue to report the same state until they call the correct state machine method?&lt;/li&gt;
	&lt;li&gt;transition to the ERROR state ?&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="707543">MONGOCRYPT-49</key>
            <summary>libmongocrypt: revisit error vs. abort on misuse</summary>
                <type id="2" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14711&amp;avatarType=issuetype">New Feature</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="samantha.ritter@mongodb.com">Samantha Ritter</assignee>
                                    <reporter username="samantha.ritter@mongodb.com">Samantha Ritter</reporter>
                        <labels>
                    </labels>
                <created>Fri, 1 Mar 2019 19:49:39 +0000</created>
                <updated>Sat, 28 Oct 2023 10:25:52 +0000</updated>
                            <resolved>Mon, 3 Jun 2019 14:24:14 +0000</resolved>
                                                                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="2268534" author="xgen-internal-githook" created="Mon, 3 Jun 2019 14:22:59 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;samantharitter&apos;, &apos;email&apos;: &apos;samantha.ritter@10gen.com&apos;, &apos;username&apos;: &apos;samantharitter&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-49&quot; title=&quot;libmongocrypt: revisit error vs. abort on misuse&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-49&quot;&gt;&lt;del&gt;CDRIVER-2988&lt;/del&gt;&lt;/a&gt; replace asserts with returned errors&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/10gen/libmongocrypt/commit/c6ad036738f5b67fafbd637b8e9bc5d536c0a6a1&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/10gen/libmongocrypt/commit/c6ad036738f5b67fafbd637b8e9bc5d536c0a6a1&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2193936" author="kevin.albertson" created="Thu, 28 Mar 2019 00:59:49 +0000"  >&lt;p&gt;From collected experiences PoC&apos;ing libmongocrypt in the Node and Java drivers, I&apos;m convinced we should error where possible instead of asserting. Even simple cases like accidentally passing NULL as an argument when you shouldn&apos;t. It just makes the process of integrating the library and debugging easier. And one of the primary goals of libmongocrypt is to make FLE easy to implement in drivers.&lt;/p&gt;

&lt;p&gt;Also a couple noteworthy cases we should error (and not abort):&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;reinitializing a mongocrypt_ctx_t&lt;/li&gt;
	&lt;li&gt;omitting necessary calls to mongocrypt_ctx_mongo_done&lt;/li&gt;
	&lt;li&gt;bad option values in mongocrypt_init&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="2175703" author="kevin.albertson" created="Fri, 8 Mar 2019 14:44:33 +0000"  >&lt;p&gt;If we decide to go with return an error instead of aborting in all cases, let&apos;s update errors in kms-message that abort too (e.g. kms_request_str_appendf). That may be a separate ticket.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                            <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>CDRIVER-2915</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|htw41z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>