<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 09:08:59 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[MONGOCRYPT-570] Do not apply default to min/max values for int/long/date</title>
                <link>https://jira.mongodb.org/browse/MONGOCRYPT-570</link>
                <project id="17481" key="MONGOCRYPT">Libmongocrypt</project>
                    <description>&lt;h1&gt;&lt;a name=&quot;Scope&quot;&gt;&lt;/a&gt;Scope&lt;/h1&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Do not apply default to &lt;tt&gt;min/max&lt;/tt&gt; values for explicit encryption with &lt;tt&gt;int/long/date&lt;/tt&gt;.&lt;/li&gt;
	&lt;li&gt;Return an error if explicit encryption is attempted on &lt;tt&gt;int/long/date&lt;/tt&gt; without &lt;tt&gt;min&lt;/tt&gt; or &lt;tt&gt;max&lt;/tt&gt; set.&lt;/li&gt;
&lt;/ul&gt;


&lt;h1&gt;&lt;a name=&quot;Background%26Motivation&quot;&gt;&lt;/a&gt;Background &amp;amp; Motivation&lt;/h1&gt;

&lt;p&gt;libmongocrypt &lt;a href=&quot;https://github.com/mongodb/libmongocrypt/blob/9fcd2642183a3adcbf0da7c03bf5142ca1f2fdb1/src/mc-rangeopts.c#L248-L262&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;applies a default min/max&lt;/a&gt; to &lt;tt&gt;int/long/date&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;Requiring &lt;tt&gt;min/max&lt;/tt&gt; for &lt;tt&gt;int/long/date&lt;/tt&gt; matches the server behavior: &lt;a href=&quot;https://github.com/mongodb/mongo/blob/ce9ae383244dc01c8961e3052ca9f48a0008c80d/src/mongo/crypto/encryption_fields_validation.cpp#L147-L155&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/ce9ae383244dc01c8961e3052ca9f48a0008c80d/src/mongo/crypto/encryption_fields_validation.cpp#L147-L155&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Not requiring a &lt;tt&gt;min/max&lt;/tt&gt; may be a convenience to users. But, requiring the values may reduce risk of users unintentionally omitting &lt;tt&gt;min&lt;/tt&gt; or &lt;tt&gt;max&lt;/tt&gt;. Encrypting with an incorrect &lt;tt&gt;min&lt;/tt&gt; or &lt;tt&gt;max&lt;/tt&gt; may result in incorrect query results. Adding a default value to &lt;tt&gt;min&lt;/tt&gt; and &lt;tt&gt;max&lt;/tt&gt; can be considered in the future without making a backwards breaking change.&lt;/p&gt;</description>
                <environment></environment>
        <key id="2312718">MONGOCRYPT-570</key>
            <summary>Do not apply default to min/max values for int/long/date</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="10300" iconUrl="https://jira.mongodb.org/images/icons/priorities/medium.svg">Unknown</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="kevin.albertson@mongodb.com">Kevin Albertson</assignee>
                                    <reporter username="kevin.albertson@mongodb.com">Kevin Albertson</reporter>
                        <labels>
                    </labels>
                <created>Wed, 12 Apr 2023 14:11:58 +0000</created>
                <updated>Sat, 28 Oct 2023 10:25:59 +0000</updated>
                            <resolved>Mon, 24 Apr 2023 14:05:35 +0000</resolved>
                                                    <fixVersion>1.8.0</fixVersion>
                    <fixVersion>1.8.0-alpha1</fixVersion>
                                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="5370432" author="xgen-internal-githook" created="Mon, 24 Apr 2023 14:05:25 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Kevin Albertson&apos;, &apos;email&apos;: &apos;kevin.albertson@mongodb.com&apos;, &apos;username&apos;: &apos;kevinAlbs&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-570&quot; title=&quot;Do not apply default to min/max values for int/long/date&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-570&quot;&gt;&lt;del&gt;MONGOCRYPT-570&lt;/del&gt;&lt;/a&gt; require `min` and `max` for `int`, `long`, and `date` (#624)&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;test min and max are required for int type&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;require min and max for int, long, and date&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;remove int32 nominmax tests&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;They were incorrectly testing double.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/libmongocrypt/commit/9f51624d658840991877543076676f8fc427a85b&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/libmongocrypt/commit/9f51624d658840991877543076676f8fc427a85b&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5370431" author="mms-build@10gen.com" created="Mon, 24 Apr 2023 14:05:24 +0000"  >&lt;p&gt; &lt;a href=&quot;https://github.com/kevinAlbs&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;kevinAlbs&lt;/a&gt; merged a pull request (&lt;a href=&quot;https://github.com/mongodb/libmongocrypt/pull/624&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;MONGOCRYPT-570 require `min` and `max` for `int`  `long`  and `date`&lt;/a&gt;) into the following branch:&lt;br/&gt;
                       master: &lt;a href=&quot;https://github.com/kevinAlbs/libmongocrypt/commit/9f51624d658840991877543076676f8fc427a85b&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;9f51624d658840991877543076676f8fc427a85b&lt;/a&gt;&lt;/p&gt;
</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                <customfield id="customfield_21957" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Binding Changes</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="22966"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i1mp4g:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>