<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 09:09:02 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[MONGOCRYPT-587] Build with warnings and treat them as errors</title>
                <link>https://jira.mongodb.org/browse/MONGOCRYPT-587</link>
                <project id="17481" key="MONGOCRYPT">Libmongocrypt</project>
                    <description>&lt;p&gt;While working on &lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-512&quot; title=&quot;libmongocrypt has warnings with -Wsign-compare&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-512&quot;&gt;&lt;del&gt;MONGOCRYPT-512&lt;/del&gt;&lt;/a&gt; it became evident that it would be very helpful to have &lt;tt&gt;-Wall -Werror&lt;/tt&gt; as default compile options in Evergreen builds. It seems that this was done once before (&lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-103&quot; title=&quot;Build with warnings and treat them as errors&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-103&quot;&gt;&lt;del&gt;MONGOCRYPT-103&lt;/del&gt;&lt;/a&gt;, commit 05bb025ffae269fe47d41e81636d98b438daf4c8) but that somehow it was changed and we no longer have this.&lt;/p&gt;

&lt;p&gt;Note that as part of &lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-512&quot; title=&quot;libmongocrypt has warnings with -Wsign-compare&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-512&quot;&gt;&lt;del&gt;MONGOCRYPT-512&lt;/del&gt;&lt;/a&gt; it was necessary to prune &lt;tt&gt;-Werror&lt;/tt&gt; from the compiler flags before including the embedded C driver in the build. The same seems likely to be necessary for DFP when &lt;tt&gt;-Wall&lt;/tt&gt; is added.&lt;/p&gt;</description>
                <environment></environment>
        <key id="2423798">MONGOCRYPT-587</key>
            <summary>Build with warnings and treat them as errors</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="10300" iconUrl="https://jira.mongodb.org/images/icons/priorities/medium.svg">Unknown</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="roberto.sanchez@mongodb.com">Roberto Sanchez</assignee>
                                    <reporter username="roberto.sanchez@mongodb.com">Roberto Sanchez</reporter>
                        <labels>
                    </labels>
                <created>Tue, 22 Aug 2023 21:12:04 +0000</created>
                <updated>Sat, 28 Oct 2023 10:26:01 +0000</updated>
                            <resolved>Sat, 9 Sep 2023 00:21:15 +0000</resolved>
                                                    <fixVersion>1.9.0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="5687853" author="xgen-internal-githook" created="Thu, 7 Sep 2023 19:35:41 +0000"  >&lt;p&gt;Author: &lt;/p&gt;
{&apos;name&apos;: &apos;Roberto C. S&#225;nchez&apos;, &apos;email&apos;: &apos;roberto@connexer.com&apos;, &apos;username&apos;: &apos;rcsanchez97&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-587&quot; title=&quot;Build with warnings and treat them as errors&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-587&quot;&gt;&lt;del&gt;MONGOCRYPT-587&lt;/del&gt;&lt;/a&gt; compiler warnings (#691)&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/MONGOCRYPT-587&quot; title=&quot;Build with warnings and treat them as errors&quot; class=&quot;issue-link&quot; data-issue-key=&quot;MONGOCRYPT-587&quot;&gt;&lt;del&gt;MONGOCRYPT-587&lt;/del&gt;&lt;/a&gt; include -Wsign-compare when &quot;more warnings&quot; are enabled&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;fix compiler warnings: -Wformat-truncation&lt;/li&gt;
&lt;/ul&gt;


&lt;ul&gt;
	&lt;li&gt;fix compiler warnings: -Wsign-compare&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/libmongocrypt/commit/da4834dfbdd635bb250cdbf78e22e4de5905b717&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/libmongocrypt/commit/da4834dfbdd635bb250cdbf78e22e4de5905b717&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="5687852" author="mms-build@10gen.com" created="Thu, 7 Sep 2023 19:35:41 +0000"  >&lt;p&gt; &lt;a href=&quot;https://github.com/rcsanchez97&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;rcsanchez97&lt;/a&gt; merged a pull request (&lt;a href=&quot;https://github.com/mongodb/libmongocrypt/pull/691&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;MONGOCRYPT-587 compiler warnings&lt;/a&gt;) into the following branch:&lt;br/&gt;
                       master: &lt;a href=&quot;https://github.com/rcsanchez97/libmongocrypt/commit/da4834dfbdd635bb250cdbf78e22e4de5905b717&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;da4834dfbdd635bb250cdbf78e22e4de5905b717&lt;/a&gt;&lt;/p&gt;
</comment>
                            <comment id="5673721" author="roberto.sanchez" created="Fri, 1 Sep 2023 01:16:00 +0000"  >&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/libmongocrypt/pull/691&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/libmongocrypt/pull/691&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="5673493" author="roberto.sanchez" created="Thu, 31 Aug 2023 22:53:37 +0000"  >&lt;p&gt;My initial assessment (as recorded in the ticket description) was incorrect. The implementation of the CMake option &lt;tt&gt;ENABLE_MORE_WARNINGS_AS_ERRORS&lt;/tt&gt; in libmongocrypt ensures that &lt;tt&gt;-Wall -Werror&lt;/tt&gt; are added to the compiler invocations when that option is set, which it is for all of our Evergreen builds. The issue is that, according to the &lt;a href=&quot;https://gcc.gnu.org/onlinedocs/gcc-10.5.0/gcc/Warning-Options.html&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;gcc documentation&lt;/a&gt;, the list of warnings enabled by &lt;tt&gt;-Wall&lt;/tt&gt;, does not include &lt;tt&gt;-Wsign-compare&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;So, it seems that the issue is really whether we want to include &lt;tt&gt;-Wsign-compare&lt;/tt&gt; in addition to &lt;tt&gt;-Wall -Werror&lt;/tt&gt; when the option &lt;tt&gt;ENABLE_MORE_WARNINGS_AS_ERRORS&lt;/tt&gt; is set. This seems like a good thing to have.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                                                                                                                                            <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|i25fcg:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>