<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:10:45 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-25966] Add initial sync unittests for metadata retries</title>
                <link>https://jira.mongodb.org/browse/SERVER-25966</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Write tests that send failed responses and then successful responses for the following commands, checking that retries lead to a successful result:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;listIndexes&lt;/li&gt;
	&lt;li&gt;find on a collection during a collection clone&lt;/li&gt;
	&lt;li&gt;sync source selection&lt;/li&gt;
	&lt;li&gt;find on the oplog when querying the upstream node for the last oplog entry&lt;/li&gt;
	&lt;li&gt;listDatabases&lt;/li&gt;
	&lt;li&gt;listCollections&lt;/li&gt;
&lt;/ol&gt;


&lt;p&gt;Write tests for the OplogFetcher to ensure it retries and does not cause initial sync to fail on retryable errors&lt;/p&gt;

&lt;p&gt;Write tests for the DataReplicator to test that larger errors lead to a restart of initial sync:&lt;/p&gt;
&lt;ol&gt;
	&lt;li&gt;Rollback&lt;/li&gt;
	&lt;li&gt;Sync source changes&lt;/li&gt;
	&lt;li&gt;Retry exhaust on any of the above retryable errors&lt;/li&gt;
&lt;/ol&gt;
</description>
                <environment></environment>
        <key id="314250">SERVER-25966</key>
            <summary>Add initial sync unittests for metadata retries</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="benety.goh@mongodb.com">Benety Goh</assignee>
                                    <reporter username="judah.schvimer@mongodb.com">Judah Schvimer</reporter>
                        <labels>
                    </labels>
                <created>Tue, 6 Sep 2016 14:54:50 +0000</created>
                <updated>Wed, 5 Apr 2017 11:42:24 +0000</updated>
                            <resolved>Thu, 29 Dec 2016 16:52:48 +0000</resolved>
                                                    <fixVersion>3.5.2</fixVersion>
                                    <component>Replication</component>
                                        <votes>0</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="1466533" author="xgen-internal-githook" created="Thu, 29 Dec 2016 16:52:22 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;benety&apos;, u&apos;name&apos;: u&apos;Benety Goh&apos;, u&apos;email&apos;: u&apos;benety@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-25966&quot; title=&quot;Add initial sync unittests for metadata retries&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-25966&quot;&gt;&lt;del&gt;SERVER-25966&lt;/del&gt;&lt;/a&gt; added CollectionCloner tests for metadata retries&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/03510b1b55475fbbd8c710c70511c6397ca846e9&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/03510b1b55475fbbd8c710c70511c6397ca846e9&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1465561" author="benety.goh" created="Tue, 27 Dec 2016 20:02:47 +0000"  >&lt;p&gt;See this commit for the metadata retry changes:&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://github.com/mongodb/mongo/commit/eba32f352cffd1dbe8ca451bde5944b997bfebf5&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/eba32f352cffd1dbe8ca451bde5944b997bfebf5&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1440482" author="judah.schvimer" created="Tue, 22 Nov 2016 20:26:34 +0000"  >&lt;p&gt;I think that sync source change testing can be done in unittests. We will revisit this after &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-27052&quot; title=&quot;Add asynchronous operation support to DataReplicator&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-27052&quot;&gt;&lt;del&gt;SERVER-27052&lt;/del&gt;&lt;/a&gt; (DataReplicator refactor) is complete.&lt;/p&gt;</comment>
                            <comment id="1440457" author="robert.guo" created="Tue, 22 Nov 2016 19:59:13 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=judah.schvimer&quot; class=&quot;user-hover&quot; rel=&quot;judah.schvimer&quot;&gt;judah.schvimer&lt;/a&gt; Giving this back to you for another look. I think this ticket can be closed given that we have testing of most things in the description (see my comment above for detail). &lt;/p&gt;

&lt;p&gt;The only thing missing is sync source change causing initial sync to restart, which I believe can be more easily tested from JavaScript, possibly using the &lt;tt&gt;replSetSyncFrom&lt;/tt&gt; command. &lt;/p&gt;</comment>
                            <comment id="1435554" author="robert.guo" created="Wed, 16 Nov 2016 14:37:33 +0000"  >&lt;p&gt;I was able to find existing unit tests for almost all of these scenarios. &lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Retries of various commands are handled by &lt;tt&gt;RemoteCommandRetryScheduler&lt;/tt&gt; and tested in &lt;tt&gt;SchedulerShouldRetryUntilSuccessfulResponseIsReceived&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;OplogFetcher retry is tested in &lt;tt&gt;OplogFetcherResetsRestartCounterOnSuccessfulFetcherResponse&lt;/tt&gt; and &lt;tt&gt;OplogFetcherAbortsWithOriginalResponseErrorOnFailureToScheduleNewFetcher&lt;/tt&gt;&lt;/li&gt;
	&lt;li&gt;Rollback is tested in &lt;tt&gt;FailOnRollback&lt;/tt&gt;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;Retries are handled internally by RemoteCommandRetryScheduler, so there&apos;s no need to do additional testing of successful retries of individual commands. Failure after exhausting retries should be handled the same way by be bubbling up the failure to the caller of &lt;tt&gt;doInitialSync&lt;/tt&gt;. I did a sanity check by failing each of the above commands (logs are attached to this ticket). In all cases, the failures correctly trigger an &lt;tt&gt;fassert&lt;/tt&gt; on the initial sync node as expected without side-effects.&lt;/p&gt;

&lt;p&gt;sync source selection has different logic to the other commands and could benefit from additional testing.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="310402">SERVER-25702</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="280008">SERVER-23750</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="312817">SERVER-25874</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="332102">SERVER-27052</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="144282" name="initial_sync_retry_exhaust.log" size="73195" author="robert.guo@mongodb.com" created="Wed, 16 Nov 2016 14:38:18 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>4.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 16 Nov 2016 14:37:33 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        7 years, 6 weeks, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_14262" key="com.atlassian.jira.plugin.system.customfieldtypes:datepicker">
                        <customfieldname>End date</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 29 Dec 2016 23:59:59 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-248</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ramon.fernandez@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            7 years, 6 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>benety.goh@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>judah.schvimer@mongodb.com</customfieldvalue>
            <customfieldvalue>robert.guo@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hrjwzb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hrbmm7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="1232">Repl 2016-10-10</customfieldvalue>
    <customfieldvalue id="1305">TIG 2016-11-21</customfieldvalue>
    <customfieldvalue id="1311">Repl 2016-12-12</customfieldvalue>
    <customfieldvalue id="1450">Repl 2017-02-13</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_14261" key="com.atlassian.jira.plugin.system.customfieldtypes:datepicker">
                        <customfieldname>Start date</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 6 Sep 2016 00:00:00 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11861" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>User Summary</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="11856"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hsekxb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>