<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:12:24 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-26523] Replace raise errors.TestFailure with raise errors.ServerFailure in passthrough hooks where appropriate</title>
                <link>https://jira.mongodb.org/browse/SERVER-26523</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;None of the current hooks raise errors.ServerFailure when nodes die. Raising errors.ServerFailure rather than errors.TestFailure makes it so the test does not continue on failure. For failures, such as failed teardown, that make further tests worthless, we should raise errors.ServerFailure.&lt;/p&gt;</description>
                <environment></environment>
        <key id="322110">SERVER-26523</key>
            <summary>Replace raise errors.TestFailure with raise errors.ServerFailure in passthrough hooks where appropriate</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="robert.guo@mongodb.com">Robert Guo</assignee>
                                    <reporter username="judah.schvimer@mongodb.com">Judah Schvimer</reporter>
                        <labels>
                            <label>tig-resmoke</label>
                    </labels>
                <created>Fri, 7 Oct 2016 18:22:33 +0000</created>
                <updated>Tue, 20 Jun 2017 16:55:57 +0000</updated>
                            <resolved>Thu, 8 Dec 2016 22:06:39 +0000</resolved>
                                                    <fixVersion>3.4.3</fixVersion>
                    <fixVersion>3.5.1</fixVersion>
                                    <component>Testing Infrastructure</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="1516639" author="xgen-internal-githook" created="Mon, 6 Mar 2017 15:12:01 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;guoyr&apos;, u&apos;name&apos;: u&apos;Robert Guo&apos;, u&apos;email&apos;: u&apos;robert.guo@10gen.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-26523&quot; title=&quot;Replace raise errors.TestFailure with raise errors.ServerFailure in passthrough hooks where appropriate&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-26523&quot;&gt;&lt;del&gt;SERVER-26523&lt;/del&gt;&lt;/a&gt; mark resmoke teardown failures as ServerFailures&lt;/p&gt;

&lt;p&gt;(cherry picked from commit e8a3a9266c08bdee7c8772e362cf2b7acd7dab38)&lt;br/&gt;
Branch: v3.4&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/1d7d8cc6aa70526939b3050e542d48b68d87b797&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/1d7d8cc6aa70526939b3050e542d48b68d87b797&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1452838" author="xgen-internal-githook" created="Thu, 8 Dec 2016 22:06:18 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;username&apos;: u&apos;guoyr&apos;, u&apos;name&apos;: u&apos;Robert Guo&apos;, u&apos;email&apos;: u&apos;robert.guo@10gen.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-26523&quot; title=&quot;Replace raise errors.TestFailure with raise errors.ServerFailure in passthrough hooks where appropriate&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-26523&quot;&gt;&lt;del&gt;SERVER-26523&lt;/del&gt;&lt;/a&gt; mark resmoke teardown failures as ServerFailures&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/e8a3a9266c08bdee7c8772e362cf2b7acd7dab38&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/e8a3a9266c08bdee7c8772e362cf2b7acd7dab38&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1451513" author="judah.schvimer" created="Wed, 7 Dec 2016 18:12:50 +0000"  >&lt;p&gt;I do not have a specific failure in mind. I think I agree with Max on this one. While it may reduce the total number of tests we run, it will likely reduce confusion.&lt;/p&gt;</comment>
                            <comment id="1451508" author="max.hirschhorn@10gen.com" created="Wed, 7 Dec 2016 18:09:23 +0000"  >&lt;blockquote&gt;
&lt;p&gt;I think the reason teardown failures are marked as TestFailures is that they shouldn&apos;t prevent additional tests from running. If the fixture crashed during teardown, it should still be able to restart afterwards&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;Once we&apos;ve identified a crashing bug in the server and/or a memory leak via ASan/LSan, I don&apos;t think there&apos;s value in continuing to run tests though.&lt;/p&gt;</comment>
                            <comment id="1451501" author="robert.guo" created="Wed, 7 Dec 2016 18:05:36 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=judah.schvimer&quot; class=&quot;user-hover&quot; rel=&quot;judah.schvimer&quot;&gt;judah.schvimer&lt;/a&gt;, I went through all the places where we raise TestFailures in &lt;tt&gt;hooks.py&lt;/tt&gt;. All but the teardown ones are the result of failing to run a command or JS file.&lt;/p&gt;

&lt;p&gt;I think the reason teardown failures are marked as TestFailures is that they shouldn&apos;t prevent additional tests from running. If the fixture crashed during teardown, it should still be able to restart afterwards. If the teardown failed, the fixture should still have been running, meaning the restart had no effect. If the fixture hung, it should be caught by a test timing out.&lt;/p&gt;

&lt;p&gt;I can see a use-case for marking the initial sync node&apos;s failed teardown as a ServerFailure, but I&apos;m not sure if it&apos;d necessarily better than what we currently have. Do you remember if there was a specific failure you had in mind when filing this ticket?&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="14340"><![CDATA[v3.4]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 7 Dec 2016 18:05:36 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        6 years, 49 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-844</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>max.hirschhorn@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            6 years, 49 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>judah.schvimer@mongodb.com</customfieldvalue>
            <customfieldvalue>max.hirschhorn@mongodb.com</customfieldvalue>
            <customfieldvalue>robert.guo@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hrjtxj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hsqlxz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="1306">TIG 2016-12-12</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hseh07:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>