<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:25:11 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-30838] Remove &quot;_inlock&quot; function name usage</title>
                <link>https://jira.mongodb.org/browse/SERVER-30838</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;The server has 1228 mentions of &quot;&lt;tt&gt;_inlock&lt;/tt&gt;&quot; functions in 133 files, including declarations, calls, and comments.  These mentions should be transitioned to take/pass a &lt;tt&gt;mongo::WithLock&lt;/tt&gt; argument, instead, as defined in &lt;tt&gt;util/concurrency/with_lock.h&lt;/tt&gt;, to improve static error detection.&lt;/p&gt;

&lt;p&gt;Adoption can be incremental, per function, per file, or per subsystem.  Because usage of the &quot;&lt;tt&gt;*_inlock&lt;/tt&gt;&quot; naming convention is primarily confined to private member functions, uses of any particular such name are confined to a few files, most commonly two.&lt;/p&gt;

&lt;p&gt;In any case, no new &quot;&lt;tt&gt;_inlock&lt;/tt&gt;&quot; functions should be created.&lt;/p&gt;</description>
                <environment></environment>
        <key id="420413">SERVER-30838</key>
            <summary>Remove &quot;_inlock&quot; function name usage</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="2">Won&apos;t Fix</resolution>
                                        <assignee username="backlog-server-platform">DO NOT USE - Backlog - Platform Team</assignee>
                                    <reporter username="nathan.myers">Nathan Myers</reporter>
                        <labels>
                    </labels>
                <created>Fri, 25 Aug 2017 18:09:20 +0000</created>
                <updated>Tue, 23 Jul 2019 17:17:29 +0000</updated>
                            <resolved>Tue, 23 Jul 2019 17:17:29 +0000</resolved>
                                                                    <component>Concurrency</component>
                    <component>Querying</component>
                    <component>Replication</component>
                    <component>Sharding</component>
                                        <votes>0</votes>
                                    <watches>8</watches>
                                                                                                                <comments>
                            <comment id="1681304" author="nathan.myers" created="Mon, 25 Sep 2017 20:18:56 +0000"  >&lt;p&gt;push d7aca6435e8 above does everything under mongo/s/.  Everything under db/s was done by the original patch for &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-30748&quot; title=&quot;Alternative to &amp;#39;_inlock&amp;#39; function naming&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-30748&quot;&gt;&lt;del&gt;SERVER-30748&lt;/del&gt;&lt;/a&gt; (push 529d5de7)&lt;/p&gt;</comment>
                            <comment id="1681288" author="xgen-internal-githook" created="Mon, 25 Sep 2017 20:11:08 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;email&apos;: &apos;nathan.myers@10gen.com&apos;, &apos;name&apos;: &apos;Nathan Myers&apos;, &apos;username&apos;: &apos;nathan-myers-mongo&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-30838&quot; title=&quot;Remove &amp;quot;_inlock&amp;quot; function name usage&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-30838&quot;&gt;&lt;del&gt;SERVER-30838&lt;/del&gt;&lt;/a&gt; Remove _inlock names in sharding subsystem&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/d7aca6435e8ccc89005a97dc585dfbe429a17dec&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/d7aca6435e8ccc89005a97dc585dfbe429a17dec&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1657566" author="milkie" created="Fri, 25 Aug 2017 19:54:05 +0000"  >&lt;p&gt;There could very well be, but I am not personally aware of it.&lt;/p&gt;</comment>
                            <comment id="1657542" author="nathan.myers" created="Fri, 25 Aug 2017 19:38:26 +0000"  >&lt;p&gt;I didn&apos;t see a way for preventing new uses to be a work item, beyond posting an announcement somewhere for the information of code reviewers.  Is there a way to instrument lint to do that?&lt;/p&gt;</comment>
                            <comment id="1657491" author="milkie" created="Fri, 25 Aug 2017 19:00:05 +0000"  >&lt;p&gt;It sounds like there are two separate work items suggested by the description of this ticket: remove all current uses of _inlock, and prevent new uses of _inlock.  Should these be separate tickets?&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                                        </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="418062">SERVER-30748</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 25 Aug 2017 19:00:05 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        6 years, 20 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>spencer.jackson@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            6 years, 20 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>backlog-server-platform</customfieldvalue>
            <customfieldvalue>milkie@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>nathan.myers</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|htdnun:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr9hr3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|htd9xj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>