<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 03:02:38 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-3285] Dead Assignment/Variable added in commit 884e100 (also a NULL dereference bug)</title>
                <link>https://jira.mongodb.org/browse/SERVER-3285</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Hi,&lt;/p&gt;

&lt;p&gt;We are using Sentry (a C/C++ static analysis tool) to analyze&lt;br/&gt;
mongodb on a nightly basis. Sentry found that a dead assignment&lt;br/&gt;
was recently introduced in the commit 884e100.&lt;/p&gt;

&lt;p&gt;While reviewing that issue, I also noticed a potential NULL&lt;br/&gt;
dereference that Sentry found.&lt;/p&gt;

&lt;p&gt;I&apos;ve provided a patch for each issue.&lt;/p&gt;

&lt;p&gt;I can see from the code that the dead assignment was at one point a&lt;br/&gt;
debugging variable. However, the assert was commented out, and thought&lt;br/&gt;
it might be nice to clean up the code. If this isn&apos;t the case, please disregard this patch.&lt;/p&gt;

&lt;p&gt;The NULL dereference could be a potentially serious bug if targetHost can be NULL&lt;br/&gt;
when entering the function.&lt;/p&gt;

&lt;p&gt;I&apos;m not sure either of these patches are the correct patch considering I don&apos;t know&lt;br/&gt;
the code that well, hopefully you can investigate.&lt;/p&gt;

&lt;p&gt;Thanks,&lt;br/&gt;
Chris&lt;/p&gt;

&lt;p&gt;&amp;#8211; &lt;br/&gt;
Chris Wilson&lt;br/&gt;
&lt;a href=&quot;http://vigilantsw.com/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://vigilantsw.com/&lt;/a&gt;&lt;br/&gt;
Vigilant Software, A C/C++ Static Analysis Company&lt;/p&gt;</description>
                <environment></environment>
        <key id="18412">SERVER-3285</key>
            <summary>Dead Assignment/Variable added in commit 884e100 (also a NULL dereference bug)</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="kristina">Kristina Chodorow</assignee>
                                    <reporter username="cwilson">Chris Wilson</reporter>
                        <labels>
                    </labels>
                <created>Fri, 17 Jun 2011 17:35:06 +0000</created>
                <updated>Tue, 12 Jul 2016 00:17:03 +0000</updated>
                            <resolved>Thu, 23 Jun 2011 21:52:52 +0000</resolved>
                                                    <fixVersion>1.9.1</fixVersion>
                                    <component>Replication</component>
                                        <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="38971" author="kristina" created="Thu, 23 Jun 2011 21:52:52 +0000"  >&lt;p&gt;Thanks, merged!&lt;/p&gt;</comment>
                            <comment id="38969" author="auto" created="Thu, 23 Jun 2011 21:52:05 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;login&apos;: u&apos;kchodorow&apos;, u&apos;name&apos;: u&apos;Kristina&apos;, u&apos;email&apos;: u&apos;kristina@10gen.com&apos;}
&lt;p&gt;Message: fix null deref &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-3285&quot; title=&quot;Dead Assignment/Variable added in commit 884e100 (also a NULL dereference bug)&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-3285&quot;&gt;&lt;del&gt;SERVER-3285&lt;/del&gt;&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Patch by Mike Mueller&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/8a3a9eb50150dc35fcff41f8fd1e7a2763795c1c&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/8a3a9eb50150dc35fcff41f8fd1e7a2763795c1c&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="38903" author="mmueller" created="Thu, 23 Jun 2011 16:28:14 +0000"  >&lt;p&gt;Hi Kristina, I&apos;ve gone ahead and signed the agreement on behalf of Vigilant. Thanks!&lt;/p&gt;</comment>
                            <comment id="38409" author="kristina" created="Mon, 20 Jun 2011 22:40:28 +0000"  >&lt;p&gt;Thanks for the patches! Can you sign the contributor&apos;s agreement so that I can merge in the null dereference one? &lt;a href=&quot;http://10gen-corp.appspot.com/contributor&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://10gen-corp.appspot.com/contributor&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="38171" author="cwilson" created="Sat, 18 Jun 2011 14:18:23 +0000"  >&lt;p&gt;Looks like the dead assign was updated in this patch,&lt;br/&gt;
  &lt;a href=&quot;https://github.com/mongodb/mongo/commit/3eb1de47f1d19d96ae9facba2afd7e499f90cb7e&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/3eb1de47f1d19d96ae9facba2afd7e499f90cb7e&lt;/a&gt;&lt;br/&gt;
I guess the developers like it.&lt;/p&gt;

&lt;p&gt;Please still look at the null dereference issue.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="12088" name="0001-Remove-a-dead-assignment-of-wasMaster.patch" size="1396" author="cwilson" created="Fri, 17 Jun 2011 17:35:06 +0000"/>
                            <attachment id="12089" name="0002-Fix-a-possible-null-dereference-of-targetHost.patch" size="834" author="cwilson" created="Fri, 17 Jun 2011 17:35:06 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 17 Jun 2011 17:50:11 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        12 years, 34 weeks, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ramon.fernandez@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            12 years, 34 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10000" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Old_Backport</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10000"><![CDATA[No]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>auto</customfieldvalue>
            <customfieldvalue>cwilson</customfieldvalue>
            <customfieldvalue>kristina</customfieldvalue>
            <customfieldvalue>mmueller</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hroxjj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hrirlr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>23125</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|ht0f7z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>