<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:33:52 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-33575] Remove UninterruptibleLockGuards in query code to allow interruptible lock acquisition</title>
                <link>https://jira.mongodb.org/browse/SERVER-33575</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Since &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-32638&quot; title=&quot;Permit dblock acquisition waiting to be interruptible by killOp&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-32638&quot;&gt;&lt;del&gt;SERVER-32638&lt;/del&gt;&lt;/a&gt;, global and database locks can be interrupted when an OperationContext is killed and throw a DBException with an &lt;tt&gt;Interrupted&lt;/tt&gt; error code. This includes all AutoGet helpers.&lt;/p&gt;

&lt;p&gt;The following places in the query code have temporary &lt;tt&gt;UninterruptibleLockGuard&lt;/tt&gt; s to prevent crashing due to inadequate exception handling:&lt;/p&gt;

&lt;p&gt;src/mongo/db/commands/mr.cpp:368&lt;br/&gt;
src/mongo/db/commands/mr.cpp:1017&lt;br/&gt;
src/mongo/db/commands/mr.cpp:1405&lt;br/&gt;
src/mongo/db/commands/mr.cpp:1739&lt;br/&gt;
src/mongo/db/pipeline/document_source_cursor.cpp:268&lt;br/&gt;
src/mongo/db/query/find.cpp:265&lt;br/&gt;
src/mongo/db/query/query_yield.cpp:86&lt;br/&gt;
src/mongo/db/ttl.cpp:137&lt;/p&gt;</description>
                <environment></environment>
        <key id="504142">SERVER-33575</key>
            <summary>Remove UninterruptibleLockGuards in query code to allow interruptible lock acquisition</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="2">Won&apos;t Fix</resolution>
                                        <assignee username="backlog-server-query">Backlog - Query Team</assignee>
                                    <reporter username="louis.williams@mongodb.com">Louis Williams</reporter>
                        <labels>
                    </labels>
                <created>Thu, 1 Mar 2018 16:53:14 +0000</created>
                <updated>Tue, 6 Dec 2022 03:37:06 +0000</updated>
                            <resolved>Thu, 7 Feb 2019 16:06:31 +0000</resolved>
                                    <version>3.7.3</version>
                                                    <component>Querying</component>
                                        <votes>0</votes>
                                    <watches>12</watches>
                                                                                                                <comments>
                            <comment id="2141665" author="samy.lanka" created="Thu, 7 Feb 2019 20:38:17 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=tess.avitabile&quot; class=&quot;user-hover&quot; rel=&quot;tess.avitabile&quot;&gt;tess.avitabile&lt;/a&gt;, none of the remaining UninterruptibleLockGuards conflict with prepare because they don&apos;t take an X or S lock. Although there is work in &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38478&quot; title=&quot;Remove UninterruptibleLockGuard in query yield&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38478&quot;&gt;&lt;del&gt;SERVER-38478&lt;/del&gt;&lt;/a&gt; to make sure that the use of &lt;tt&gt;restoreLockState&lt;/tt&gt; in query_yield.cpp will only restore IX or IS locks. &lt;/p&gt;</comment>
                            <comment id="2141420" author="tess.avitabile" created="Thu, 7 Feb 2019 18:31:29 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=samy.lanka&quot; class=&quot;user-hover&quot; rel=&quot;samy.lanka&quot;&gt;samy.lanka&lt;/a&gt;, can you please check whether the remaining UninterruptibleLockGuards are problematic for prepare?&lt;/p&gt;</comment>
                            <comment id="2141127" author="craig.homa" created="Thu, 7 Feb 2019 16:06:31 +0000"  >&lt;p&gt;There is still some remaining work from the Query team here but if this comes up again they will address it in separate and more narrowly scoped tickets. &lt;/p&gt;</comment>
                            <comment id="2139537" author="david.storch" created="Wed, 6 Feb 2019 15:11:17 +0000"  >&lt;p&gt;The situation has changed since this ticket was filed:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;The &lt;tt&gt;UniterruptibleLockGuards&lt;/tt&gt; in mr.cpp were removed by &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=justin.seyster&quot; class=&quot;user-hover&quot; rel=&quot;justin.seyster&quot;&gt;justin.seyster&lt;/a&gt;&apos;s work under &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38480&quot; title=&quot;Make Map-Reduce fully interruptible&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38480&quot;&gt;&lt;del&gt;SERVER-38480&lt;/del&gt;&lt;/a&gt;.&lt;/li&gt;
	&lt;li&gt;The &lt;tt&gt;UniterruptibleLockGuard&lt;/tt&gt; in document_source_cursor.cpp was removed by my work in &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-37451&quot; title=&quot;Move all cursor ownership to the global cursor manager&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-37451&quot;&gt;&lt;del&gt;SERVER-37451&lt;/del&gt;&lt;/a&gt;.&lt;/li&gt;
	&lt;li&gt;There is still an &lt;tt&gt;UniterruptibleLockGuard&lt;/tt&gt; in find.cpp on the &lt;tt&gt;getMore&lt;/tt&gt; path. I suspect that this is still necessary because of how OP_GET_MORE on an awaitData cursor is implemented, although with some more work it could be removed.&lt;/li&gt;
	&lt;li&gt;The &lt;tt&gt;UniterruptibleLockGuard&lt;/tt&gt; in query_yield.cpp may be difficult to remove safely. This requires more investigation.&lt;/li&gt;
	&lt;li&gt;The &lt;tt&gt;UniterruptibleLockGuard&lt;/tt&gt; in ttl.cpp still exists, but should probably fall outside the domain of this ticket since it&apos;s outside of the query module.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;I&apos;m marking this ticket to be re-triaged by the query team.&lt;/p&gt;</comment>
                            <comment id="1889136" author="asya" created="Fri, 11 May 2018 14:40:30 +0000"  >&lt;p&gt;Query will investigate.&lt;/p&gt;</comment>
                            <comment id="1889118" author="dianna.hohensee" created="Fri, 11 May 2018 14:27:50 +0000"  >&lt;p&gt;I&apos;ve run into an issue with an UninterruptibleLockGuard &lt;a href=&quot;https://github.com/mongodb/mongo/blob/714b97ba9c7dd8de3351eb811befce6c4b6efd63/src/mongo/db/pipeline/document_source_cursor.cpp#L261-L263&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;here in document_source_cursor.cpp&lt;/a&gt; (ran into it via an aggregation). &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-33244&quot; title=&quot;Make all lock acquisitions for transactions have 0 second timeout&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-33244&quot;&gt;&lt;del&gt;SERVER-33244&lt;/del&gt;&lt;/a&gt; is adding a configurable max lock acquisition timeout override for transaction operations, so transactions cannot deadlock with one another. I had an invariant to ensure UninterruptibleLockGuard isn&apos;t used when a max lock acquisition timeout is active for transaction ops: they are contradictory. I&apos;ve created &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-34951&quot; title=&quot;LockerImpl should invariant against active UninterruptibleLockGuard usage when _maxLockTimeout is set&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-34951&quot;&gt;SERVER-34951&lt;/a&gt; to add that check back, and will submit my code without it for v4.0, which is safe from deadlocks because transactions only do CRUD ops that take non-conflicting IS and IX locks. In v4.2 we will have a problem if we want to add ops to transactions that take exclusive locks.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="542578">SERVER-34951</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_12751" key="com.atlassian.jira.plugin.system.customfieldtypes:multiselect">
                        <customfieldname>Assigned Teams</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="25143"><![CDATA[Query]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 11 May 2018 14:27:50 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        5 years, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>alexander.golin@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            5 years, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>asya.kamsky@mongodb.com</customfieldvalue>
            <customfieldvalue>backlog-server-query</customfieldvalue>
            <customfieldvalue>craig.homa@mongodb.com</customfieldvalue>
            <customfieldvalue>david.storch@mongodb.com</customfieldvalue>
            <customfieldvalue>dianna.hohensee@mongodb.com</customfieldvalue>
            <customfieldvalue>louis.williams@mongodb.com</customfieldvalue>
            <customfieldvalue>samy.lanka@mongodb.com</customfieldvalue>
            <customfieldvalue>tess.avitabile@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|htrfxb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr7ldj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|htr23r:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>