<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:38:57 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-35137] Unsanitary sasl vsnprintf calls</title>
                <link>https://jira.mongodb.org/browse/SERVER-35137</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;This is a classic syslog &quot;%s&quot; error. We should just pretty much always use &quot;%s&quot; format and then the string we want to log as the next argument, just to make it less tempting for a % sign to creep into the format strings under maintenance.&lt;/p&gt;


&lt;p&gt;```src/mongo/db/modules/mongo-enterprise-modules/src/sasl/canon_mongodb_internal.cpp:78:41: error: format string is not a string literal (potentially insecure) &lt;span class=&quot;error&quot;&gt;&amp;#91;-Werror,-Wformat-security&amp;#93;&lt;/span&gt;&lt;br/&gt;
 utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, sb.str().c_str());&lt;br/&gt;
 ^~~~~~~~~~~~~~~~```&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;

&lt;p&gt;These get it right:&lt;/p&gt;

&lt;p&gt;src/mongo/client/sasl_sspi.cpp:97:    utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, &quot;%s&quot;, buffer.c_str());&lt;br/&gt;
src/sasl/mongo_sspi.cpp:122:    utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, &quot;%s&quot;, buffer.c_str());&lt;/p&gt;


&lt;p&gt;&#160;The rest get it sort of wrong:&lt;br/&gt;
billy@billydev:~/dev/mongodb/mongo$ git grep -E -n &apos;\b(sasl_)?seterror&apos;&lt;br/&gt;
src/mongo/client/cyrus_sasl_client_session.cpp:202:            sasl_seterror(conn, 0, &quot;No password data provided&quot;);&lt;br/&gt;
src/mongo/client/cyrus_sasl_client_session.cpp:211:        sasl_seterror(conn, 0, sb.str().c_str());&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:114:        cparams-&amp;gt;utils-&amp;gt;seterror(cparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;getcallback user failed&quot;);&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:122:        cparams-&amp;gt;utils-&amp;gt;seterror(cparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;user callback failed&quot;);&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:130:        cparams-&amp;gt;utils-&amp;gt;seterror(cparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;no @REALM found in username&quot;);&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:190:        cparams-&amp;gt;utils-&amp;gt;seterror(cparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;SSPI: no serverFQDN&quot;);&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:255:        cparams-&amp;gt;utils-&amp;gt;seterror(cparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;SSPI: server message is too short&quot;);&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:262:        cparams-&amp;gt;utils-&amp;gt;seterror(&lt;br/&gt;
src/mongo/client/sasl_sspi.cpp:458:        utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, &quot;Wrong SSPI version&quot;);&lt;/p&gt;

&lt;p&gt;src/sasl/canon_mongodb_internal.cpp:62:            utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, &quot;All-whitespace username.&quot;);&lt;br/&gt;
src/sasl/canon_mongodb_internal.cpp:68:            utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, &quot;Canonicalized username too long.&quot;);&lt;br/&gt;
src/sasl/canon_mongodb_internal.cpp:78:        utils-&amp;gt;seterror(utils-&amp;gt;conn, 0, sb.str().c_str());&lt;br/&gt;
src/sasl/cyrus_sasl_authentication_session.cpp:126:            sasl_seterror(conn, 0, errorMsg.str().c_str());&lt;br/&gt;
src/sasl/cyrus_sasl_authentication_session.cpp:133:        sasl_seterror(conn, 0, sb.str().c_str());&lt;br/&gt;
src/sasl/mongo_sspi.cpp:141:        sparams-&amp;gt;utils-&amp;gt;seterror(sparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;SSPI: no serverFQDN&quot;);&lt;br/&gt;
src/sasl/mongo_sspi.cpp:184:        sparams-&amp;gt;utils-&amp;gt;seterror(sparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;SSPI: client unexpectedly sent data&quot;);&lt;br/&gt;
src/sasl/mongo_sspi.cpp:310:        sparams-&amp;gt;utils-&amp;gt;seterror(&lt;br/&gt;
src/sasl/mongo_sspi.cpp:317:        sparams-&amp;gt;utils-&amp;gt;seterror(sparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;SSPI: wrong security layer from client&quot;);&lt;br/&gt;
src/sasl/mongo_sspi.cpp:324:        sparams-&amp;gt;utils-&amp;gt;seterror(sparams-&amp;gt;utils-&amp;gt;conn, 0, &quot;SSPI: no authz name in auth handshake&quot;);&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</description>
                <environment></environment>
        <key id="547256">SERVER-35137</key>
            <summary>Unsanitary sasl vsnprintf calls</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="billy.donahue@mongodb.com">Billy Donahue</assignee>
                                    <reporter username="billy.donahue@mongodb.com">Billy Donahue</reporter>
                        <labels>
                    </labels>
                <created>Mon, 21 May 2018 20:36:45 +0000</created>
                <updated>Sun, 29 Oct 2023 22:31:34 +0000</updated>
                            <resolved>Tue, 22 May 2018 20:55:17 +0000</resolved>
                                                    <fixVersion>4.1.1</fixVersion>
                                    <component>Internal Code</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="1898894" author="xgen-internal-githook" created="Tue, 22 May 2018 20:53:20 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;username&apos;: &apos;BillyDonahue&apos;, &apos;name&apos;: &apos;Billy Donahue&apos;, &apos;email&apos;: &apos;billy.donahue@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-35137&quot; title=&quot;Unsanitary sasl vsnprintf calls&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-35137&quot;&gt;&lt;del&gt;SERVER-35137&lt;/del&gt;&lt;/a&gt; sasl seterror formats&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/d05b22711acde181745b8319d779bc2fb9f14cd6&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/d05b22711acde181745b8319d779bc2fb9f14cd6&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="1898293" author="xgen-internal-githook" created="Tue, 22 May 2018 15:23:30 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;username&apos;: &apos;BillyDonahue&apos;, &apos;name&apos;: &apos;Billy Donahue&apos;, &apos;email&apos;: &apos;billy.donahue@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-35137&quot; title=&quot;Unsanitary sasl vsnprintf calls&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-35137&quot;&gt;&lt;del&gt;SERVER-35137&lt;/del&gt;&lt;/a&gt; fix sasl logging formats&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/10gen/mongo-enterprise-modules/commit/f80b71b6947dbeecee796876338566af38ed219e&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/10gen/mongo-enterprise-modules/commit/f80b71b6947dbeecee796876338566af38ed219e&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 22 May 2018 15:23:30 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        5 years, 38 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            5 years, 38 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>billy.donahue@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|htymnb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr8lb3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hty8wn:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>