<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 03:03:53 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-3727] minor btree cleanups</title>
                <link>https://jira.mongodb.org/browse/SERVER-3727</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;These are just minor code cleanups - wanted to track somewhere.  Anyone feel free to add stuff (I will if I see more issues), though major architectural changes should probably be separate tickets.&lt;/p&gt;

&lt;p&gt;        ss &amp;lt;&amp;lt; &quot;    parent: &quot; &amp;lt;&amp;lt; this-&amp;gt;parent.toString() &amp;lt;&amp;lt; endl;&lt;br/&gt;
        ss &amp;lt;&amp;lt; &quot;    nextChild: &quot; &amp;lt;&amp;lt; this-&amp;gt;parent.toString() &amp;lt;&amp;lt; endl;&lt;/p&gt;

&lt;p&gt;logging nextChild incorrectly.&lt;/p&gt;


&lt;p&gt;        BTREE(this-&amp;gt;nextChild)&lt;del&gt;&amp;gt;parent.writing() = this&lt;/del&gt;&amp;gt;parent;&lt;/p&gt;

&lt;p&gt;        BTREE(this-&amp;gt;nextChild)&lt;del&gt;&amp;gt;parent.writing() = this&lt;/del&gt;&amp;gt;parent;&lt;br/&gt;
        //(static_cast&amp;lt;DiskLoc&amp;gt;(this-&amp;gt;nextChild).btree&amp;lt;V&amp;gt;())&lt;del&gt;&amp;gt;parent.writing() = this&lt;/del&gt;&amp;gt;parent;&lt;/p&gt;

&lt;p&gt;We are signaling write intent and assigning twice&lt;/p&gt;


&lt;p&gt;            // Because lchild is a descendant of thisLoc, updating thisLoc will&lt;br/&gt;
            // not not affect packing or keys of lchild and kn will be stable&lt;br/&gt;
            // during the following setInternalKey()            &lt;/p&gt;

&lt;p&gt;Double not&lt;/p&gt;


&lt;p&gt;                // make a this-&amp;gt;new this-&amp;gt;parent if we were the root&lt;/p&gt;

&lt;p&gt;???&lt;/p&gt;


&lt;p&gt;        operator DiskLoc() const &lt;/p&gt;
{ 
            // endian
            if( isNull() ) return DiskLoc();
            unsigned a = *((unsigned *) (_a-1));
            return DiskLoc(a &amp;gt;&amp;gt; 8, ofs);
        }


&lt;p&gt;Should return const DiskLoc&lt;/p&gt;</description>
                <environment></environment>
        <key id="21691">SERVER-3727</key>
            <summary>minor btree cleanups</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="-1">Unassigned</assignee>
                                    <reporter username="aaron">Aaron Staple</reporter>
                        <labels>
                    </labels>
                <created>Tue, 30 Aug 2011 20:37:16 +0000</created>
                <updated>Mon, 11 Jul 2016 18:35:17 +0000</updated>
                            <resolved>Wed, 14 Sep 2011 06:50:50 +0000</resolved>
                                                    <fixVersion>2.1.0</fixVersion>
                                    <component>Index Maintenance</component>
                                        <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="56654" author="guanqun" created="Mon, 26 Sep 2011 16:13:54 +0000"  >&lt;p&gt;found another trivial cleanup...&lt;/p&gt;

&lt;p&gt;delete the un-needed return statement. pull request here: &lt;a href=&quot;https://github.com/mongodb/mongo/pull/92&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/pull/92&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;diff --git a/db/btree.cpp b/db/btree.cpp&lt;br/&gt;
index 823ab59..ff53882 100644&lt;br/&gt;
&amp;#8212; a/db/btree.cpp&lt;br/&gt;
+++ b/db/btree.cpp&lt;br/&gt;
@@ -1337,7 +1337,6 @@ namespace mongo &lt;/p&gt;
{
                 if ( !rchild.isNull() )
                     rchild.btree&amp;lt;V&amp;gt;()-&amp;gt;parent.writing() = thisLoc;
             }
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;return;&lt;br/&gt;
         }&lt;br/&gt;
     }&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="53724" author="auto" created="Tue, 13 Sep 2011 15:56:37 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;login&apos;: u&apos;astaple&apos;, u&apos;name&apos;: u&apos;Aaron&apos;, u&apos;email&apos;: u&apos;aaron@10gen.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-3727&quot; title=&quot;minor btree cleanups&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-3727&quot;&gt;&lt;del&gt;SERVER-3727&lt;/del&gt;&lt;/a&gt; minor btree cleanups&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/7a8fa525bb65eedc027cfcbbd783a7e83f5f0319&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/7a8fa525bb65eedc027cfcbbd783a7e83f5f0319&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 13 Sep 2011 15:56:37 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        12 years, 21 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ramon.fernandez@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            12 years, 21 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10000" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Old_Backport</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10000"><![CDATA[No]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>aaron</customfieldvalue>
            <customfieldvalue>auto</customfieldvalue>
            <customfieldvalue>guanqun</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hros7z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hrg83b:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8216</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hsa8nj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>