<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:46:45 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-37700] Remove white-space from use in setThreadName</title>
                <link>https://jira.mongodb.org/browse/SERVER-37700</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Less robust programs may parse the proc filesystem incorrectly if there is whitespace in thread names. I propose that we debug assert that there is no whitespace in the name inside the function setThreadName.&lt;/p&gt;

&lt;p&gt;As of now, I&apos;ve found thread names containing spaces in:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;src/mongo/db/commands/generic.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/db/index_builder.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/db/keys_collection_manager.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/db/repl/oplog_applier.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/db/s/metadata_manager.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/db/s/session_catalog_migration_destination_test.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/db/storage/wiredtiger/wiredtiger_record_store_mongod.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/dbtests/deferred_writer.cpp&lt;/li&gt;
	&lt;li&gt;src/mongo/s/client/shard_registry.cpp&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="622415">SERVER-37700</key>
            <summary>Remove white-space from use in setThreadName</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="jonathan.ma@mongodb.com">Jonathan Ma</assignee>
                                    <reporter username="ben.caimano@mongodb.com">Benjamin Caimano</reporter>
                        <labels>
                            <label>neweng</label>
                    </labels>
                <created>Mon, 22 Oct 2018 18:07:18 +0000</created>
                <updated>Sun, 29 Oct 2023 22:27:15 +0000</updated>
                            <resolved>Tue, 8 Jan 2019 15:13:17 +0000</resolved>
                                                    <fixVersion>4.1.7</fixVersion>
                                                        <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="2108607" author="ben.caimano" created="Tue, 8 Jan 2019 15:17:27 +0000"  >&lt;p&gt;As an additional note, we found situations where clients were able to set the thread name. We cannot effectively prevent the setting of thread names with white space in that case.&lt;/p&gt;</comment>
                            <comment id="2108599" author="jonathan.ma" created="Tue, 8 Jan 2019 15:14:00 +0000"  >&lt;p&gt;Ticket has been adjusted to only scrubbing whitespaces from existing thread names.&lt;/p&gt;</comment>
                            <comment id="2108594" author="xgen-internal-githook" created="Tue, 8 Jan 2019 15:11:25 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;email&apos;: &apos;jonathan.ma@mongodb.com&apos;, &apos;name&apos;: &apos;Jonathan Ma&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-37700&quot; title=&quot;Remove white-space from use in setThreadName&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-37700&quot;&gt;&lt;del&gt;SERVER-37700&lt;/del&gt;&lt;/a&gt; Remove thread names that include whitespaces&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/a43fb64a1c640378c54d1e61869d607f70154f91&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/a43fb64a1c640378c54d1e61869d607f70154f91&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2098681" author="ben.caimano" created="Fri, 21 Dec 2018 18:08:09 +0000"  >&lt;p&gt;For reference, thread names are set via &lt;a href=&quot;https://github.com/mongodb/mongo/blob/a66a5578d5b006cef85b16eac05c96b58c877ebe/src/mongo/util/concurrency/thread_name.cpp#L117&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;setThreadName&lt;/a&gt;. These also tend to get set via &lt;a href=&quot;https://github.com/mongodb/mongo/blob/a66a5578d5b006cef85b16eac05c96b58c877ebe/src/mongo/executor/network_interface_tl.cpp#L105&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;this fill in&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;This change is desirable because it&apos;s a trivial way to make mongodb easier to understand for tools that parse procfs data since it tends to be space separated.&lt;/p&gt;</comment>
                            <comment id="2038053" author="ben.caimano" created="Mon, 22 Oct 2018 19:30:59 +0000"  >&lt;p&gt;I think there might be precedent for hyphens instead? (Not sure it matters, just commenting.)&lt;/p&gt;</comment>
                            <comment id="2037885" author="sara.williamson" created="Mon, 22 Oct 2018 18:13:14 +0000"  >&lt;p&gt;The plan here would be to change whitespace to underscores.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 22 Oct 2018 18:13:14 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        5 years, 5 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-1203</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            5 years, 5 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>ben.caimano@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>jonathan.ma@mongodb.com</customfieldvalue>
            <customfieldvalue>sara.williamson@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|huaxrr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hu18b3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="2705">Service Arch 2018-12-31</customfieldvalue>
    <customfieldvalue id="2738">Service Arch 2019-01-14</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|huak13:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>