<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:47:46 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-38034] OperationContextSessionMongod constructor should just take required parameters, not entire OperationSessionInfoFromClient</title>
                <link>https://jira.mongodb.org/browse/SERVER-38034</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;because the coordinateCommit command needs to check out the session from inside the command body in order to recover a decision from the local participant, and an OperationSessionInfoFromClient cannot be constructed inside the coordinateCommit command.&lt;/p&gt;</description>
                <environment></environment>
        <key id="631416">SERVER-38034</key>
            <summary>OperationContextSessionMongod constructor should just take required parameters, not entire OperationSessionInfoFromClient</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13203">Gone away</resolution>
                                        <assignee username="esha.maharishi@mongodb.com">Esha Maharishi</assignee>
                                    <reporter username="esha.maharishi@mongodb.com">Esha Maharishi</reporter>
                        <labels>
                    </labels>
                <created>Thu, 8 Nov 2018 18:52:02 +0000</created>
                <updated>Fri, 27 Oct 2023 20:43:10 +0000</updated>
                            <resolved>Mon, 12 Nov 2018 19:20:10 +0000</resolved>
                                                                    <component>Sharding</component>
                                        <votes>0</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="2059167" author="esha.maharishi@10gen.com" created="Mon, 12 Nov 2018 19:19:54 +0000"  >&lt;p&gt;Closing in lieu of &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38095&quot; title=&quot;Remove unused OperationSessionInfoFromClient argument to OperationContextSessionMongod constructor&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38095&quot;&gt;&lt;del&gt;SERVER-38095&lt;/del&gt;&lt;/a&gt;, since after &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-37179&quot; title=&quot;Wait for specified write concern whenever commitTransaction returns a NoSuchTransaction error&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-37179&quot;&gt;&lt;del&gt;SERVER-37179&lt;/del&gt;&lt;/a&gt;, OperationContextSessionMongod no longer uses the OperationSessionInfoFromClient parameter at all.&lt;/p&gt;</comment>
                            <comment id="2058675" author="esha.maharishi@10gen.com" created="Mon, 12 Nov 2018 14:57:59 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=siyuan.zhou&quot; class=&quot;user-hover&quot; rel=&quot;siyuan.zhou&quot;&gt;siyuan.zhou&lt;/a&gt;, I dug a little deeper and found that:&lt;/p&gt;

&lt;p&gt;1) Checking out a session &lt;a href=&quot;https://github.com/mongodb/mongo/blob/236c6c28a18210586673097ee436c5b613b6c46f/src/mongo/db/session_catalog.cpp#L83&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;uses&lt;/a&gt;&#160;the LogicalSessionId on the OperationContext&lt;/p&gt;

&lt;p&gt;2) the &lt;a href=&quot;https://github.com/mongodb/mongo/blob/a66a5578d5b006cef85b16eac05c96b58c877ebe/src/mongo/db/operation_context.h#L412&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;LogicalSessionId on the OperationContext&lt;/a&gt;&#160;is set &lt;a href=&quot;https://github.com/mongodb/mongo/blob/248601a6473fc7364e5d790a357acbace2a42f7a/src/mongo/db/initialize_operation_session_info.cpp#L87&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;in initializeOperationSessionInfo&lt;/a&gt;&#160;through the makeLogicalSessionId helper, which sets both the &lt;a href=&quot;https://github.com/mongodb/mongo/blob/a66a5578d5b006cef85b16eac05c96b58c877ebe/src/mongo/db/logical_session_id_helpers.cpp#L84&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;lsid&lt;/a&gt;&#160;and &lt;a href=&quot;https://github.com/mongodb/mongo/blob/a66a5578d5b006cef85b16eac05c96b58c877ebe/src/mongo/db/logical_session_id_helpers.cpp#L100&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;uid&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;So, changing OperationContextSessionMongod&apos;s constructor not to take the whole OperationSessionInfoFromClient should make no difference on the LogicalSessionId used to check out the session.&lt;/p&gt;

&lt;p&gt;CC&#160;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=kaloian.manassiev&quot; class=&quot;user-hover&quot; rel=&quot;kaloian.manassiev&quot;&gt;kaloian.manassiev&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2058303" author="kaloian.manassiev" created="Mon, 12 Nov 2018 07:18:50 +0000"  >&lt;p&gt;This doesn&apos;t make sense. The UID is part of the LogicalSessionId, which is returned by &lt;tt&gt;ScopedCheckedOutSession::get(opCtx)-&amp;gt;getSessionId()&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;Are you saying that the returned LSID doesn&apos;t contain UID (because that would be a bug)?&lt;/p&gt;</comment>
                            <comment id="2057637" author="siyuan.zhou@10gen.com" created="Fri, 9 Nov 2018 20:52:07 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=kaloian.manassiev&quot; class=&quot;user-hover&quot; rel=&quot;kaloian.manassiev&quot;&gt;kaloian.manassiev&lt;/a&gt;, the reason why Esha wants a new structure is that we only have the session id on operation context without the &lt;tt&gt;uid&lt;/tt&gt; when calling &lt;tt&gt;OperationContextSessionMongod&lt;/tt&gt; in sharding.&lt;/p&gt;</comment>
                            <comment id="2056852" author="kaloian.manassiev" created="Fri, 9 Nov 2018 08:27:04 +0000"  >&lt;blockquote&gt;&lt;p&gt;I&apos;m not sure whether the uid field of logical session id is required or not though.&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;The uid of a logical session &lt;b&gt;is&lt;/b&gt; an integral part of the LSID and we have had bugs previously because of code, which ignores it - &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-37657&quot; title=&quot;Report the offending oplog entries if a batch contains non-increasing transaction numbers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-37657&quot;&gt;&lt;del&gt;SERVER-37657&lt;/del&gt;&lt;/a&gt;. &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=siyuan.zhou&quot; class=&quot;user-hover&quot; rel=&quot;siyuan.zhou&quot;&gt;siyuan.zhou&lt;/a&gt;, in what context are you asking about this?&lt;/p&gt;</comment>
                            <comment id="2056696" author="esha.maharishi@10gen.com" created="Thu, 8 Nov 2018 23:04:13 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=judah.schvimer&quot; class=&quot;user-hover&quot; rel=&quot;judah.schvimer&quot;&gt;judah.schvimer&lt;/a&gt;, OperationContextSessionMongod only accesses the &apos;autocommit&apos;, &apos;startTransaction&apos; and &apos;coordinator&apos; fields of OperationSessionInfoFromClient. I think passing OperationSessionInfoFromClient was not only sufficient but too much, and it makes checking out the session in places other than the service entry point more difficult because the entire OperationSessionInfoFromClient may not be available.&lt;/p&gt;</comment>
                            <comment id="2056579" author="siyuan.zhou@10gen.com" created="Thu, 8 Nov 2018 21:24:38 +0000"  >&lt;p&gt;Talked with Esha yesterday, this ticket is the conclusion from that discussion. I&apos;m not sure whether the &lt;tt&gt;uid&lt;/tt&gt; field of logical session id is required or not though. I guess sharding team has more context on logical session.&lt;/p&gt;</comment>
                            <comment id="2056575" author="judah.schvimer" created="Thu, 8 Nov 2018 21:20:51 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=siyuan.zhou&quot; class=&quot;user-hover&quot; rel=&quot;siyuan.zhou&quot;&gt;siyuan.zhou&lt;/a&gt;, is this essentially undoing &lt;a href=&quot;https://github.com/mongodb/mongo/commit/248601a6473fc7364e5d790a357acbace2a42f7a&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/248601a6473fc7364e5d790a357acbace2a42f7a&lt;/a&gt;, is that ok?&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="632594">SERVER-38095</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 8 Nov 2018 21:20:51 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        5 years, 13 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            5 years, 13 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>esha.maharishi@mongodb.com</customfieldvalue>
            <customfieldvalue>judah.schvimer@mongodb.com</customfieldvalue>
            <customfieldvalue>kaloian.manassiev@mongodb.com</customfieldvalue>
            <customfieldvalue>siyuan.zhou@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hucgvj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hu24zb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|huc34v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>