<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:47:50 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-38060] Don&apos;t run after test hooks in resmoke if the test fails</title>
                <link>https://jira.mongodb.org/browse/SERVER-38060</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;We should not run the resmoke correctness hooks if a test fails and the test suite runs with &lt;tt&gt;--continueOnFailure&lt;/tt&gt;. In the best case it causes confusion in the evergreen side bar because there are multiple red boxes, one for the test and at least one for the hooks&lt;/p&gt;

&lt;p&gt;In the worst case the failing test leaves the server in an inconsistent state, which can cause the hook to hang, making debugging much more difficult.&lt;/p&gt;</description>
                <environment></environment>
        <key id="631805">SERVER-38060</key>
            <summary>Don&apos;t run after test hooks in resmoke if the test fails</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13203">Gone away</resolution>
                                        <assignee username="backlog-server-stm">Backlog - Server Tooling and Methods (STM)</assignee>
                                    <reporter username="robert.guo@mongodb.com">Robert Guo</reporter>
                        <labels>
                            <label>tig-resmoke</label>
                    </labels>
                <created>Fri, 9 Nov 2018 18:00:36 +0000</created>
                <updated>Fri, 27 Oct 2023 20:43:10 +0000</updated>
                            <resolved>Wed, 5 Feb 2020 15:28:18 +0000</resolved>
                                                                    <component>Testing Infrastructure</component>
                                        <votes>0</votes>
                                    <watches>5</watches>
                                                                                                                <comments>
                            <comment id="2784835" author="ian@10gen.com" created="Wed, 5 Feb 2020 15:28:18 +0000"  >&lt;p&gt;closing as gone away as per last comment.&lt;/p&gt;</comment>
                            <comment id="2653409" author="ian@10gen.com" created="Thu, 19 Dec 2019 20:16:06 +0000"  >&lt;p&gt;We don&apos;t believe that this will make sense anymore with the completion of PM-1547 pending.  We will likely close this as Won&apos;t Fix after that unless someone objects.  Please let us know.&lt;/p&gt;</comment>
                            <comment id="2057750" author="judah.schvimer" created="Fri, 9 Nov 2018 21:59:54 +0000"  >&lt;p&gt;I agree with &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=max.hirschhorn&quot; class=&quot;user-hover&quot; rel=&quot;max.hirschhorn&quot;&gt;max.hirschhorn&lt;/a&gt; and would prefer to abort transactions before running any consistency check hooks to prevent hangs.&lt;/p&gt;

&lt;blockquote&gt;
&lt;p&gt;For example, if a replica set test partitions nodes, fails, and forgets to heal the partitions, will all data consistency checking hooks be compatible with this?&lt;/p&gt;&lt;/blockquote&gt;
&lt;p&gt;Tests that partition or fail nodes don&apos;t tend to run data consistency checks. They generally use their own fixture and mark that they shouldn&apos;t check data consistency.&lt;/p&gt;</comment>
                            <comment id="2057661" author="william.schultz" created="Fri, 9 Nov 2018 21:03:48 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=max.hirschhorn&quot; class=&quot;user-hover&quot; rel=&quot;max.hirschhorn&quot;&gt;max.hirschhorn&lt;/a&gt; I see your point. Generally, I think that it is difficult to assert that every test, upon completion, leaves the database (or cluster), in some kind of &quot;consistent&quot; state, that won&apos;t interfere with all the consistency checks we may try to execute. For example, if a replica set test partitions nodes, fails, and forgets to heal the partitions, will all data consistency checking hooks be compatible with this? I&apos;m not sure. For this specific case (transactions being left open at the end of tests), I agree that a separate hook for cleaning this up would be sensible. It should run before any other consistency checking hooks run, and would ideally kill any idle transactions and also report information about which transactions are being killed. I think that &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=judah.schvimer&quot; class=&quot;user-hover&quot; rel=&quot;judah.schvimer&quot;&gt;judah.schvimer&lt;/a&gt; mentioned that we may already need to build something inside the server similar to this, so that could be a starting point.&lt;/p&gt;</comment>
                            <comment id="2057411" author="max.hirschhorn@10gen.com" created="Fri, 9 Nov 2018 18:15:40 +0000"  >&lt;blockquote&gt;
&lt;p&gt;Don&apos;t run after test hooks in resmoke if the test fails	&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;I&apos;m not confident about this proposal. There shouldn&apos;t be anything a test does that can cause data to be corrupt data, and so if a test fails and also happens to corrupt data that&apos;s interesting. Also, the decision about whether to archive data files is typically based around whether a resmoke.py hook fails so we may end up with less diagnostics when debugging the test failure.&lt;/p&gt;

&lt;blockquote&gt;
&lt;p&gt;Ok, cool. i had a test that hung because it tried to run repl oplog check after a transactions test that threw an exception and left a transaction open. We can probably have the test do better to clean up after itself, but it felt like if a test fails, there should be few guarantees about the state it leaves things in, and so shutting down the node without doing the checks seems reasonable. Is there a ticket for it?&lt;/p&gt;&lt;/blockquote&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=william.schultz&quot; class=&quot;user-hover&quot; rel=&quot;william.schultz&quot;&gt;william.schultz&lt;/a&gt;, I would propose that you create a new hook and add it to the test suites you&apos;re interested in if there are properties you want to assert about the server&apos;s state after a test runs. &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-20773&quot; title=&quot;core/fsync.js can leave test server fsyncLocked&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-20773&quot;&gt;&lt;del&gt;SERVER-20773&lt;/del&gt;&lt;/a&gt; is something that could probably fall under this category.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="631804">SERVER-38059</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="591237">SERVER-36770</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="603280">SERVER-37103</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_12751" key="com.atlassian.jira.plugin.system.customfieldtypes:multiselect">
                        <customfieldname>Assigned Teams</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="25142"><![CDATA[Server Tooling & Methods]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 9 Nov 2018 18:15:40 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        4 years, 1 week ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            4 years, 1 week ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>backlog-server-stm</customfieldvalue>
            <customfieldvalue>ian@mongodb.com</customfieldvalue>
            <customfieldvalue>judah.schvimer@mongodb.com</customfieldvalue>
            <customfieldvalue>max.hirschhorn@mongodb.com</customfieldvalue>
            <customfieldvalue>robert.guo@mongodb.com</customfieldvalue>
            <customfieldvalue>william.schultz@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hucj9z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hu2qsv:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|huc5jb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>