<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:48:40 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-38339] Better SessionKiller thread name in logs</title>
                <link>https://jira.mongodb.org/browse/SERVER-38339</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Currently it shows up as [thread#number]. Example:&lt;/p&gt;

&lt;p/&gt;
&lt;div id=&quot;syntaxplugin&quot; class=&quot;syntaxplugin&quot; style=&quot;border: 1px dashed #bbb; border-radius: 5px !important; overflow: auto; max-height: 30em;&quot;&gt;
&lt;table cellspacing=&quot;0&quot; cellpadding=&quot;0&quot; border=&quot;0&quot; width=&quot;100%&quot; style=&quot;font-size: 1em; line-height: 1.4em !important; font-weight: normal; font-style: normal; color: black;&quot;&gt;
		&lt;tbody &gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;  margin-top: 10px;   margin-bottom: 10px;  width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;2018-11-29T23:42:32.034+0000 I COMMAND  [thread803] killing op: 31246 as part of killing session: { id: UUID(&quot;61912b4a-9c44-4cd7-bd75-cebf2da008f1&quot;), uid: BinData(0, 225D5B72D8EF7D8440D09A4B518E1795ED84E9BC3E28CD58A4CAF8C79DAA1A01) }&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
			&lt;/tbody&gt;
&lt;/table&gt;
&lt;/div&gt;
&lt;p/&gt;</description>
                <environment></environment>
        <key id="641188">SERVER-38339</key>
            <summary>Better SessionKiller thread name in logs</summary>
                <type id="4" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14710&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="alexandre.bique@mongodb.com">Alexandre Bique</assignee>
                                    <reporter username="randolph@mongodb.com">Randolph Tan</reporter>
                        <labels>
                            <label>neweng</label>
                            <label>sharding-wfbf-day</label>
                    </labels>
                <created>Fri, 30 Nov 2018 19:13:29 +0000</created>
                <updated>Sun, 29 Oct 2023 22:26:12 +0000</updated>
                            <resolved>Tue, 26 Jan 2021 08:51:34 +0000</resolved>
                                    <version>4.1.5</version>
                                    <fixVersion>4.9.0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="3581149" author="xgen-internal-githook" created="Mon, 25 Jan 2021 19:13:30 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Alexandre Bique&apos;, &apos;email&apos;: &apos;alexandre.bique@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38339&quot; title=&quot;Better SessionKiller thread name in logs&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38339&quot;&gt;&lt;del&gt;SERVER-38339&lt;/del&gt;&lt;/a&gt; Better SessionKiller thread name in logs&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/d5d4b4945fabfb772b758b95fbfa698c4448484e&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/d5d4b4945fabfb772b758b95fbfa698c4448484e&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3579793" author="kaloian.manassiev" created="Mon, 25 Jan 2021 09:31:00 +0000"  >&lt;p&gt;Good considerations. Since there is only one instance of the &quot;SessionKiller&quot;, this would be the best name. Even if there were more than one, they all will be doing the same thing, so nothing useful would be able to be inferred from the name anyways.&lt;/p&gt;</comment>
                            <comment id="3579750" author="JIRAUSER1258246" created="Mon, 25 Jan 2021 08:38:26 +0000"  >&lt;p&gt;ThreadClient has two constructors, and here I&apos;m not sure what to do:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;the first one takes the name as a string, where I could pass &quot;SessionKiller&quot;, I guess it is better than thread36 but if there are many instances of SessionKiller it is not very helpful either&lt;/li&gt;
	&lt;li&gt;the second one guess the name using getThreadName(), but in certain tests it results in &quot;thread36&quot; so I don&apos;t think it helps.&lt;/li&gt;
	&lt;li&gt;a third option would be to create a string containing both &quot;SessionKiller&quot; and getThreadName() but I doubt that getThreadName() will contain anything useful anyway because setThreadName() is not called earlier.&lt;/li&gt;
	&lt;li&gt;ServiceContext does not seem to provide a name itself, or at least it is not obvious to me.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;So I conclude that the best option is to go with &quot;SessionKiller&quot;. Please let me know if I missed something.&lt;/p&gt;</comment>
                            <comment id="3577349" author="kaloian.manassiev" created="Fri, 22 Jan 2021 10:51:36 +0000"  >&lt;p&gt;This is a matter of using &lt;a href=&quot;https://github.com/mongodb/mongo/blob/f3617ccb88b713884ae8e3853eefa42e84feda6d/src/mongo/db/client.h#L316&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;ThreadClient&lt;/tt&gt;&lt;/a&gt; in the &lt;a href=&quot;https://github.com/mongodb/mongo/blob/f3617ccb88b713884ae8e3853eefa42e84feda6d/src/mongo/db/session_killer.cpp#L51&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;SessionKiller&apos;s thread&lt;/a&gt; rather than &lt;tt&gt;Client::setCurrent&lt;/tt&gt;. This will take care of setting the thread name properly.&lt;/p&gt;</comment>
                            <comment id="2078504" author="renctan" created="Mon, 3 Dec 2018 16:15:31 +0000"  >&lt;p&gt;This is from the SessionKiller background thread, that&apos;s why it doesn&apos;t have the &quot;conn#&quot; name.&lt;/p&gt;</comment>
                            <comment id="2078199" author="kaloian.manassiev" created="Mon, 3 Dec 2018 12:33:06 +0000"  >&lt;p&gt;This message comes from &lt;a href=&quot;https://github.com/mongodb/mongo/blob/88bcf424bc9830454847f015757ad710ee30827d/src/mongo/db/kill_sessions_common.cpp#L72&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;killSessionsCommon&lt;/tt&gt;&lt;/a&gt; and all of the calls seem to come from commands, such as &lt;a href=&quot;https://github.com/mongodb/mongo/blob/88bcf424bc9830454847f015757ad710ee30827d/src/mongo/db/commands/kill_sessions_command.cpp#L132&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;&lt;tt&gt;killSessions&lt;/tt&gt;&lt;/a&gt;. Therefore I don&apos;t think we are in control of how the thread is named. Is it possible that the commands&apos; thread name generation is broken, causing the commands to not have &lt;tt&gt;conn803&lt;/tt&gt; in the name?&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 3 Dec 2018 12:33:06 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        3 years, 2 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            3 years, 2 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>alexandre.bique@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>kaloian.manassiev@mongodb.com</customfieldvalue>
            <customfieldvalue>randolph@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hue4pz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hu3gmf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4484">Sharding 2021-02-08</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hudqzb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>