<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 04:50:24 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-38910] Remove redundant rollback handling on index drops</title>
                <link>https://jira.mongodb.org/browse/SERVER-38910</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;With the completion of &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38548&quot; title=&quot;Leverage the KVDropPendingIdentReaper and TimestampMonitor to make index drops two-phase&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38548&quot;&gt;&lt;del&gt;SERVER-38548&lt;/del&gt;&lt;/a&gt; making index drops two-phase, we can now remove the special handling where we rebuild indexes on rollback because the index table was dropped immediately and the dropIndex gets rolled back.&lt;/p&gt;

&lt;p&gt;I believe &lt;a href=&quot;https://github.com/mongodb/mongo/blob/5d0f13334445fca6e2c5bfc496b5d5b1cb7e0f8a/src/mongo/db/storage/kv/kv_storage_engine.cpp#L419-L429&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;this code in kv_storage_engine.cpp&lt;/a&gt; does the special handling and can now be eliminated safely.&lt;/p&gt;

&lt;p&gt;And &lt;a href=&quot;https://github.com/mongodb/mongo/blob/5d0f13334445fca6e2c5bfc496b5d5b1cb7e0f8a/src/mongo/db/storage/kv/kv_storage_engine.cpp#L435&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;in this bit&lt;/a&gt;, it should also be safe to refactor away the &quot;!foundIdent&quot; piece. Dan G&apos;s explanation of that scenario was as follows, which won&apos;t happen anymore either with &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38548&quot; title=&quot;Leverage the KVDropPendingIdentReaper and TimestampMonitor to make index drops two-phase&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38548&quot;&gt;&lt;del&gt;SERVER-38548&lt;/del&gt;&lt;/a&gt; complete,&lt;/p&gt;

&lt;p&gt;&quot;&lt;br/&gt;
 Suppose the oplog contains:&lt;br/&gt;
 ts: 10, createIndex: &quot;a&quot;&lt;br/&gt;
 ts: 30, dropIndex: &quot;a&quot;&lt;br/&gt;
 If the secondary completes the background index and timestamps the `ready: true` write at ts: 20, rolling back to 25 will show a `ready: true` index, but no underlying table because it was dropped. (edited)&lt;br/&gt;
 &quot;&lt;/p&gt;

&lt;p&gt;Note: A good way to test that those code paths are inactive might be to add some invariants that they never occur anymore and run a full evergreen patch.&lt;/p&gt;</description>
                <environment></environment>
        <key id="668212">SERVER-38910</key>
            <summary>Remove redundant rollback handling on index drops</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="dianna.hohensee@mongodb.com">Dianna Hohensee</assignee>
                                    <reporter username="dianna.hohensee@mongodb.com">Dianna Hohensee</reporter>
                        <labels>
                            <label>techdebt</label>
                    </labels>
                <created>Wed, 9 Jan 2019 15:42:13 +0000</created>
                <updated>Sun, 29 Oct 2023 22:25:17 +0000</updated>
                            <resolved>Tue, 9 Feb 2021 03:27:47 +0000</resolved>
                                                    <fixVersion>4.9.0</fixVersion>
                                    <component>Storage</component>
                                        <votes>0</votes>
                                    <watches>3</watches>
                                                                                                                <comments>
                            <comment id="3606075" author="xgen-internal-githook" created="Tue, 9 Feb 2021 04:17:28 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Dianna Hohensee&apos;, &apos;email&apos;: &apos;dianna.hohensee@mongodb.com&apos;, &apos;username&apos;: &apos;DiannaHohensee&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38910&quot; title=&quot;Remove redundant rollback handling on index drops&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38910&quot;&gt;&lt;del&gt;SERVER-38910&lt;/del&gt;&lt;/a&gt; Remove index drop rollback handling on opening the storage engine.&lt;/p&gt;

&lt;p&gt;This scenario can no longer occur because we wait for index drops to be majority&lt;br/&gt;
committed before dropping the underlying data table.&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/dc96088c84c5411b70caa0c01be000da1a1ae3d1&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/dc96088c84c5411b70caa0c01be000da1a1ae3d1&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3219843" author="dianna.hohensee" created="Tue, 23 Jun 2020 15:53:31 +0000"  >&lt;p&gt;I think this ticket can be tried again.&lt;/p&gt;

&lt;p&gt;It doesn&apos;t look like there&apos;s been anything but logging format changes to the relevant code. I believe the issue described in the CR pertained to the v4.0-&amp;gt;v4.2 upgrade path, where v4.0 didn&apos;t have two-phase index drop: this would no longer be a problem for v4.4-&amp;gt;v4.6, since we&apos;ve had two-phase drop since v4.2 (I think). Some extra testing might not go amiss, but I&apos;m not sure whether it would be worth the trouble to test or not.&lt;/p&gt;</comment>
                            <comment id="2123759" author="dianna.hohensee" created="Wed, 23 Jan 2019 04:12:45 +0000"  >&lt;p&gt;Found that it is FCV dependent whether the code can be removed.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                            <outwardlinks description="depends on">
                                        <issuelink>
            <issuekey id="493826">SERVER-33161</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="619130">SERVER-37637</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="650033">SERVER-38548</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="1655268">SERVER-55397</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="629882">SERVER-37966</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="657949">SERVER-38702</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 27 Apr 2020 18:36:33 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        3 years, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[<s><a href='https://jira.mongodb.org/browse/SERVER-33161'>SERVER-33161</a></s>]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-1869</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            3 years, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_16465" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Linked BF Score</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>137.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>dianna.hohensee@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|huimk7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr42rb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="2708">Storage NYC 2019-01-14</customfieldvalue>
    <customfieldvalue id="4553">Execution Team 2021-02-22</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hui8tj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>