<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 03:04:41 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-4007] The edit() function (command) in shell/dbShell.cpp could index off the end of a string</title>
                <link>https://jira.mongodb.org/browse/SERVER-4007</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;The code in the new &apos;edit&apos; command in the shell uses the .data() member of &amp;lt;basic_string&amp;gt; (i.e. &amp;lt;string&amp;gt;) but then tests for NUL to end the string.  The code should use .c_str() instead, which does NUL terminate.  This is probably not a real-world error because real implementations of &amp;lt;string&amp;gt; seem to store strings NUL-terminated anyway.&lt;/p&gt;

&lt;p&gt;#ifndef _WIN32&lt;br/&gt;
static void edit(const string&amp;amp; var){&lt;br/&gt;
    static const char * editor = getenv(&quot;EDITOR&quot;);&lt;br/&gt;
    if (!editor) &lt;/p&gt;
{
        cout &amp;lt;&amp;lt; &quot;please define the EDITOR environment variable&quot; &amp;lt;&amp;lt; endl;
        return;
    }

&lt;p&gt;    for (const char* p=var.data(); *p ; p++){ // should use c_str() instead of data()&lt;br/&gt;
        if (! (isalnum(*p) || *p == &apos;_&apos; || *p == &apos;.&apos;))&lt;/p&gt;
{
            cout &amp;lt;&amp;lt; &quot;can only edit variable or property&quot; &amp;lt;&amp;lt; endl;
            return;
        }
&lt;p&gt;    }&lt;/p&gt;
</description>
                <environment>Any</environment>
        <key id="23190">SERVER-4007</key>
            <summary>The edit() function (command) in shell/dbShell.cpp could index off the end of a string</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="eliot">Eliot Horowitz</assignee>
                                    <reporter username="tad">Tad Marshall</reporter>
                        <labels>
                    </labels>
                <created>Tue, 4 Oct 2011 07:25:39 +0000</created>
                <updated>Mon, 11 Jul 2016 18:34:46 +0000</updated>
                            <resolved>Sat, 15 Oct 2011 05:23:03 +0000</resolved>
                                                    <fixVersion>2.1.0</fixVersion>
                                    <component>Shell</component>
                                        <votes>0</votes>
                                    <watches>0</watches>
                                                                                                                <comments>
                            <comment id="60632" author="auto" created="Sat, 15 Oct 2011 05:23:02 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;login&apos;: u&apos;erh&apos;, u&apos;name&apos;: u&apos;Eliot&apos;, u&apos;email&apos;: u&apos;eliot@10gen.com&apos;}
&lt;p&gt;Message: Merge pull request #114 from tadmarshall/&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-4007&quot; title=&quot;The edit() function (command) in shell/dbShell.cpp could index off the end of a string&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-4007&quot;&gt;&lt;del&gt;SERVER-4007&lt;/del&gt;&lt;/a&gt;-reissue&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-4007&quot; title=&quot;The edit() function (command) in shell/dbShell.cpp could index off the end of a string&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-4007&quot;&gt;&lt;del&gt;SERVER-4007&lt;/del&gt;&lt;/a&gt; (reissue) &amp;#8211; use .c_str() instead of .data()&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/feabf3ca0a5487e5950112fa09858d7e87b50975&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/feabf3ca0a5487e5950112fa09858d7e87b50975&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="60631" author="auto" created="Sat, 15 Oct 2011 05:23:00 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{u&apos;login&apos;: u&apos;erh&apos;, u&apos;name&apos;: u&apos;Eliot&apos;, u&apos;email&apos;: u&apos;eliot@10gen.com&apos;}
&lt;p&gt;Message: Merge pull request #114 from tadmarshall/&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-4007&quot; title=&quot;The edit() function (command) in shell/dbShell.cpp could index off the end of a string&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-4007&quot;&gt;&lt;del&gt;SERVER-4007&lt;/del&gt;&lt;/a&gt;-reissue&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-4007&quot; title=&quot;The edit() function (command) in shell/dbShell.cpp could index off the end of a string&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-4007&quot;&gt;&lt;del&gt;SERVER-4007&lt;/del&gt;&lt;/a&gt; (reissue) &amp;#8211; use .c_str() instead of .data()&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/feabf3ca0a5487e5950112fa09858d7e87b50975&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/feabf3ca0a5487e5950112fa09858d7e87b50975&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="60166" author="tad" created="Thu, 13 Oct 2011 01:37:43 +0000"  >&lt;p&gt;I closed pull request 101 and opened &lt;a href=&quot;https://github.com/mongodb/mongo/pull/114&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/pull/114&lt;/a&gt; to replace it.&lt;br/&gt;
Same fix, but without the unrelated commits.&lt;/p&gt;</comment>
                            <comment id="58977" author="tad" created="Thu, 6 Oct 2011 22:31:12 +0000"  >&lt;p&gt;Pull request &lt;a href=&quot;https://github.com/mongodb/mongo/pull/101&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/pull/101&lt;/a&gt; addresses this.&lt;/p&gt;</comment>
                            <comment id="58306" author="tad" created="Tue, 4 Oct 2011 08:03:55 +0000"  >&lt;p&gt;A question on stackoverflow addresses the difference between std::string.data() and std::string.c_str().  In the responses it is shown that MSVC (at least) internally calls c_str() from data() and that the new C++11 standard requires this behavior.  So the ISO 2003 TR1 spec hasn&apos;t matched reality for while.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;http://stackoverflow.com/questions/1534399/whats-the-difference-between-stdstringc-str-and-stdstringdata&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://stackoverflow.com/questions/1534399/whats-the-difference-between-stdstringc-str-and-stdstringdata&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;So, it&apos;s only a bug in the technical sense, no user impact.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Sat, 15 Oct 2011 05:23:00 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        12 years, 18 weeks, 4 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ramon.fernandez@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            12 years, 18 weeks, 4 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10000" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Old_Backport</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10000"><![CDATA[No]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>auto</customfieldvalue>
            <customfieldvalue>eliot</customfieldvalue>
            <customfieldvalue>tad</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hroovj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hrgenr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9284</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|ht0mvr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>