<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:02:11 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-43069] Ops that are slow to apply don&apos;t condition on slowOpSampleRate</title>
                <link>https://jira.mongodb.org/browse/SERVER-43069</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;Here&apos;s the code in question: &lt;a href=&quot;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/repl/sync_tail.cpp#L335-L351&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/repl/sync_tail.cpp#L335-L351&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;That should be doing something similar to &lt;a href=&quot;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/ops/write_ops_exec.cpp#L122-L124&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/ops/write_ops_exec.cpp#L122-L124&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;This behaviour is called out in &lt;a href=&quot;https://docs.mongodb.com/manual/release-notes/4.2/#slow-oplog&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://docs.mongodb.com/manual/release-notes/4.2/#slow-oplog&lt;/a&gt;, though I don&apos;t see any discussion on &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-32146&quot; title=&quot;Log slow oplog entry application&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-32146&quot;&gt;&lt;del&gt;SERVER-32146&lt;/del&gt;&lt;/a&gt; or &lt;a href=&quot;https://jira.mongodb.org/browse/DOCS-12178&quot; title=&quot;Docs for SERVER-32146: Log slow oplog entry application&quot; class=&quot;issue-link&quot; data-issue-key=&quot;DOCS-12178&quot;&gt;&lt;del&gt;DOCS-12178&lt;/del&gt;&lt;/a&gt; for whether sampling was considered.&lt;/p&gt;

&lt;p&gt;There&apos;s also a couple other places where this might need to be checked:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;&lt;a href=&quot;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/commands/eval.cpp#L131&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/commands/eval.cpp#L131&lt;/a&gt;&lt;/li&gt;
	&lt;li&gt;&lt;a href=&quot;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/s/split_vector.cpp#L263&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/blob/r3.6.14/src/mongo/db/s/split_vector.cpp#L263&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;It&apos;s possible a better fix would be to decouple &lt;tt&gt;slowOpSampleRate&lt;/tt&gt; and &lt;tt&gt;slowms&lt;/tt&gt;, such that you log all slow operations but then subject non-slow ops to sampling.&lt;/p&gt;</description>
                <environment></environment>
        <key id="910403">SERVER-43069</key>
            <summary>Ops that are slow to apply don&apos;t condition on slowOpSampleRate</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="xuerui.fa@mongodb.com">Xuerui Fa</assignee>
                                    <reporter username="bartle">David Bartley</reporter>
                        <labels>
                            <label>former-quick-wins</label>
                            <label>neweng</label>
                    </labels>
                <created>Wed, 28 Aug 2019 19:18:17 +0000</created>
                <updated>Sun, 29 Oct 2023 22:17:37 +0000</updated>
                            <resolved>Fri, 7 Feb 2020 23:00:13 +0000</resolved>
                                    <version>3.6.14</version>
                    <version>4.0.12</version>
                    <version>4.2.0</version>
                                    <fixVersion>4.3.4</fixVersion>
                                                        <votes>0</votes>
                                    <watches>12</watches>
                                                                                                                <comments>
                            <comment id="2843595" author="xgen-internal-githook" created="Fri, 7 Feb 2020 22:53:42 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;username&apos;: &apos;XueruiFa&apos;, &apos;name&apos;: &apos;Xuerui Fa&apos;, &apos;email&apos;: &apos;xuerui.fa@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-43069&quot; title=&quot;Ops that are slow to apply don&amp;#39;t condition on slowOpSampleRate&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-43069&quot;&gt;&lt;del&gt;SERVER-43069&lt;/del&gt;&lt;/a&gt;: Condition logging for slow ops on sample rate&lt;/p&gt;

&lt;p&gt; create mode 100644 src/mongo/util/log_with_sampling.h&lt;br/&gt;
 create mode 100644 src/mongo/util/log_with_sampling_test.cpp&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/fd1e712a1407181e1105b4767205a42bbf463bbd&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/fd1e712a1407181e1105b4767205a42bbf463bbd&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2837988" author="xgen-internal-githook" created="Fri, 7 Feb 2020 15:19:43 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Xuerui Fa&apos;, &apos;username&apos;: &apos;XueruiFa&apos;, &apos;email&apos;: &apos;xuerui.fa@mongodb.com&apos;}
&lt;p&gt;Message: Revert &quot;&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-43069&quot; title=&quot;Ops that are slow to apply don&amp;#39;t condition on slowOpSampleRate&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-43069&quot;&gt;&lt;del&gt;SERVER-43069&lt;/del&gt;&lt;/a&gt;: Condition logging for slow ops on sample rate&quot;&lt;/p&gt;

&lt;p&gt;This reverts commit b0c5c0baa85fba563c80ee416cecc22e9ffbf53a.&lt;/p&gt;

&lt;p&gt; delete mode 100644 src/mongo/util/log_with_sampling.h&lt;br/&gt;
 delete mode 100644 src/mongo/util/log_with_sampling_test.cpp&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/6e049cf9804e1d7147f5dcd6ac11b68f480d088a&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/6e049cf9804e1d7147f5dcd6ac11b68f480d088a&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2786041" author="xgen-internal-githook" created="Wed, 5 Feb 2020 22:41:49 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;username&apos;: &apos;XueruiFa&apos;, &apos;name&apos;: &apos;Xuerui Fa&apos;, &apos;email&apos;: &apos;xuerui.fa@mongodb.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-43069&quot; title=&quot;Ops that are slow to apply don&amp;#39;t condition on slowOpSampleRate&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-43069&quot;&gt;&lt;del&gt;SERVER-43069&lt;/del&gt;&lt;/a&gt;: Condition logging for slow ops on sample rate&lt;/p&gt;

&lt;p&gt; create mode 100644 src/mongo/util/log_with_sampling.h&lt;br/&gt;
 create mode 100644 src/mongo/util/log_with_sampling_test.cpp&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/b0c5c0baa85fba563c80ee416cecc22e9ffbf53a&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/b0c5c0baa85fba563c80ee416cecc22e9ffbf53a&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="2419414" author="judah.schvimer" created="Fri, 13 Sep 2019 13:53:00 +0000"  >&lt;p&gt;Thank you and glad this is no longer causing you pain!&lt;/p&gt;</comment>
                            <comment id="2418819" author="bartle" created="Thu, 12 Sep 2019 21:56:00 +0000"  >&lt;p&gt;It&apos;s not causing us any pain currently because we ended up patching this to honour sample rate.  Without the patch, the main issue is that we would have greatly increased our log volume and associated logging system costs.&lt;/p&gt;</comment>
                            <comment id="2418811" author="judah.schvimer" created="Thu, 12 Sep 2019 21:49:21 +0000"  >&lt;p&gt;Hi &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=bartle&quot; class=&quot;user-hover&quot; rel=&quot;bartle&quot;&gt;bartle&lt;/a&gt;, &lt;/p&gt;

&lt;p&gt;Thank you for bringing this issue to our attention. This is definitely a bug and we would like to fix it. To aid in prioritization, can you please help us understand how much pain this is causing you?&lt;/p&gt;

&lt;p&gt;Thank you,&lt;br/&gt;
Judah&lt;/p&gt;</comment>
                            <comment id="2400511" author="daniel.hatcher" created="Thu, 29 Aug 2019 20:53:37 +0000"  >&lt;p&gt;Thanks for the report. We&apos;ll take a look to determine the best path forward.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="1138748">SERVER-46030</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10320">
                    <name>Documented</name>
                                                                <inwardlinks description="is documented by">
                                        <issuelink>
            <issuekey id="1135098">DOCS-13395</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="1029424">SERVER-44881</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_13552" key="com.go2group.jira.plugin.crm:crm_generic_field">
                        <customfieldname>Case</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[[5002K00000yWs4gQAC]]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Thu, 29 Aug 2019 20:53:37 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        4 years, 5 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_17052" key="com.atlassian.jira.plugin.system.customfieldtypes:textarea">
                        <customfieldname>Downstream Changes Summary</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Conditioned logging for slow operations on the sample rate.&lt;br/&gt;
&lt;br/&gt;
Existing behavior prior to this ticket: &lt;a href=&quot;https://docs.mongodb.com/manual/release-notes/4.2/#slow-oplog&quot;&gt;https://docs.mongodb.com/manual/release-notes/4.2/#slow-oplog&lt;/a&gt;&lt;br/&gt;
</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16942"><![CDATA[Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-1664</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            4 years, 5 days ago
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_16465" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Linked BF Score</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>39.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>daniel.hatcher@mongodb.com</customfieldvalue>
            <customfieldvalue>bartle</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>judah.schvimer@mongodb.com</customfieldvalue>
            <customfieldvalue>xuerui.fa@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hvng13:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr6sif:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="3575">Repl 2020-02-10</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_17051" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Teams Impacted</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16944"><![CDATA[Docs]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hvn2af:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>