<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:15:16 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-47796] commit-queue lint-clang-format not run on enterprise changes</title>
                <link>https://jira.mongodb.org/browse/SERVER-47796</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;I have the same issue as &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-45586&quot; title=&quot;The enterprise module is not linted in patch builds&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-45586&quot;&gt;&lt;del&gt;SERVER-45586&lt;/del&gt;&lt;/a&gt; I think.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/EVG-7894&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://jira.mongodb.org/browse/EVG-7894&lt;/a&gt; It looks to me like maybe the commit-queue CI might not include Enterprise module changes in the lint-clang-format task, the way that the master waterfall CI does. I submitted a change that got through with format errors in enterprise code, only to break the master waterfall and generate a BFG. &lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/BFG-599619&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://jira.mongodb.org/browse/BFG-599619&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;My commit-queue CI run&apos;s lint-clang-format task doesn&apos;t look like it made a patch from the enterprise module change.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://evergreen.mongodb.com/task_log_raw/mongodb_mongo_master_enterprise_rhel_62_64_bit_lint_clang_format_patch_085ffeb310e8fed49739cf8443fcb13ea795d867_5ea60ada306615619458e984_20_04_26_22_29_05/0?type=T#L1035&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://evergreen.mongodb.com/task_log_raw/mongodb_mongo_master_enterprise_rhel_62_64_bit_lint_clang_format_patch_085ffeb310e8fed49739cf8443fcb13ea795d867_5ea60ada306615619458e984_20_04_26_22_29_05/0?type=T#L1035&lt;/a&gt;&lt;/p&gt;
</description>
                <environment></environment>
        <key id="1330026">SERVER-47796</key>
            <summary>commit-queue lint-clang-format not run on enterprise changes</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="david.bradford@mongodb.com">David Bradford</assignee>
                                    <reporter username="billy.donahue@mongodb.com">Billy Donahue</reporter>
                        <labels>
                    </labels>
                <created>Mon, 27 Apr 2020 15:04:38 +0000</created>
                <updated>Sun, 29 Oct 2023 22:09:00 +0000</updated>
                            <resolved>Wed, 6 May 2020 13:25:35 +0000</resolved>
                                                    <fixVersion>4.4.0-rc4</fixVersion>
                    <fixVersion>4.7.0</fixVersion>
                                    <component>Testing Infrastructure</component>
                                        <votes>0</votes>
                                    <watches>1</watches>
                                                                                                                <comments>
                            <comment id="3071622" author="xgen-internal-githook" created="Wed, 6 May 2020 13:35:50 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;David Bradford&apos;, &apos;email&apos;: &apos;david.bradford@mongodb.com&apos;, &apos;username&apos;: &apos;dbradf&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-47796&quot; title=&quot;commit-queue lint-clang-format not run on enterprise changes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-47796&quot;&gt;&lt;del&gt;SERVER-47796&lt;/del&gt;&lt;/a&gt;: Ensure linters run against enterprise modules&lt;/p&gt;

&lt;p&gt;(cherry picked from commit 74ea6aa4dfd7b3b4acf090084d36891834a49385)&lt;br/&gt;
Branch: v4.4&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/1dc60902170fe8d69d50b32220b254ad681dfcf2&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/1dc60902170fe8d69d50b32220b254ad681dfcf2&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3071584" author="xgen-internal-githook" created="Wed, 6 May 2020 13:13:06 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;David Bradford&apos;, &apos;email&apos;: &apos;david.bradford@mongodb.com&apos;, &apos;username&apos;: &apos;dbradf&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-47796&quot; title=&quot;commit-queue lint-clang-format not run on enterprise changes&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-47796&quot;&gt;&lt;del&gt;SERVER-47796&lt;/del&gt;&lt;/a&gt;: Ensure linters run against enterprise modules&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/74ea6aa4dfd7b3b4acf090084d36891834a49385&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/74ea6aa4dfd7b3b4acf090084d36891834a49385&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3056718" author="billy.donahue" created="Mon, 27 Apr 2020 15:50:34 +0000"  >
&lt;p&gt;(I had already written this up as an EVG ticket EVG-7894).&lt;br/&gt;
I&apos;m gonna close it and paste its description here to avoid having too many places to look for information.&lt;/p&gt;

&lt;p&gt;I just submitted via commit-queue a change that had mongo and enterprise components. This is &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-47735&quot; title=&quot;Convert all code to use `logv2` headers and names&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-47735&quot;&gt;&lt;del&gt;SERVER-47735&lt;/del&gt;&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;The first enterprise change I submitted wasn&apos;t updated with my clang-format run by mistake, so it broke the clang-format linter (@ 2020-04-26T23:07:10Z). generating BFG-599619 ticket (@ 2020-04-26T23:15:06) which I fixed immediately with a follow-on change via commit-queue (@ 2020-04-27T00:18:54Z). As of this writing (@ 2020-04-27T05:13:00Z), the master waterfall still hasn&apos;t been updated to show this fix. It looks like enterprise changes, even via commit queue, don&apos;t cause a CI run.&lt;/p&gt;

&lt;p&gt;The bigger problem is that the commit queue let this in. I see that the commit-queue runs a lint_clang_format task, but my commit-queue tasks all passed even though the enterprise component wasn&apos;t clang-format-compliant. So the commit-queue CI run doesn&apos;t check for errors in the enterprise module the way the waterfall CI run does. They should logically be the same checks.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10010">
                    <name>Duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                                        </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>3.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="18953"><![CDATA[v4.4]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 29 Apr 2020 19:57:24 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        3 years, 40 weeks ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            3 years, 40 weeks ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>billy.donahue@mongodb.com</customfieldvalue>
            <customfieldvalue>david.bradford@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxhuqf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hx58t3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="3595">DAG 2020-05-04</customfieldvalue>
    <customfieldvalue id="3844">DAG 2020-05-18</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10555" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxhgzr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>