<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:15:19 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-47817] Remove resetError command</title>
                <link>https://jira.mongodb.org/browse/SERVER-47817</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description></description>
                <environment></environment>
        <key id="1331342">SERVER-47817</key>
            <summary>Remove resetError command</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="alexandre.bique@mongodb.com">Alexandre Bique</assignee>
                                    <reporter username="blake.oler@mongodb.com">Blake Oler</reporter>
                        <labels>
                            <label>sharding-wfbf-day</label>
                    </labels>
                <created>Tue, 28 Apr 2020 13:53:44 +0000</created>
                <updated>Sun, 29 Oct 2023 22:08:57 +0000</updated>
                            <resolved>Thu, 28 Jan 2021 14:48:04 +0000</resolved>
                                                    <fixVersion>5.0.0</fixVersion>
                                    <component>Sharding</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="3587109" author="xgen-internal-githook" created="Thu, 28 Jan 2021 14:45:10 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Alexandre Bique&apos;, &apos;email&apos;: &apos;alexandre.bique@mongodb.com&apos;, &apos;username&apos;: &apos;abique&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-47817&quot; title=&quot;Remove resetError command&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-47817&quot;&gt;&lt;del&gt;SERVER-47817&lt;/del&gt;&lt;/a&gt; Remove resetError command&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/e74759918118887469fe1657bb90e415f5640456&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/e74759918118887469fe1657bb90e415f5640456&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3579788" author="JIRAUSER1258246" created="Mon, 25 Jan 2021 09:26:37 +0000"  >&lt;p&gt;I had a look, I&apos;ve adapted the tests, and scheduled a build: &lt;a href=&quot;https://spruce.mongodb.com/version/600e8dfe3e8e8657600b7cc5/tasks&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://spruce.mongodb.com/version/600e8dfe3e8e8657600b7cc5/tasks&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3579731" author="JIRAUSER1258246" created="Mon, 25 Jan 2021 07:54:34 +0000"  >&lt;p&gt;Sure I can take an second look.&lt;br/&gt;
Out of curiosity, why didn&apos;t we deprecate getLastError() as well? Is it the plan to keep it around forever?&lt;/p&gt;</comment>
                            <comment id="3579707" author="JIRAUSER1256927" created="Mon, 25 Jan 2021 07:16:34 +0000"  >&lt;p&gt;Hi &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=blake.oler&quot; class=&quot;user-hover&quot; rel=&quot;blake.oler&quot;&gt;blake.oler&lt;/a&gt; ,&lt;/p&gt;

&lt;p&gt;Thanks for the context! Now I understand what we misunderstood: we thought that the only way to reset an error was through the &lt;tt&gt;resetError&lt;/tt&gt; command, but in fact the error is refreshed after each write operation. That&apos;s the reason why we didn&apos;t understand how we could remove &lt;tt&gt;resetError&lt;/tt&gt; but keep &lt;tt&gt;getLastError&lt;/tt&gt;. Now everything is clear, thanks again!&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=alexandre.bique&quot; class=&quot;user-hover&quot; rel=&quot;alexandre.bique&quot;&gt;alexandre.bique&lt;/a&gt; Can you take a look at the jstests that use &lt;tt&gt;resetError&lt;/tt&gt;? I remember &lt;a href=&quot;https://github.com/mongodb/mongo/blob/master/jstests/gle/core/error1.js&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;this one&lt;/a&gt;.&lt;/p&gt;</comment>
                            <comment id="3578661" author="blake.oler" created="Fri, 22 Jan 2021 20:46:54 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=alexandre.bique&quot; class=&quot;user-hover&quot; rel=&quot;alexandre.bique&quot;&gt;alexandre.bique&lt;/a&gt; The work you&apos;ve done so far on the ticket is exactly what I was expecting! Good job.&lt;/p&gt;

&lt;p&gt;To dig in a bit into the context, &lt;/p&gt;

&lt;p&gt;&lt;tt&gt;getLastError&lt;/tt&gt; is still used by very old drivers to send writes as OP_INSERT, OP_UPDATE, and OP_DELETE in order to wait for write concern. Accordingly, we need to keep around &lt;tt&gt;getLastError&lt;/tt&gt;. These uses of &lt;tt&gt;getLastError&lt;/tt&gt;, however, don&apos;t necessitate &lt;tt&gt;resetError&lt;/tt&gt;. &lt;tt&gt;resetError&lt;/tt&gt; itself has been deprecated since MongoDB 1.6, which is more than a decade old. The removal of &lt;tt&gt;resetError&lt;/tt&gt; was specifically requested by Andy Schwerin during the scope review for PM-1824.&lt;/p&gt;

&lt;p&gt;In accordance, removing &lt;tt&gt;resetError&lt;/tt&gt; itself has been approved by multiple major stakeholders across server, cloud, and drivers.&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=alexandre.bique&quot; class=&quot;user-hover&quot; rel=&quot;alexandre.bique&quot;&gt;alexandre.bique&lt;/a&gt;, &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=sergi.mateo-bellido&quot; class=&quot;user-hover&quot; rel=&quot;sergi.mateo-bellido&quot;&gt;sergi.mateo-bellido&lt;/a&gt;, what is the core conclusion from your investigation? If it&apos;s that we needed to remove &lt;tt&gt;getLastError&lt;/tt&gt; too, then it&apos;s fine for you to pick back up and only remove &lt;tt&gt;resetError&lt;/tt&gt;. If the issue is that the work involved simply takes too long, then we can story-point the ticket and place it into a sprint. &lt;/p&gt;
</comment>
                            <comment id="3577342" author="JIRAUSER1258246" created="Fri, 22 Jan 2021 10:49:00 +0000"  >&lt;p&gt;Code review with the changes I had: &lt;a href=&quot;https://mongodbcr.appspot.com/756210048&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://mongodbcr.appspot.com/756210048&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3577328" author="JIRAUSER1258246" created="Fri, 22 Jan 2021 10:37:50 +0000"  >&lt;p&gt;Hi &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=blake.oler&quot; class=&quot;user-hover&quot; rel=&quot;blake.oler&quot;&gt;blake.oler&lt;/a&gt; ,&lt;/p&gt;

&lt;p&gt;I&apos;ve investigated the issue with &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=sergi.mateo-bellido&quot; class=&quot;user-hover&quot; rel=&quot;sergi.mateo-bellido&quot;&gt;sergi.mateo-bellido&lt;/a&gt;. We&apos;ve found that:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;resetError isn&apos;t a no-op, it resets the error that one can retrieve using getLastError&lt;/li&gt;
	&lt;li&gt;we believe that getLastError should be removed together with resetError&lt;/li&gt;
	&lt;li&gt;we believe that some additionnal infrastructure in the C++ codebase related to getLastError should be removed, which might imply some more refactoring including error handling&lt;/li&gt;
	&lt;li&gt;many tests are to be reworked and we should ensure that the error testing is properly done.&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;To conclude the scope of this ticket seems much wider.&lt;/p&gt;

&lt;p&gt;I&apos;ve submitted this patch: &lt;a href=&quot;https://spruce.mongodb.com/version/6009a4ae32f417231ddf7238/tasks&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://spruce.mongodb.com/version/6009a4ae32f417231ddf7238/tasks&lt;/a&gt; which does not pass the tests.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                                        </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10320">
                    <name>Documented</name>
                                                                <inwardlinks description="is documented by">
                                        <issuelink>
            <issuekey id="1603287">DOCS-14163</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10520">
                    <name>Problem/Incident</name>
                                            <outwardlinks description="causes">
                                        <issuelink>
            <issuekey id="1609692">PYTHON-2540</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10011"><![CDATA[Minor Change]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 22 Jan 2021 10:37:50 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        3 years, 1 week, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_17052" key="com.atlassian.jira.plugin.system.customfieldtypes:textarea">
                        <customfieldname>Downstream Changes Summary</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>resetError command is removed</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16942"><![CDATA[Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-1860</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            3 years, 1 week, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>alexandre.bique@mongodb.com</customfieldvalue>
            <customfieldvalue>blake.oler@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>sergi.mateo-bellido@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxi2tr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hx5gt3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4483">Sharding 2021-01-25</customfieldvalue>
    <customfieldvalue id="4484">Sharding 2021-02-08</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10555" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_17051" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Teams Impacted</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16944"><![CDATA[Docs]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxhp33:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>