<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:19:18 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-49229] use-after-move: &apos;options&apos; argument in StorageEngineImpl constructor</title>
                <link>https://jira.mongodb.org/browse/SERVER-49229</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;The &lt;a href=&quot;https://github.com/mongodb/mongo/blob/55ebe85fc937c787fb5a5d8793f8df39dc67e105/src/mongo/db/storage/storage_engine_impl.cpp#L81&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;uassert check&lt;/a&gt; in the StorageEngineImpl constructor reads the moved &apos;options&apos; variable. This seems to be a violation of the &lt;a href=&quot;https://clang.llvm.org/extra/clang-tidy/checks/bugprone-use-after-move.html&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;use-after-move&lt;/a&gt; rule in C++.&lt;/p&gt;

&lt;p&gt;This check is only relevant to storage engines without --directoryperdb support.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1398773">SERVER-49229</key>
            <summary>use-after-move: &apos;options&apos; argument in StorageEngineImpl constructor</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.mongodb.org/images/icons/priorities/minor.svg">Minor - P4</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="bynn.lee@mongodb.com">Bynn Lee</assignee>
                                    <reporter username="benety.goh@mongodb.com">Benety Goh</reporter>
                        <labels>
                            <label>neweng</label>
                    </labels>
                <created>Wed, 1 Jul 2020 15:10:02 +0000</created>
                <updated>Sun, 29 Oct 2023 22:06:14 +0000</updated>
                            <resolved>Wed, 22 Jul 2020 18:21:13 +0000</resolved>
                                                    <fixVersion>4.7.0</fixVersion>
                                    <component>Storage</component>
                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="3297204" author="acm" created="Wed, 22 Jul 2020 18:04:36 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=benety.goh&quot; class=&quot;user-hover&quot; rel=&quot;benety.goh&quot;&gt;benety.goh&lt;/a&gt;, yes, of course.&lt;/p&gt;</comment>
                            <comment id="3297201" author="xgen-internal-githook" created="Wed, 22 Jul 2020 18:03:48 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Bynn Lee&apos;, &apos;email&apos;: &apos;bynn.lee@mongodb.com&apos;, &apos;username&apos;: &apos;bynn&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-49229&quot; title=&quot;use-after-move: &amp;#39;options&amp;#39; argument in StorageEngineImpl constructor&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-49229&quot;&gt;&lt;del&gt;SERVER-49229&lt;/del&gt;&lt;/a&gt; use-after-move: &apos;options&apos; argument in StorageEngineImpl constructor&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/db78b73d0b1cda09831163e9283e7ff5adf90fa7&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/db78b73d0b1cda09831163e9283e7ff5adf90fa7&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3296742" author="benety.goh" created="Wed, 22 Jul 2020 15:30:53 +0000"  >&lt;p&gt;We tried running patch build a week ago before assigning this ticket and found numerous violations of the clan-tidy rule. We&apos;ll include the link to the patch build in a separate comment.&lt;/p&gt;</comment>
                            <comment id="3296704" author="acm" created="Wed, 22 Jul 2020 15:21:05 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=benety.goh&quot; class=&quot;user-hover&quot; rel=&quot;benety.goh&quot;&gt;benety.goh&lt;/a&gt; - You had mentioned above that you would prefer not to enable the clang-tidy check as part of this ticket but instead to file a new ticket, so I think we should file that. On the other hand, it might be trivial to try to patch build adding the new check once the above CR lands? If it patch builds green, you could just commit it right away. If it doesn&apos;t patch build green, you could look at where the errors are reported and that might indicate a team who should pick up the ball. Overall, I want the set of checks to be something that we view has having common ownership: if a bug is found, and clang-tidy could have caught it, I&apos;d prefer that the work to resolve the defect include eliminating remaining instances of that detectable defect along with locking in detection by enabling the new check. Otherwise, it will only be the SDP team trying to move this forward, and that won&apos;t scale.&lt;/p&gt;</comment>
                            <comment id="3268155" author="acm" created="Thu, 2 Jul 2020 12:18:27 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=benety.goh&quot; class=&quot;user-hover&quot; rel=&quot;benety.goh&quot;&gt;benety.goh&lt;/a&gt; - Fine by me to do it under a different ticket if there is a reasonable path to actually getting it done promptly. I was very excited that we got &lt;tt&gt;clang-tidy&lt;/tt&gt; stood up in CI under &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-27984&quot; title=&quot;Add clang-tidy run in addition to lint&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-27984&quot;&gt;&lt;del&gt;SERVER-27984&lt;/del&gt;&lt;/a&gt;, and it had been my fervent hope that teams would of their own initiative expand the set of checks as bugs like this one were found. So far that has not been the case, and we are currently spending several hours looking only for &lt;tt&gt;bugprone-unused-raii&lt;/tt&gt;.&lt;/p&gt;</comment>
                            <comment id="3263117" author="benety.goh" created="Wed, 1 Jul 2020 16:36:14 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=acm&quot; class=&quot;user-hover&quot; rel=&quot;acm&quot;&gt;acm&lt;/a&gt;, I&apos;m in favor of adding this to the list of checks in &lt;tt&gt;clang-tidy&lt;/tt&gt; in a separate SERVER ticket.&lt;/p&gt;</comment>
                            <comment id="3261845" author="acm" created="Wed, 1 Jul 2020 15:26:58 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=benety.goh&quot; class=&quot;user-hover&quot; rel=&quot;benety.goh&quot;&gt;benety.goh&lt;/a&gt; - Our toolchain &lt;tt&gt;clang-tidy&lt;/tt&gt; has an explicit checker for this error:&lt;/p&gt;

&lt;p/&gt;
&lt;div id=&quot;syntaxplugin&quot; class=&quot;syntaxplugin&quot; style=&quot;border: 1px dashed #bbb; border-radius: 5px !important; overflow: auto; max-height: 30em;&quot;&gt;
&lt;table cellspacing=&quot;0&quot; cellpadding=&quot;0&quot; border=&quot;0&quot; width=&quot;100%&quot; style=&quot;font-size: 1em; line-height: 1.4em !important; font-weight: normal; font-style: normal; color: black;&quot;&gt;
		&lt;tbody &gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;  margin-top: 10px;   width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;$ /opt/mongodbtoolchain/v3/bin/clang-tidy -checks=* -list-checks | grep use-after-move&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
				&lt;tr id=&quot;syntaxplugin_code_and_gutter&quot;&gt;
						&lt;td  style=&quot; line-height: 1.4em !important; padding: 0em; vertical-align: top;&quot;&gt;
					&lt;pre style=&quot;font-size: 1em; margin: 0 10px;   margin-bottom: 10px;  width: auto; padding: 0;&quot;&gt;&lt;span style=&quot;color: black; font-family: &apos;Consolas&apos;, &apos;Bitstream Vera Sans Mono&apos;, &apos;Courier New&apos;, Courier, monospace !important;&quot;&gt;    bugprone-use-after-move&lt;/span&gt;&lt;/pre&gt;
			&lt;/td&gt;
		&lt;/tr&gt;
			&lt;/tbody&gt;
&lt;/table&gt;
&lt;/div&gt;
&lt;p/&gt;

&lt;p&gt;Perhaps, rather than just making the limited change to fix this one instance, it would be worthwhile to expand the &lt;a href=&quot;https://github.com/mongodb/mongo/blob/9f4b81e5bdcf38f9b10459203a804ba406528770/etc/evergreen.yml#L3957&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;list of checks&lt;/a&gt; to include this, and see if 1) &lt;tt&gt;clang-tidy&lt;/tt&gt; would have caught this bug and 2) if so, whether there are other instances that should be repaired. Doing so would allow us to permanently add that check to our &lt;tt&gt;clang-tidy&lt;/tt&gt; pass in CI.&lt;/p&gt;</comment>
                            <comment id="3261745" author="benety.goh" created="Wed, 1 Jul 2020 15:15:04 +0000"  >&lt;p&gt;This issue was introduced in &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-38600&quot; title=&quot;restarting the catalog should leave drop-pending idents intact&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-38600&quot;&gt;&lt;del&gt;SERVER-38600&lt;/del&gt;&lt;/a&gt; when we started to initialize the &lt;a href=&quot;https://github.com/mongodb/mongo/commit/ffb3c503fb1c564097f4e814ede8af26796339e5#diff-59b4542e56d14e2de8d3b0200f93f63eR88&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;_options member variable using a move&lt;/a&gt; rather than a copy.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="1417175">SERVER-49800</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="653001">SERVER-38600</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>8.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Wed, 1 Jul 2020 15:26:58 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        3 years, 29 weeks ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            3 years, 29 weeks ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>andrew.morrow@mongodb.com</customfieldvalue>
            <customfieldvalue>benety.goh@mongodb.com</customfieldvalue>
            <customfieldvalue>bynn.lee@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxt0zr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hxggaf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="3940">Execution Team 2020-07-27</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxsn93:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>