<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:19:34 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-49336] Set client metadata if it is missing during failCommand</title>
                <link>https://jira.mongodb.org/browse/SERVER-49336</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;We set the &lt;tt&gt;ClientIsMasterMetadataState&lt;/tt&gt; with appName &lt;a href=&quot;https://github.com/mongodb/mongo/blob/f39585101d93f47c216ea8c30e276ac0410c30a2/src/mongo/db/repl/replication_info.cpp#L273-L295&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;here&lt;/a&gt;. Unfortunately, that happens after we evaluate failCommand &lt;a href=&quot;https://github.com/mongodb/mongo/blob/f39585101d93f47c216ea8c30e276ac0410c30a2/src/mongo/db/service_entry_point_common.cpp#L942&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;here&lt;/a&gt;, so the first isMaster cannot have appName filters be applied to it.&lt;/p&gt;

&lt;p&gt;The full solution is most likely to separate &lt;tt&gt;parse()&lt;/tt&gt; from &lt;tt&gt;run()&lt;/tt&gt; for isMaster. However, that is potentially disruptive to backport. The less intrusive answer is to separate the functionality that sets the metadata into its own function. We can then invoke that function in failCommand if we don&apos;t have client metadata.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1402983">SERVER-49336</key>
            <summary>Set client metadata if it is missing during failCommand</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="ben.caimano@mongodb.com">Benjamin Caimano</assignee>
                                    <reporter username="ben.caimano@mongodb.com">Benjamin Caimano</reporter>
                        <labels>
                    </labels>
                <created>Tue, 7 Jul 2020 16:50:17 +0000</created>
                <updated>Sun, 29 Oct 2023 22:06:06 +0000</updated>
                            <resolved>Thu, 15 Oct 2020 17:46:39 +0000</resolved>
                                                    <fixVersion>4.9.0</fixVersion>
                    <fixVersion>4.2.15</fixVersion>
                    <fixVersion>4.4.7</fixVersion>
                                                        <votes>0</votes>
                                    <watches>4</watches>
                                                                                                                <comments>
                            <comment id="3770040" author="xgen-internal-githook" created="Wed, 12 May 2021 18:39:09 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;A. Jesse Jiryu Davis&apos;, &apos;email&apos;: &apos;jesse@mongodb.com&apos;, &apos;username&apos;: &apos;ajdavis&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-49336&quot; title=&quot;Set client metadata if it is missing during failCommand&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-49336&quot;&gt;&lt;del&gt;SERVER-49336&lt;/del&gt;&lt;/a&gt; Set ClientMetadata before CommandInvocations are run&lt;br/&gt;
Branch: v4.2&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/a696566eae01ed989738f36e396ef2ec3949728c&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/a696566eae01ed989738f36e396ef2ec3949728c&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3764457" author="xgen-internal-githook" created="Mon, 10 May 2021 17:51:50 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;A. Jesse Jiryu Davis&apos;, &apos;email&apos;: &apos;jesse@mongodb.com&apos;, &apos;username&apos;: &apos;ajdavis&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-49336&quot; title=&quot;Set client metadata if it is missing during failCommand&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-49336&quot;&gt;&lt;del&gt;SERVER-49336&lt;/del&gt;&lt;/a&gt; Set ClientMetadata before CommandInvocations are run&lt;br/&gt;
Branch: v4.4&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/aebce0e3fd8fa0ba88d025c8b8bec3734cd7f10d&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/aebce0e3fd8fa0ba88d025c8b8bec3734cd7f10d&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3599927" author="ben.caimano" created="Thu, 4 Feb 2021 19:09:38 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=shane.harvey&quot; class=&quot;user-hover&quot; rel=&quot;shane.harvey&quot;&gt;shane.harvey&lt;/a&gt;, it&apos;s reasonable to try to backport it. It&apos;s probably not a clean backport though. I&apos;ve requested backports for v4.4 and v4.2 and Service Arch can determine if they want to do them.&lt;/p&gt;</comment>
                            <comment id="3599855" author="shane.harvey" created="Thu, 4 Feb 2021 18:34:10 +0000"  >&lt;p&gt;&lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=ben.caimano&quot; class=&quot;user-hover&quot; rel=&quot;ben.caimano&quot;&gt;ben.caimano&lt;/a&gt; Is this change something we plan to backport to 4.4 and 4.2? The appName feature was backported to 4.2 in &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-47195&quot; title=&quot;Allow failCommand failpoint to trigger only on a specific MongoClient&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-47195&quot;&gt;&lt;del&gt;SERVER-47195&lt;/del&gt;&lt;/a&gt;. &lt;/p&gt;</comment>
                            <comment id="3454958" author="xgen-internal-githook" created="Tue, 20 Oct 2020 18:58:03 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Ben Caimano&apos;, &apos;email&apos;: &apos;ben.caimano@10gen.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-49336&quot; title=&quot;Set client metadata if it is missing during failCommand&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-49336&quot;&gt;&lt;del&gt;SERVER-49336&lt;/del&gt;&lt;/a&gt; Allow ClientMetadata to be accessed before it is finalized&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/77963415a45ac22d3f460c2c4ed8d826c618d719&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/77963415a45ac22d3f460c2c4ed8d826c618d719&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3446697" author="xgen-internal-githook" created="Thu, 15 Oct 2020 17:21:24 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Ben Caimano&apos;, &apos;email&apos;: &apos;ben.caimano@10gen.com&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-49336&quot; title=&quot;Set client metadata if it is missing during failCommand&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-49336&quot;&gt;&lt;del&gt;SERVER-49336&lt;/del&gt;&lt;/a&gt; Set ClientMetadata before CommandInvocations are run&lt;/p&gt;

&lt;p&gt;This patch does the following:&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;Always parses ClientMetadata before command implementations are run.&lt;/li&gt;
	&lt;li&gt;Marks general ClientMetadata as final in the first hello.&lt;/li&gt;
	&lt;li&gt;Removes client_metadata_ismaster.* (&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-50517&quot; title=&quot;Rename ClientMetadataIsMasterState to ClientMetadataHelloState&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-50517&quot;&gt;&lt;del&gt;SERVER-50517&lt;/del&gt;&lt;/a&gt;)&lt;/li&gt;
	&lt;li&gt;Switches references to &quot;isMaster&quot; to &quot;hello&quot; (&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-50517&quot; title=&quot;Rename ClientMetadataIsMasterState to ClientMetadataHelloState&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-50517&quot;&gt;&lt;del&gt;SERVER-50517&lt;/del&gt;&lt;/a&gt;)&lt;/li&gt;
	&lt;li&gt;Binds &quot;$client&quot; metadata as a decoration (&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-50804&quot; title=&quot;Make external (application) client info available for commands on shards and config servers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-50804&quot;&gt;&lt;del&gt;SERVER-50804&lt;/del&gt;&lt;/a&gt;)&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/5a9d2dd204f41b4a02fe83d710f3f38c6092b322&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/5a9d2dd204f41b4a02fe83d710f3f38c6092b322&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="3272758" author="jason.carey" created="Tue, 7 Jul 2020 17:05:16 +0000"  >&lt;p&gt;I&apos;m signing off on this with the less disruptive approach to aid in backports&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10420">
                    <name>Backports</name>
                                            <outwardlinks description="backported by">
                                                        </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                                                <inwardlinks description="is depended on by">
                                        <issuelink>
            <issuekey id="1397346">SERVER-49220</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10010">
                    <name>Duplicate</name>
                                                                <inwardlinks description="is duplicated by">
                                        <issuelink>
            <issuekey id="1383167">SERVER-48932</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="1397346">SERVER-49220</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="1417463">SERVER-49815</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="1466366">SERVER-50804</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10520">
                    <name>Problem/Incident</name>
                                            <outwardlinks description="causes">
                                        <issuelink>
            <issuekey id="1715092">SERVER-56935</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="1451522">SERVER-50517</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="1466366">SERVER-50804</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="1566012">SERVER-53334</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>7.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_12450" key="com.atlassian.jira.plugin.system.customfieldtypes:multicheckboxes">
                        <customfieldname>Backport Requested</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="18953"><![CDATA[v4.4]]></customfieldvalue>
    <customfieldvalue key="16775"><![CDATA[v4.2]]></customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Tue, 7 Jul 2020 17:05:16 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        2 years, 39 weeks ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-1903</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            2 years, 39 weeks ago
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_16465" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Linked BF Score</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>133.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>ben.caimano@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>mira.carey@mongodb.com</customfieldvalue>
            <customfieldvalue>shane.harvey@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxtqmn:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hr56f3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4269">Service arch 2020-10-19</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hxtcvz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>