<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:24:24 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-51061] Rename c preprocessor macro that guards access to invariant.h header.</title>
                <link>https://jira.mongodb.org/browse/SERVER-51061</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;The C preprocessor macro &lt;tt&gt;MONGO_INCLUDE_INVARIANT_H_WHITELISTED&lt;/tt&gt; is used to identify headers that are allowed to directly include the file &lt;tt&gt;src/mongo/util/invariant.h&lt;/tt&gt;. This ticket is to rename the macro to &lt;tt&gt;MONGO_ALLOW_INCLUDE_INVARIANT_H&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;Folding in work from similar small tickets:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-51062&quot; title=&quot;Remove references to unconsulted preprocessor macro MONGO_PCH_WHITELISTED&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-51062&quot;&gt;&lt;del&gt;SERVER-51062&lt;/del&gt;&lt;/a&gt; Remove references to unconsulted preprocessor macro MONGO_PCH_WHITELISTED&lt;/li&gt;
	&lt;li&gt;&lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-51063&quot; title=&quot;Rename C preprocessor macro that guards access to DNS query implementations&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-51063&quot;&gt;&lt;del&gt;SERVER-51063&lt;/del&gt;&lt;/a&gt; Rename C preprocessor macro that guards access to DNS query implementations&lt;/li&gt;
&lt;/ul&gt;
</description>
                <environment></environment>
        <key id="1480367">SERVER-51061</key>
            <summary>Rename c preprocessor macro that guards access to invariant.h header.</summary>
                <type id="3" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14718&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="sara.golemon@mongodb.com">Sara Golemon</assignee>
                                    <reporter username="schwerin@mongodb.com">Andy Schwerin</reporter>
                        <labels>
                    </labels>
                <created>Fri, 18 Sep 2020 20:01:02 +0000</created>
                <updated>Sun, 29 Oct 2023 22:02:56 +0000</updated>
                            <resolved>Tue, 4 May 2021 18:53:13 +0000</resolved>
                                                    <fixVersion>5.0.0-rc0</fixVersion>
                                                        <votes>0</votes>
                                    <watches>2</watches>
                                                                                                                <comments>
                            <comment id="3754810" author="xgen-internal-githook" created="Tue, 4 May 2021 17:58:06 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Sara Golemon&apos;, &apos;email&apos;: &apos;sara.golemon@mongodb.com&apos;, &apos;username&apos;: &apos;sgolemon&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-51061&quot; title=&quot;Rename c preprocessor macro that guards access to invariant.h header.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-51061&quot;&gt;&lt;del&gt;SERVER-51061&lt;/del&gt;&lt;/a&gt; Rename WHITELIST macros to ALLOW&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/bd75fc927ec6dbf8a5db6a0377b3b235453f4d71&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/bd75fc927ec6dbf8a5db6a0377b3b235453f4d71&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3751920" author="billy.donahue" created="Mon, 3 May 2021 15:08:33 +0000"  >&lt;p&gt;Ok. If it doesn&apos;t simplify your life, forget it.&lt;br/&gt;
I think it does get in the way of indexing tools and parse-caching strategies.&lt;br/&gt;
A separate ticket is fine. &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-56571&quot; title=&quot;Remove invariant.h allowlist&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-56571&quot;&gt;&lt;del&gt;SERVER-56571&lt;/del&gt;&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="3751623" author="sara.golemon" created="Mon, 3 May 2021 13:24:24 +0000"  >&lt;p&gt;According to the &lt;a href=&quot;https://github.com/mongodb/mongo/blob/85dad3bf26622966b7c144751e14d0d6983bc75d/src/mongo/util/invariant.h#L41&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;comment in invariant.h&lt;/a&gt;, the restriction isn&apos;t to prevent access to the header, it&apos;s just to make the negative effects of an include cycle less problematic for unwary callers.&lt;/p&gt;

&lt;p&gt;I&apos;ll agree that we don&apos;t really need guardrails for that, but at the same time it doesn&apos;t seem to be getting in anyone&apos;s way and is potentially avoiding some issues for somebody.&lt;/p&gt;

&lt;p&gt;If you feel strongly about this then I&apos;d recommend filing a separate ticket for discussion of removing it, while we keep this one to a simple rename which addresses the work in the epic without preventing us from going more aggressive in the future.&lt;/p&gt;</comment>
                            <comment id="3750402" author="billy.donahue" created="Fri, 30 Apr 2021 22:00:11 +0000"  >&lt;p&gt;I think we should just get rid of the &lt;tt&gt;MONGO_INCLUDE_INVARIANT_H_WHITELISTED&lt;/tt&gt; handshake.&lt;br/&gt;
Dozens of files get around it inadvertently by including string_data.h and getting a transitive include of invariant.h.&lt;br/&gt;
I don&apos;t think there&apos;s a technical reason for the restriction. If we just got rid of it we wouldn&apos;t be worse off.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                            <outwardlinks description="related to">
                                        <issuelink>
            <issuekey id="1480368">SERVER-51062</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="1480377">SERVER-51063</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="1699477">SERVER-56571</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>4.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 30 Apr 2021 14:39:07 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        2 years, 40 weeks, 1 day ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10857" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PM-2033</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            2 years, 40 weeks, 1 day ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>schwerin@mongodb.com</customfieldvalue>
            <customfieldvalue>billy.donahue@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>sara.golemon@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hy6vrr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hxtbev:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4832">Security 2021-05-03</customfieldvalue>
    <customfieldvalue id="4833">Security 2021-05-17</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hy6i13:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>