<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 05:25:08 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-51317] Change TransactionCoordinator to use executor from AsynchWorkScheduler</title>
                <link>https://jira.mongodb.org/browse/SERVER-51317</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;&lt;del&gt;I&apos;m not sure if this actually leads to a bug or not, but since we rely on the AsyncWorkScheduler to shut down transaction coordinators, it might be a problem that we also &lt;a href=&quot;https://github.com/mongodb/mongo/blob/ad726654e555009747c5c361039c0c44edcf00d1/src/mongo/db/s/transaction_coordinator.cpp#L138&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;do&lt;/a&gt; &lt;a href=&quot;https://github.com/mongodb/mongo/blob/ad726654e555009747c5c361039c0c44edcf00d1/src/mongo/db/s/transaction_coordinator.cpp#L170&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;work&lt;/a&gt; on the Grid&apos;s fixed executor. We should investigate whether this is a problem and then fix it if it is.&lt;/del&gt;&lt;/p&gt;

&lt;p&gt;This ticket changes &lt;tt&gt;TransactionCoordinator&lt;/tt&gt; to use the executor from &lt;tt&gt;AsynchWorkScheduler&lt;/tt&gt;. The above is tracked by &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-67077&quot; title=&quot;TransactionCoordinator uses both the Grid fixed executor and the executor on the AsyncWorkScheduler&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-67077&quot;&gt;SERVER-67077&lt;/a&gt;.&lt;/p&gt;</description>
                <environment></environment>
        <key id="1499102">SERVER-51317</key>
            <summary>Change TransactionCoordinator to use executor from AsynchWorkScheduler</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.mongodb.org/images/icons/priorities/major.svg">Major - P3</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="13201">Fixed</resolution>
                                        <assignee username="amirsaman.memaripour@mongodb.com">Amirsaman Memaripour</assignee>
                                    <reporter username="matthew.saltz@mongodb.com">Matthew Saltz</reporter>
                        <labels>
                            <label>sharding-nyc-subteam3</label>
                            <label>sharding-wfbf-day</label>
                    </labels>
                <created>Fri, 2 Oct 2020 16:17:18 +0000</created>
                <updated>Sun, 29 Oct 2023 22:02:27 +0000</updated>
                            <resolved>Tue, 7 Jun 2022 18:23:14 +0000</resolved>
                                                    <fixVersion>6.1.0-rc0</fixVersion>
                                    <component>Sharding</component>
                                        <votes>0</votes>
                                    <watches>7</watches>
                                                                                                                <comments>
                            <comment id="4549980" author="JIRAUSER1262333" created="Mon, 16 May 2022 15:18:35 +0000"  >&lt;p&gt;The change I&#160; made for simplification / readability does not address the potential resource leak in server shutdown. See my comment of May 10, 2022.&lt;/p&gt;</comment>
                            <comment id="4546628" author="xgen-internal-githook" created="Thu, 12 May 2022 22:40:53 +0000"  >&lt;p&gt;Author:&lt;/p&gt;
{&apos;name&apos;: &apos;Israel Hsu&apos;, &apos;email&apos;: &apos;israel.hsu@mongodb.com&apos;, &apos;username&apos;: &apos;israelhsu&apos;}
&lt;p&gt;Message: &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-51317&quot; title=&quot;Change TransactionCoordinator to use executor from AsynchWorkScheduler&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-51317&quot;&gt;&lt;del&gt;SERVER-51317&lt;/del&gt;&lt;/a&gt; Change TransactionCoordinator to use executor from AsynchWorkScheduler&lt;br/&gt;
Branch: master&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/f437493c9884751963441fdb98bb27b8f25d84ea&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/f437493c9884751963441fdb98bb27b8f25d84ea&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="4539462" author="JIRAUSER1262333" created="Tue, 10 May 2022 20:11:52 +0000"  >&lt;p&gt;I made a minor change so that the TransactionCoordinator() constructor uses the TaskScheduler that is part of AsyncWorkScheduler; but this does not solve the underlying problem of improper cleanup of scheduled tasks upon shutdown.&#160;&lt;/p&gt;

&lt;p&gt;Both AsyncWorkScheduler and the newer Futures with cancellation tokens implement the ability of having dependency chains of asynchronous work where a child tasks only run after the parent tasks complete, and where the cancellation of a parent task causes all of its children (and recursively, all of its descendents) to be cancelled. The real way to clean up this duplication of implementation is to refactor AsyncWorkScheduler to use cancellation tokens instead of &quot;child executors&quot;.&#160;&lt;/p&gt;

&lt;p&gt;Since this doesn&apos;t have to do with internal transactions per se, I think this ticket needs to go to Service Arch for a proper solution.&lt;/p&gt;</comment>
                            <comment id="4012686" author="JIRAUSER1256988" created="Fri, 20 Aug 2021 13:44:35 +0000"  >&lt;p&gt;I&apos;m unassigned because it&apos;s not a trivial task and I can&apos;t find enough time for it for a while.&lt;/p&gt;</comment>
                            <comment id="3848379" author="JIRAUSER1256988" created="Fri, 28 May 2021 19:23:10 +0000"  >&lt;p&gt;We spoke with &lt;a href=&quot;https://jira.mongodb.org/secure/ViewProfile.jspa?name=matthew.saltz&quot; class=&quot;user-hover&quot; rel=&quot;matthew.saltz&quot;&gt;matthew.saltz&lt;/a&gt; and decided that:&lt;br/&gt;
1. AsyncWorkScheduler::shutdown() is actually non blocking and will be safe to use&lt;br/&gt;
2. The only reason we do job on Grid.*getFixedExecutor() is because AsyncWorkScheduler is not OutOfLineExecutor and people did shortcut by using another but unrelated executor&lt;br/&gt;
3. Refactor AsyncWorkScheduler to be OutOfLineExecutor&lt;br/&gt;
4. Having cancelation tokens here is a nice cleanup but will never be scheduled for execution due to low priority&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10620">
                    <name>Issue split</name>
                                            <outwardlinks description="split to">
                                        <issuelink>
            <issuekey id="2063816">SERVER-67077</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18555" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname># of Sprints</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>12.0</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 28 May 2021 19:23:10 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        1 year, 38 weeks, 2 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_17050" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Downstream Team Attention</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="16941"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>luke.bonanomi@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            1 year, 38 weeks, 2 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10032" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Operating System</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10026"><![CDATA[ALL]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>amirsaman.memaripour@mongodb.com</customfieldvalue>
            <customfieldvalue>andrew.shuvalov@mongodb.com</customfieldvalue>
            <customfieldvalue>xgen-internal-githook</customfieldvalue>
            <customfieldvalue>israel.hsu@mongodb.com</customfieldvalue>
            <customfieldvalue>matthew.saltz@mongodb.com</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hya2vb:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hxjew7:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_22250" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Special Downgrade Instructions Required</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="23343"><![CDATA[Not Needed]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10557" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="4521">Sharding 2021-07-12</customfieldvalue>
    <customfieldvalue id="4522">Sharding 2021-07-26</customfieldvalue>
    <customfieldvalue id="5218">Sharding 2021-08-09</customfieldvalue>
    <customfieldvalue id="5219">Sharding 2021-08-23</customfieldvalue>
    <customfieldvalue id="5730">Sharding 2022-03-07</customfieldvalue>
    <customfieldvalue id="5731">Sharding NYC 2022-03-21</customfieldvalue>
    <customfieldvalue id="5732">Sharding NYC 2022-04-04</customfieldvalue>
    <customfieldvalue id="5733">Sharding NYC 2022-04-18</customfieldvalue>
    <customfieldvalue id="5734">Sharding 2022-05-02</customfieldvalue>
    <customfieldvalue id="5735">Sharding NYC 2022-05-16</customfieldvalue>
    <customfieldvalue id="5736">Sharding NYC 2022-05-30</customfieldvalue>
    <customfieldvalue id="6267">Service Arch 2022-06-13</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    <customfield id="customfield_10555" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>5.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hy9p4n:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>