<!-- 
RSS generated by JIRA (9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66) at Thu Feb 08 03:08:28 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>MongoDB Jira</title>
    <link>https://jira.mongodb.org</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.7.1</version>
        <build-number>970001</build-number>
        <build-date>13-04-2023</build-date>
    </build-info>


<item>
            <title>[SERVER-5292] Patch for SERVER-4333 for 2.0.x</title>
                <link>https://jira.mongodb.org/browse/SERVER-5292</link>
                <project id="10000" key="SERVER">Core Server</project>
                    <description>&lt;p&gt;I&apos;m critically blocked on getting our sharded system live until I can differentiate between true user-initiated INSERTs and balancer-driven inserts.&lt;/p&gt;

&lt;p&gt;Fortunately, Milkie is &quot;the man&quot;, and has fixed this.  Unfortunately, it won&apos;t be in stable until 2.2.&lt;br/&gt;
&lt;a href=&quot;https://github.com/mongodb/mongo/commit/abc3e0cb35c4ab0e837936e04f378c1d963c849b&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/abc3e0cb35c4ab0e837936e04f378c1d963c849b&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;I&apos;ve created a patch, attached here that should apply these changes to 2.0.3.  But when I compiled the patch, built my own RPM, and ran it, I didn&apos;t see the change.  It definitely is running the new 2.0.3 version (I had 2.0.2 on the machine before).&lt;/p&gt;

&lt;p&gt;Milkie, or someone else, is there any other &quot;trick&quot; to getting this behavior to trigger?  Would be a huge win for me, this is literally the last blocker on a major rollout.  Mongo is ready, but without this, I can&apos;t drive our analytics DB properly, so can&apos;t go live.&lt;/p&gt;</description>
                <environment>Amazon Linux</environment>
        <key id="32801">SERVER-5292</key>
            <summary>Patch for SERVER-4333 for 2.0.x</summary>
                <type id="1" iconUrl="https://jira.mongodb.org/secure/viewavatar?size=xsmall&amp;avatarId=14703&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.mongodb.org/images/icons/priorities/critical.svg">Critical - P2</priority>
                        <status id="6" iconUrl="https://jira.mongodb.org/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="9">Done</resolution>
                                        <assignee username="milkie@mongodb.com">Eric Milkie</assignee>
                                    <reporter username="wkoffel">Will Koffel</reporter>
                        <labels>
                    </labels>
                <created>Mon, 12 Mar 2012 21:39:31 +0000</created>
                <updated>Mon, 11 Jul 2016 18:34:10 +0000</updated>
                            <resolved>Thu, 22 Mar 2012 17:22:02 +0000</resolved>
                                    <version>2.0.3</version>
                    <version>2.0.4</version>
                                    <fixVersion>2.1.1</fixVersion>
                                    <component>Replication</component>
                                        <votes>0</votes>
                                    <watches>5</watches>
                                                                                                                <comments>
                            <comment id="101411" author="scotthernandez" created="Thu, 22 Mar 2012 15:32:14 +0000"  >&lt;p&gt;As we don&apos;t backport new features we will provide a squashed patch for 2.0.4 in this special case.&lt;/p&gt;</comment>
                            <comment id="101370" author="milkie" created="Thu, 22 Mar 2012 14:48:27 +0000"  >&lt;p&gt;Commit has been pushed.  Follow &lt;a href=&quot;https://jira.mongodb.org/browse/SERVER-4333&quot; title=&quot;Add flag to the oplog entry for migration/sharding ops&quot; class=&quot;issue-link&quot; data-issue-key=&quot;SERVER-4333&quot;&gt;&lt;del&gt;SERVER-4333&lt;/del&gt;&lt;/a&gt; for updates on backporting.&lt;/p&gt;</comment>
                            <comment id="99547" author="milkie" created="Fri, 16 Mar 2012 14:01:16 +0000"  >&lt;p&gt;Hi Will, Sorry I haven&apos;t gotten back to you yet.  I coded up a patch for this issue on the plane yesterday and tested it out; everything looks good.  However, I can&apos;t push the change yet because we&apos;re in a bit of a mini-code freeze while we sort out some unit testing issues.&lt;/p&gt;

&lt;p&gt;You&apos;ve probably made the same changes I did.  I just went through and added fromMigrate to the parameter list for all the logOp() functions in update.cpp (for completeness).  This change will definitely be in the final 2.2.0 release.  Thanks for bringing this to our attention!&lt;/p&gt;

&lt;p&gt;I&apos;ll leave this open until the change gets pushed into the master 2.1.1 branch.&lt;/p&gt;</comment>
                            <comment id="98684" author="wkoffel" created="Wed, 14 Mar 2012 15:42:43 +0000"  >&lt;p&gt;Okay, so here&apos;s my take at the (2) lines to change.  I&apos;m sure this isn&apos;t the optimal fix, but in my testing, it causes both deletes and inserts to show with the fromMigrate flag.  So hopefully good enough for my purposes until a final fix is in place.&lt;/p&gt;

&lt;p&gt;In db/ops/update.cpp&lt;br/&gt;
Line 1274, logOp needs the fromMigrate flag passed&lt;br/&gt;
Line 1284, logOp needs the fromMigrate flag passed&lt;/p&gt;

&lt;p&gt;In addition, I haven&apos;t found that it&apos;s necessary to pass the flag through to _updateById(), as it doesn&apos;t get used.&lt;/p&gt;

&lt;p&gt;I&apos;m stuck running with this patch for now so I can get my project released.  Obviously I&apos;ll keep a close eye on this ticket, and watch for info I missed, as well as confirmation that it&apos;s working as expected for the 2.2 series releases.&lt;/p&gt;

&lt;p&gt;Thanks for engaging and acknowledging the issue quickly, it gave me the confidence to dive deeper.&lt;/p&gt;

&lt;p&gt;And sorry for not supplying proper patches or git pull requests.  This was a bit of a guerrilla exercise here.&lt;/p&gt;</comment>
                            <comment id="98652" author="wkoffel" created="Wed, 14 Mar 2012 13:59:39 +0000"  >&lt;p&gt;Any love on this, Eric?  Or should I dive in and work on it myself (the beauty and curse of open source!)&lt;/p&gt;

&lt;p&gt;I expect it&apos;s about a 3 line change...those elusive 3 lines haunted my confused dreams last night...&lt;/p&gt;</comment>
                            <comment id="98252" author="wkoffel" created="Tue, 13 Mar 2012 13:24:06 +0000"  >&lt;p&gt;Thanks so much Eric.  Should I watch here or the github logs?  If this won&apos;t get done right away, can you point me anywhere that I can look for the fix myself?  I&apos;m on a major deadline this week, so I&apos;ll be working on it in parallel today, but obviously you&apos;re a lot more equipped to get it right!  Let me know if there&apos;s anything at all I can do to help.&lt;/p&gt;</comment>
                            <comment id="98144" author="milkie" created="Tue, 13 Mar 2012 03:44:14 +0000"  >&lt;p&gt;You&apos;re right; the insert logging is broken. I&apos;ll fix it. &lt;/p&gt;

&lt;p&gt;&amp;#8211; Posted from Bugbox for iPhone&lt;/p&gt;</comment>
                            <comment id="98126" author="wkoffel" created="Tue, 13 Mar 2012 02:13:41 +0000"  >&lt;p&gt;Hey guys, here&apos;s what I&apos;ve discovered after getting a test environment set up...&lt;/p&gt;

&lt;p&gt;It appears that DELETE ops, (&lt;/p&gt;
{&quot;op&quot;:&quot;d&quot;}
&lt;p&gt;) are getting the &lt;/p&gt;
{&quot;fromMigrate&quot;:true}
&lt;p&gt; flag set correctly.  This makes sense.  It happens in your patches (&lt;a href=&quot;https://github.com/mongodb/mongo/commit/abc3e0cb35c4ab0e837936e04f378c1d963c849b&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://github.com/mongodb/mongo/commit/abc3e0cb35c4ab0e837936e04f378c1d963c849b&lt;/a&gt;) at db/dbhelpers.cpp line 241.&lt;/p&gt;

&lt;p&gt;HOWEVER, the corresponding INSERTs don&apos;t have any sign of the &quot;fromMigrate&quot; flag, they seem to have not been affected at all.&lt;br/&gt;
I can trace the code path into the db/ops/update.cpp line 911 (I&apos;m referencing all numbers from the HEAD branch, rather than my patched 2.0.3 rev), where the process calls &quot;_updateById(....)&quot;&lt;/p&gt;

&lt;p&gt;Inside _updateById, although it takes the &apos;bool fromMigrate&apos; final argument, it NEVER uses that argument anywhere.  That seems to be a problem.  If it didn&apos;t need the arg, why include it.  My hunch is that it does need it, but the patch is incomplete.&lt;/p&gt;

&lt;p&gt;So unless I&apos;m missing something (definitely possible), there might be a bug in your patch as well as my patch.&lt;/p&gt;

&lt;p&gt;Any thoughts?  I get a bit lost inside that _updateById() function, so I can&apos;t tell where the actual logOp happens.  This also might be a red-herring, since the op gets logged as an insert &lt;/p&gt;
{&quot;op&quot;:&quot;i&quot;}
&lt;p&gt;, and the only ops I see from _updateById() are UPDATE ops.  &lt;/p&gt;

&lt;p&gt;So maybe the issue is further back, inside update.cpp line 1274 and 1284 both are suspect, as they log inserts, but don&apos;t include the fromMigrate param that was passed into that function.  Should they?&lt;/p&gt;


</comment>
                            <comment id="98070" author="wkoffel" created="Mon, 12 Mar 2012 22:01:14 +0000"  >&lt;p&gt;second patch file, forgot to include the /s/ subdir.&lt;/p&gt;</comment>
                            <comment id="98069" author="wkoffel" created="Mon, 12 Mar 2012 22:00:54 +0000"  >&lt;p&gt;Sorry, yes, I also did patch that.  When I ran my diff, I did it just on the db/ subdir.  But the d_migrate.cpp is also patched.  Clearly that&apos;s where the actual work happens. &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.mongodb.org/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;

&lt;p&gt;I&apos;ve attached that patch here now as well (sorry, I&apos;ve been working in that dir, so there&apos;s a bunch of extraneous object files, etc.)&lt;/p&gt;
</comment>
                            <comment id="98066" author="eliot" created="Mon, 12 Mar 2012 21:51:32 +0000"  >&lt;p&gt;Looks like you&apos;re missing the patch to s/d_migrate.cpp that actually makes the change.&lt;br/&gt;
let me know if you need help.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Depends</name>
                                            <outwardlinks description="depends on">
                                        <issuelink>
            <issuekey id="25166">SERVER-4333</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                            <issuelinktype id="10012">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                                        </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="15328" name="oplog_fromMigrate.2.0.3.patch" size="12901" author="wkoffel" created="Mon, 12 Mar 2012 21:39:31 +0000"/>
                            <attachment id="15329" name="oplog_fromMigrate.2.patch" size="5146" author="wkoffel" created="Mon, 12 Mar 2012 22:01:14 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10050" key="com.atlassian.jira.toolkit:comments">
                        <customfieldname># Replies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>11.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10011" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Backwards Compatibility</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10038"><![CDATA[Fully Compatible]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10055" key="com.atlassian.jira.ext.charting:firstresponsedate">
                        <customfieldname>Date of 1st Reply</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 12 Mar 2012 21:51:32 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10052" key="com.atlassian.jira.toolkit:dayslastcommented">
                        <customfieldname>Days since reply</customfieldname>
                        <customfieldvalues>
                                        11 years, 47 weeks, 6 days ago
    
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_18254" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Dependencies</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue><![CDATA[<s><a href='https://jira.mongodb.org/browse/SERVER-4333'>SERVER-4333</a></s>]]></customfieldvalue>


                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_15850" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_10057" key="com.atlassian.jira.toolkit:lastusercommented">
                        <customfieldname>Last comment by Customer</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>true</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10056" key="com.atlassian.jira.toolkit:lastupdaterorcommenter">
                        <customfieldname>Last commenter</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>ramon.fernandez@mongodb.com</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_11151" key="com.atlassian.jira.toolkit:LastCommentDate">
                        <customfieldname>Last public comment date</customfieldname>
                        <customfieldvalues>
                            11 years, 47 weeks, 6 days ago
                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10000" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Old_Backport</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10000"><![CDATA[No]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10051" key="com.atlassian.jira.toolkit:participants">
                        <customfieldname>Participants</customfieldname>
                        <customfieldvalues>
                                        <customfieldvalue>eliot</customfieldvalue>
            <customfieldvalue>milkie@mongodb.com</customfieldvalue>
            <customfieldvalue>scotthernandez</customfieldvalue>
            <customfieldvalue>wkoffel</customfieldvalue>
    
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        <customfield id="customfield_14254" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Product Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hro9sf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_12550" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>2|hrgd87:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10558" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9052</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_23361" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Requested By</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                <customfield id="customfield_10166" key="com.atlassian.jira.plugin.system.customfieldtypes:radiobuttons">
                        <customfieldname>Tests Written</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10153"><![CDATA[Unneeded]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10053" key="com.atlassian.jira.ext.charting:timeinstatus">
                        <customfieldname>Time In Status</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_22870" key="com.onresolve.jira.groovy.groovyrunner:scripted-field">
                        <customfieldname>Triagers</customfieldname>
                        <customfieldvalues>
                                

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                    <customfield id="customfield_14350" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>serverRank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hrkw3r:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                    </customfields>
    </item>
</channel>
</rss>